deprecate: boto3 resources (#2097)

* Deprecate boto3 resources

* Types

* Un-deprecate create_athena_bucket

* Revert DynamoDB changes

Author: kukushking

awswrangler/athena/_utils.py

@@ -354,17 +354,16 @@ def create_athena_bucket(boto3_session: Optional[boto3.Session] = None) -> str:
     region_name: str = _utils.get_region_from_session(boto3_session=boto3_session).lower()
     bucket_name = f"aws-athena-query-results-{account_id}-{region_name}"
     path = f"s3://{bucket_name}/"
-    resource = _utils.resource(service_name="s3", session=boto3_session)
-    bucket = resource.Bucket(bucket_name)
+    client_s3 = _utils.client(service_name="s3", session=boto3_session)
     args = {} if region_name == "us-east-1" else {"CreateBucketConfiguration": {"LocationConstraint": region_name}}
     try:
-        bucket.create(**args)
-    except resource.meta.client.exceptions.BucketAlreadyOwnedByYou as err:
+        client_s3.create_bucket(Bucket=bucket_name, **args)
+    except (client_s3.exceptions.BucketAlreadyExists, client_s3.exceptions.BucketAlreadyOwnedByYou) as err:
         _logger.debug("Bucket %s already exists.", err.response["Error"]["BucketName"])
     except botocore.exceptions.ClientError as err:
         if err.response["Error"]["Code"] == "OperationAborted":
             _logger.debug("A conflicting conditional operation is currently in progress against this resource.")
-    bucket.wait_until_exists()
+    client_s3.get_waiter("bucket_exists").wait(Bucket=bucket_name)
     return path
 
 

awswrangler/redshift.py

@@ -80,10 +80,9 @@ def _does_table_exist(cursor: redshift_connector.Cursor, schema: Optional[str],
 
 
 def _get_paths_from_manifest(path: str, boto3_session: Optional[boto3.Session] = None) -> List[str]:
-    resource_s3: boto3.resource = _utils.resource(service_name="s3", session=boto3_session)
+    client_s3 = _utils.client(service_name="s3", session=boto3_session)
     bucket, key = _utils.parse_path(path)
-    content_object = resource_s3.Object(bucket, key)
-    manifest_content = json.loads(content_object.get()["Body"].read().decode("utf-8"))
+    manifest_content = json.loads(client_s3.get_object(Bucket=bucket, Key=key)["Body"].read().decode("utf-8"))
     return [path["url"] for path in manifest_content["entries"]]
 
 

awswrangler/s3/_copy.py

@@ -22,7 +22,6 @@ def _copy_objects(
 ) -> None:
     _logger.debug("len(batch): %s", len(batch))
     client_s3: boto3.client = _utils.client(service_name="s3", session=boto3_session)
-    resource_s3: boto3.resource = _utils.resource(service_name="s3", session=boto3_session)
     if s3_additional_kwargs is None:
         boto3_kwargs: Optional[Dict[str, Any]] = None
     else:
@@ -31,11 +30,10 @@ def _copy_objects(
         source_bucket, source_key = _utils.parse_path(path=source)
         copy_source: Dict[str, str] = {"Bucket": source_bucket, "Key": source_key}
         target_bucket, target_key = _utils.parse_path(path=target)
-        resource_s3.meta.client.copy(
+        client_s3.copy(
             CopySource=copy_source,
             Bucket=target_bucket,
             Key=target_key,
-            SourceClient=client_s3,
             ExtraArgs=boto3_kwargs,
             Config=TransferConfig(num_download_attempts=10, use_threads=use_threads),
         )