Fix logger error in container logs #458
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viveksb007
reviewed
Aug 27, 2025
Contributor
viveksb007
left a comment
viveksb007
left a comment
There was a problem hiding this comment.
is there any example log of what kind of logging is done by this controller-runtime?
checking if its possible to remove this logger setting here altogether https://github.com/aws/aws-network-policy-agent/blob/2db0a7833a8aae9dd77c27578cb09b1dd2cca09d/main.go#L76C2-L76C53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
All application logging has stack depth of 2 for caller. For the controller logger we have stack depth of 0. As we have set global caller stack depth of 2 so it is logging an error in container logs for creating logger for controller runtime
Description of changes:
For controller logger use stack depth of 0 for caller. Rest all application logging uses stack depth of 2
Testing
Above error does not appear in container log after the fix
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.