refactor(connection, client-protocol): log when there is a mismatch in requested vs granted protocol

Author: Brooke-white

redshift_connector/core.py

@@ -1,3 +1,4 @@
+import logging
 import os
 import socket
 import typing
@@ -115,6 +116,7 @@
 
 __author__ = "Mathieu Fenniak"
 
+_logger: logging.Logger = logging.getLogger(__name__)
 
 ZERO: Timedelta = Timedelta(0)
 BINARY: type = bytes
@@ -1364,12 +1366,11 @@ def handle_PARAMETER_STATUS(self: "Connection", data: bytes, ps) -> None:
             # when a mismatch occurs between the client's requested protocol version, and the server's response,
             # warn the user and follow server
             if self._client_protocol_version != int(value):
-                warn(
+                _logger.debug(
                     "Server indicated {} transfer protocol will be used rather than protocol requested by client: {}".format(
                         ClientProtocolVersion.get_name(int(value)),
                         ClientProtocolVersion.get_name(self._client_protocol_version),
-                    ),
-                    stacklevel=3,
+                    )
                 )
                 self._client_protocol_version = int(value)
         elif key == b"server_version":

test/integration/test_connection.py

@@ -1,4 +1,5 @@
 import configparser
+import logging
 import os
 import random
 import socket
@@ -16,6 +17,8 @@
 root_path = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
 conf.read(root_path + "/config.ini")
 
+logger = logging.getLogger(__name__)
+
 # Check if running in Jython
 if "java" in sys.platform:
     from jarray import array  # type: ignore
@@ -195,12 +198,17 @@ def test_client_protocol_version_is_used(db_kwargs, _input):
         assert conn._client_protocol_version == _input
 
 
-def test_client_protocol_version_invalid_warns_user(db_kwargs):
+def test_client_protocol_version_invalid_logs(db_kwargs, caplog):
     db_kwargs["client_protocol_version"] = max(ClientProtocolVersion.list()) + 1
     del db_kwargs["region"]
     del db_kwargs["cluster_identifier"]
-    with pytest.warns(UserWarning):
-        redshift_connector.Connection(**db_kwargs)
+
+    with caplog.at_level(logging.DEBUG):
+        with redshift_connector.Connection(**db_kwargs) as con:
+            act_client_protocol: int = con._client_protocol_version
+    assert "Server indicated {} transfer protocol will be used rather than protocol requested by client: {}".format(
+        act_client_protocol, db_kwargs["client_protocol_version"]
+    )
 
 
 def test_stl_connection_log_contains_driver_version(db_kwargs):