merged changes for 1.1.3 from mainline-dev onto mainline (#672)

* Add accessibility label to checkboxes in Check Data (#648)

Added accessibility labels to the checkboxes so the text-to-speech screen reader will output the column header name

* Miguel.abreu/gtt 1583 y axis labels cut off (#646)

* Refactor bar char size logic

* Added RulerService to measure how many pixels a word takes in the screen
* Refactor yAxis formatter to trim the label at a size that fits in one line preventing the fault logic of label splitter provided by recharts

* RulerService unit tests

* Minor refactor for ruler div creation

* Encode ruler div content

Co-authored-by: Miguel Abreu <miabreu@amazon.com>

* Fix position of actions dropdown on mobile (#641)

* Store favicon image name (#649)

Co-authored-by: Miguel Pavon Diaz <71112226+miguelpdiaz8@users.noreply.github.com>

* Fix section highlight while scrolling up (#650)

* Add new alt text field (#656)

Co-authored-by: Miguel Abreu <miabreu@amazon.com>

* logo name (#655)

Co-authored-by: Miguel Pavon Diaz <71112226+miguelpdiaz8@users.noreply.github.com>

* Add reactive error handling and RadioButtonTile component on Choose data step (#657)

* Enforce test coverage thresholds (#659)

Backend: 70% coverage
Frontend: 45% coverage

Co-authored-by: Miguel Abreu <miabreu@amazon.com>

* Update README info (#660)

* Use container width for computation (#661)

Co-authored-by: Miguel Abreu <miabreu@amazon.com>

* Click scrolls when not visible (#662)

* Manipulating DOM to click scrolls when not visible

* Manipulating DOM to click scrolls when not visible

* Move logic to the Tabs container

* Move to react apis

* Remove unused import

* Remove custom logs

Co-authored-by: Miguel Abreu <miabreu@amazon.com>

* GTT-1590 - Removed 403 error handler.  Added bucket policy to allow for CF to access bucket (#663)

* Remove 403 error handler.  Add bucket policy to allow for CF to access bucket

* enabled prettier check

* Ran prettier on WAF template

* GTT 1602 : bump ansi-regex from 5.0.0 to 5.0.1 in backend (#667)

* bump ansi-regex from 5.0.0 to 5.0.1

* Trigger Build

* bump version of ansi-regex per dependabot finding

* bump ansi-regex

* Upgrade to 1.1.3 (#670)

* Update runbook (#668)

Co-authored-by: Triet <triet05@gmail.com>

* New translated labels (#671)

Co-authored-by: chasechow7 <92477064+chasechow7@users.noreply.github.com>
Co-authored-by: Miguel Alfonso Abreu Ortega <mabreuortega@gmail.com>
Co-authored-by: Miguel Abreu <miabreu@amazon.com>
Co-authored-by: Miguel Pavon Diaz <71112226+miguelpdiaz8@users.noreply.github.com>

Author: 5 people

CHANGELOG.md

@@ -5,6 +5,14 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.1.3] - 2021-10-28
+
+### Added
+
+- On public dashboard page, scrolling up now highlights a Section's table of contents entry
+- Improved accessiblity by adding labels to the Check Data column checkboxes and alt-text for the logo upload in Settings
+- Uploaded favicon retains original filename
+
 ## [1.1.2] - 2021-10-14
 
 ### Added

README.md

@@ -33,7 +33,7 @@ PDoA comes with pre-built code to provision an instance in your AWS account. You
 
 | Region               | Launch                                                                                                                                                                                                                                                                                                                             |
 | -------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
-| Install in us-east-1 | [![Install in us-east-1](docs/images/launch-stack.svg)](https://console.aws.amazon.com/cloudformation/home?region=us-east-1#/stacks/quickcreate?templateURL=https://performance-dashboard-on-aws-solution-releases-us-west-2.s3.us-west-2.amazonaws.com/performance-dashboard-on-aws/v1.1.2/performance-dashboard-on-aws.template) |
+| Install in us-east-1 | [![Install in us-east-1](docs/images/launch-stack.svg)](https://console.aws.amazon.com/cloudformation/home?region=us-east-1#/stacks/quickcreate?templateURL=https://performance-dashboard-on-aws-solution-releases-us-west-2.s3.us-west-2.amazonaws.com/performance-dashboard-on-aws/v1.1.3/performance-dashboard-on-aws.template) |
 
 ### Clone this repository
 

backend/jest.config.js

@@ -1,7 +1,13 @@
 module.exports = {
-    preset: 'ts-jest',
-    testEnvironment: "node",
-    roots: [
-        "<rootDir>/src"
-    ],
-}
+  preset: "ts-jest",
+  testEnvironment: "node",
+  roots: ["<rootDir>/src"],
+  coverageThreshold: {
+    global: {
+      branches: 70,
+      functions: 80,
+      lines: 80,
+      statements: 80,
+    },
+  },
+};

backend/package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "performance-dashboard-backend",
-  "version": "1.1.2",
+  "version": "1.1.3",
   "description": "Performance Dashboard on AWS Backend",
   "awssdkUserAgent": "AwsSolution/SO0157/v",
   "scripts": {

backend/package.json

@@ -20,6 +20,7 @@ async function updateSettings(req: Request, res: Response) {
     navbarTitle,
     topicAreaLabels,
     customLogoS3Key,
+    customLogoAltText,
     customFaviconS3Key,
     colors,
     adminContactEmailAddress,
@@ -90,6 +91,15 @@ async function updateSettings(req: Request, res: Response) {
     );
   }
 
+  if (customLogoAltText) {
+    updatedAt = await repo.updateSetting(
+      "customLogoAltText",
+      customLogoAltText,
+      updatedAt,
+      user
+    );
+  }
+
   if (customFaviconS3Key) {
     updatedAt = await repo.updateSetting(
       "customFaviconS3Key",

backend/src/lib/controllers/settings-ctrl.ts

@@ -43,6 +43,7 @@ describe("fromItem", () => {
         plural: "Topic Areas",
       },
       customLogoS3Key: "12345",
+      customLogoAltText: "Alt text",
       customFaviconS3Key: "12345",
       contactEmailAddress: "test@aol.com",
       adminContactEmailAddress: "admin@aol.com",
@@ -62,6 +63,7 @@ describe("fromItem", () => {
         plural: "Topic Areas",
       },
       customLogoS3Key: "12345",
+      customLogoAltText: "Alt text",
       customFaviconS3Key: "12345",
       colors: {
         primary: "#2491ff",
@@ -88,6 +90,7 @@ describe("toPublicSettings", () => {
         plural: "Topic Areas",
       },
       customLogoS3Key: "12345",
+      customLogoAltText: "Alt text",
       customFaviconS3Key: "12345",
       colors: {
         primary: "#ffffff",

backend/src/lib/factories/__tests__/settings-factory.test.ts

@@ -16,6 +16,7 @@ function getDefaultSettings(): Settings {
       plural: "Topic Areas",
     },
     customLogoS3Key: undefined,
+    customLogoAltText: undefined,
     customFaviconS3Key: undefined,
     colors: {
       primary: "#2491ff",
@@ -41,6 +42,9 @@ function fromItem(item: SettingsItem): Settings {
     customLogoS3Key: item.customLogoS3Key
       ? item.customLogoS3Key
       : defaults.customLogoS3Key,
+    customLogoAltText: item.customLogoAltText
+      ? item.customLogoAltText
+      : defaults.customLogoAltText,
     customFaviconS3Key: item.customFaviconS3Key
       ? item.customFaviconS3Key
       : defaults.customFaviconS3Key,

backend/src/lib/factories/settings-factory.ts

@@ -11,6 +11,7 @@ export interface Settings {
     plural: string;
   };
   customLogoS3Key: string | undefined;
+  customLogoAltText: string | undefined;
   customFaviconS3Key: string | undefined;
   colors?: {
     primary: string;
@@ -55,6 +56,7 @@ export interface SettingsItem {
     plural: string;
   };
   customLogoS3Key: string | undefined;
+  customLogoAltText: string | undefined;
   customFaviconS3Key: string | undefined;
   colors?: {
     primary: string;

backend/src/lib/models/settings.ts

@@ -52,6 +52,7 @@ describe("getSettings", () => {
         plural: "Topic Areas",
       },
       customLogoS3Key: "12345",
+      customLogoAltText: "Alt text",
       customFaviconS3Key: "12345",
     };