fix: handle custom resource deletion (#1036)

denisquesada · denisquesada · commit 1ad3c8931a43 · 2023-07-17T09:13:33.000-07:00
diff --git a/.viperlightrc b/.viperlightrc
@@ -0,0 +1,4 @@
+{
+    "all": true,
+    "failOn": "medium"
+  }
diff --git a/cdk/lib/envconfig/index.ts b/cdk/lib/envconfig/index.ts
@@ -19,7 +19,9 @@ export const handler = async (event: any): Promise<void> => {
         return await uploadConfig();
     }
 
-    return await Promise.reject(new Error("Invalid config type"));
+    // On Delete do nothing
+    console.log("On Delete do nothing");
+    return await Promise.resolve();
 };
 
 const uploadConfig = async () => {

-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +{
 +    "all": true,
 +    "failOn": "medium"
 +  }
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,9 @@ export const handler = async (event: any): Promise<void> => {`
`19`	`19`	`return await uploadConfig();`
`20`	`20`	`}`
`21`	`21`
`22`		`- return await Promise.reject(new Error("Invalid config type"));`
	`22`	`+ // On Delete do nothing`
	`23`	`+ console.log("On Delete do nothing");`
	`24`	`+ return await Promise.resolve();`
`23`	`25`	`};`
`24`	`26`
`25`	`27`	`const uploadConfig = async () => {`