JMeter Jar updates cause class compatiblity issues

[tilln]

Describe the bug
The jar_updater.py replaces JMeter Jar files with more recent versions, however, this causes an IncompatibleClassChangeError for (at least) the Blazemeter HTTP2 plugin's HTTP2 Sampler.

To Reproduce
Run a JMeter scenario with a script that includes an HTTP2 Sampler.

Expected behavior
HTTP2 sampler should work.

Please complete the following information about the solution:

• Version: 4.0.0
• Region: independent of region
• Was the solution modified from the version published on this repository? No
• If the answer to the previous question was yes, are the changes available on GitHub? n/a
• Have you checked your service quotas for the services this solution uses? n/a
• Were there any errors in the CloudWatch Logs? n/a

Screenshots
n/a

Logs
jmeter-<...>.log

java.lang.IncompatibleClassChangeError: Method 'org.eclipse.jetty.util.QuotedStringTokenizer$Builder org.eclipse.jetty.util.QuotedStringTokenizer.builder()' must be Methodref constant
	at org.eclipse.jetty.http.HttpField.<clinit>(HttpField.java:37) ~[jetty-http-12.0.25.jar:12.0.25]
	at org.eclipse.jetty.client.HttpClient.<init>(HttpClient.java:135) ~[jetty-client-11.0.15.jar:11.0.15]
	at com.blazemeter.jmeter.http2.core.HTTP2JettyClient.<init>(HTTP2JettyClient.java:174) ~[jmeter-bzm-http2-2.0.6.jar:?]
	at com.blazemeter.jmeter.http2.sampler.HTTP2Sampler.buildClient(HTTP2Sampler.java:240) ~[jmeter-bzm-http2-2.0.6.jar:?]
	at com.blazemeter.jmeter.http2.sampler.HTTP2Sampler.getClient(HTTP2Sampler.java:255) ~[jmeter-bzm-http2-2.0.6.jar:?]
	at com.blazemeter.jmeter.http2.sampler.HTTP2Sampler.sample(HTTP2Sampler.java:162) ~[jmeter-bzm-http2-2.0.6.jar:?]
	at org.apache.jmeter.protocol.http.sampler.HTTPSamplerBase.sample(HTTPSamplerBase.java:1311) ~[ApacheJMeter_http.jar:5.6.3]
	at org.apache.jmeter.protocol.http.sampler.HTTPSamplerBase.sample(HTTPSamplerBase.java:1300) ~[ApacheJMeter_http.jar:5.6.3]
	at org.apache.jmeter.threads.JMeterThread.doSampling(JMeterThread.java:651) ~[ApacheJMeter_core.jar:5.6.3]
	at org.apache.jmeter.threads.JMeterThread.executeSamplePackage(JMeterThread.java:570) ~[ApacheJMeter_core.jar:5.6.3]
	at org.apache.jmeter.threads.JMeterThread.processSampler(JMeterThread.java:501) ~[ApacheJMeter_core.jar:5.6.3]
	at org.apache.jmeter.threads.JMeterThread.run(JMeterThread.java:268) ~[ApacheJMeter_core.jar:5.6.3]
	at java.base/java.lang.Thread.run(Thread.java:1583) [?:?]

Additional context

[owen-brady]

Thank you for the bug report! We've reproduced the issue and will give an update very soon.

[ianwow]

This issue has been fixed in main by #269

[tilln]

The fix does not work but there are other compatibility issues now. Please re-open this or alternatively I'm happy to log a new issue.

Now the HTTP2 sampler runs though it fails with below exception.

java.util.concurrent.ExecutionException: java.lang.NoSuchMethodError: 'void org.eclipse.jetty.http2.HTTP2Session.<init>(org.eclipse.jetty.util.thread.Scheduler, org.eclipse.jetty.io.EndPoint, org.eclipse.jetty.http2.generator.Generator, org.eclipse.jetty.http2.api.Session$Listener, org.eclipse.jetty.http2.FlowControlStrategy, int)'
	at com.blazemeter.jmeter.http2.core.HTTP2FutureResponseListener.getResult(HTTP2FutureResponseListener.java:121)
	at com.blazemeter.jmeter.http2.core.HTTP2FutureResponseListener.get(HTTP2FutureResponseListener.java:93)
	at com.blazemeter.jmeter.http2.core.HTTP2JettyClient.getContent(HTTP2JettyClient.java:413)
	at com.blazemeter.jmeter.http2.core.HTTP2JettyClient.sampleFromListener(HTTP2JettyClient.java:369)
	at com.blazemeter.jmeter.http2.sampler.HTTP2Sampler.sampleFromListener(HTTP2Sampler.java:211)
	at com.blazemeter.jmeter.http2.sampler.HTTP2Sampler.sample(HTTP2Sampler.java:176)
	at org.apache.jmeter.protocol.http.sampler.HTTPSamplerBase.sample(HTTPSamplerBase.java:1311)
	at org.apache.jmeter.protocol.http.sampler.HTTPSamplerBase.sample(HTTPSamplerBase.java:1300)
	at org.apache.jmeter.threads.JMeterThread.doSampling(JMeterThread.java:651)
	at org.apache.jmeter.threads.JMeterThread.executeSamplePackage(JMeterThread.java:570)
	at org.apache.jmeter.threads.JMeterThread.processSampler(JMeterThread.java:501)
	at org.apache.jmeter.threads.JMeterThread.run(JMeterThread.java:268)
	at java.base/java.lang.Thread.run(Thread.java:1583)
Caused by: java.lang.NoSuchMethodError: 'void org.eclipse.jetty.http2.HTTP2Session.<init>(org.eclipse.jetty.util.thread.Scheduler, org.eclipse.jetty.io.EndPoint, org.eclipse.jetty.http2.generator.Generator, org.eclipse.jetty.http2.api.Session$Listener, org.eclipse.jetty.http2.FlowControlStrategy, int)'
	at org.eclipse.jetty.http2.client.HTTP2ClientSession.<init>(HTTP2ClientSession.java:39)
	at org.eclipse.jetty.http2.client.HTTP2ClientConnectionFactory.newConnection(HTTP2ClientConnectionFactory.java:61)
	at org.eclipse.jetty.http2.client.http.ClientConnectionFactoryOverHTTP2.newConnection(ClientConnectionFactoryOverHTTP2.java:53)
	at org.eclipse.jetty.client.dynamic.HttpClientTransportDynamic.newNegotiatedConnection(HttpClientTransportDynamic.java:245)
	at org.eclipse.jetty.io.NegotiatingClientConnection.replaceConnection(NegotiatingClientConnection.java:117)
	at org.eclipse.jetty.io.NegotiatingClientConnection.onFillable(NegotiatingClientConnection.java:87)
	at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:314)
	at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:100)
	at org.eclipse.jetty.io.ssl.SslConnection$DecryptedEndPoint.onFillable(SslConnection.java:558)
	at org.eclipse.jetty.io.ssl.SslConnection.onFillable(SslConnection.java:379)
	at org.eclipse.jetty.io.ssl.SslConnection$2.succeeded(SslConnection.java:146)
	at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:100)
	at org.eclipse.jetty.io.SelectableChannelEndPoint$1.run(SelectableChannelEndPoint.java:53)
	at org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.runTask(AdaptiveExecutionStrategy.java:416)
	at org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.consumeTask(AdaptiveExecutionStrategy.java:385)
	at org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.tryProduce(AdaptiveExecutionStrategy.java:272)
	at org.eclipse.jetty.util.thread.strategy.AdaptiveExecutionStrategy.lambda$new$0(AdaptiveExecutionStrategy.java:140)
	at org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:411)
	at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:969)
	at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.doRunJob(QueuedThreadPool.java:1194)
	at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1149)
	... 1 more

[ianwow]

I have not been able to reproduce this error.

Would it be possible for you to add your jmx script file to this issue?

[tilln]

@ianwow
Have you also replaced those other two Jars, as the jar_updater.py does?

    "http2-hpack": "org/eclipse/jetty/http2/http2-hpack/11.0.26/http2-hpack-11.0.26.jar",
    "jetty-http": "org/eclipse/jetty/jetty-http/11.0.26/jetty-http-11.0.26.jar",
    "http2-common": "org/eclipse/jetty/http2/http2-common/11.0.26/http2-common-11.0.26.jar",

Doing this with a local JMeter installation reproduces this easily for me, with any HTTP2 request.

Looking at the Javadoc one can see that method/constructor signatures change between 11.0.15 (what the HTTP2 plugin expects) and 11.0.26 (the replacement).

Script is trivial dlt-issue268.jmx.xml

[ianwow]

Can I see the output from your local JMeter test that shows what happened after you updated those three jar files? e.g. Like this:

JVM_ARGS="-verbose:class" jmeter -n -t dlt-issue268.jmx 2> http2_test.err > http2_test.out

[tilln]

Here you go: http2_test.out.txt

[ianwow]

I have reproduced this error. Working on a fix...