fix(logger): merge child logger options correctly (#1178)

* bug(logger): fix bug when child logger with overwritten options clears all other options

* test(logger): add tests for createChild method

* refactor(logger): remove clonedeep dependency

* refactor(logger): move initOptions initializer to setOptions

* feat(logger): add addPersistentLogAttributes from parent to child logger

* test(logger): add tests for createChild with persistent log attrs

* feat(logger): added addContext support, remove redundant initOption

* refactor(logger): add parent's context to child explicitly, without merging

Author: shdq

package-lock.json

@@ -32,7 +32,6 @@
   "types": "./lib/index.d.ts",
   "typedocMain": "src/index.ts",
   "devDependencies": {
-    "@types/lodash.clonedeep": "^4.5.7",
     "@types/lodash.merge": "^4.6.7",
     "@types/lodash.pickby": "^4.6.7"
   },
@@ -48,7 +47,6 @@
   },
   "dependencies": {
     "@aws-lambda-powertools/commons": "^1.4.1",
-    "lodash.clonedeep": "^4.5.0",
     "lodash.merge": "^4.6.2",
     "lodash.pickby": "^4.6.0"
   },

packages/logger/package.json

@@ -3,7 +3,6 @@ import type { Context, Handler } from 'aws-lambda';
 import { Utility } from '@aws-lambda-powertools/commons';
 import { LogFormatterInterface, PowertoolLogFormatter } from './formatter';
 import { LogItem } from './log';
-import cloneDeep from 'lodash.clonedeep';
 import merge from 'lodash.merge';
 import { ConfigServiceInterface, EnvironmentVariablesService } from './config';
 import { LogJsonIndent } from './types';
@@ -151,7 +150,6 @@ class Logger extends Utility implements ClassThatLogs {
    */
   public constructor(options: ConstructorOptions = {}) {
     super();
-
     this.setOptions(options);
   }
 
@@ -205,7 +203,17 @@ class Logger extends Utility implements ClassThatLogs {
    * @returns {Logger}
    */
   public createChild(options: ConstructorOptions = {}): Logger {
-    return cloneDeep(this).setOptions(options);
+    const parentsPowertoolsLogData = this.getPowertoolLogData();
+    const childLogger = new Logger(merge({}, parentsPowertoolsLogData, options));
+    
+    const parentsPersistentLogAttributes = this.getPersistentLogAttributes();
+    childLogger.addPersistentLogAttributes(parentsPersistentLogAttributes);
+    
+    if (parentsPowertoolsLogData.lambdaContext) {
+      childLogger.addContext(parentsPowertoolsLogData.lambdaContext as Context);
+    }
+    
+    return childLogger;
   }
 
   /**