build(all): use es2019 target to support on Node12 (#925)

Switching to target 2019 to support Node12

Previously, we have been building our packages on target es2020. When customers consume our modules, it will still have ?.. If customers use NodeJS12 (which is es2019), it will throw an error SyntaxError: Unexpected token '.'. The . is the second character of ?. syntax.

To fix this, we change all of the target to 2019. However, this cause a lot of breaks in our current code.

1. Branch coverage will drop as ?. is broken into a conditional statement. We need to add new test cases or tell TS that the value does exist by adding !. This is really case by case as the value cannot really be undefined in some case.
2. NodeJS12 doesn't have crypto.randomUUID that we use in e2e tests. So we have to add uuid as a devDependency

This commit also adds the additional checks on NodeJS12 and NodeJS14. (We tested only on Node16). The failing one is Node12, and it fails on examples/sam package. This package uses the npm published version of our library. And it really should fail as the currently published library is target 2020. Once we publish a new version, this should be fixed automatically.

Author: ijemmy

.github/workflows/pr_lint_and_test.yml

@@ -7,12 +7,16 @@ jobs:
     runs-on: ubuntu-latest
     env:
       NODE_ENV: dev
+    strategy:
+      matrix:
+        version: [12, 14, 16]
+      fail-fast: false
     steps:
       - uses: actions/checkout@v3
-      - name: "Use NodeJS 16"
+      - name: "Use NodeJS"
         uses: actions/setup-node@v3
         with:
-          node-version: '16'
+          node-version: ${{ matrix.version }}
       - name: Install npm@8.x
         run: npm i -g npm@next-8
       - name: "Setup npm"

.github/workflows/run-e2e-tests.yml

@@ -49,13 +49,14 @@ jobs:
       matrix:
         package: [logger, metrics, tracer]
         version: [12, 14, 16]
+      fail-fast: false
     steps:
       - name: "Checkout"
         uses: actions/checkout@v3
-      - name: "Use NodeJS 16"
+      - name: "Use NodeJS"
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: ${{ matrix.version }}
       - name: "Install npm@8.x"
         run: npm i -g npm@next-8
       - name: "Install monorepo packages"

examples/cdk/tsconfig.json

@@ -2,7 +2,7 @@
   "compilerOptions": {
     "experimentalDecorators": true,
     "noImplicitAny": true,
-    "target": "ES2020",
+    "target": "ES2019",
     "module": "commonjs",
     "declaration": true,
     "outDir": "lib",
@@ -22,7 +22,7 @@
     "watchDirectory": "useFsEvents",
     "fallbackPolling": "dynamicPriority"
 },
-"lib": [ "es2020" ],
+"lib": [ "es2019" ],
 "types": [
     "jest",
     "node"

examples/lambda-functions/tsconfig.json

@@ -2,7 +2,7 @@
   "compilerOptions": {
       "experimentalDecorators": true,
       "noImplicitAny": true,
-      "target": "ES2020",
+      "target": "ES2019",
       "module": "commonjs",
       "declaration": true,
       "declarationMap": true,
@@ -21,7 +21,7 @@
       "watchDirectory": "useFsEvents",
       "fallbackPolling": "dynamicPriority"
   },
-  "lib": [ "es2020" ],
+  "lib": [ "es2019" ],
   "types": [
       "node"
   ]

examples/sam/src/tsconfig.json

@@ -2,7 +2,7 @@
   "compilerOptions": {
       "experimentalDecorators": true,
       "noImplicitAny": true,
-      "target": "ES2020",
+      "target": "ES2019",
       "module": "commonjs",
       "declaration": true,
       "declarationMap": true,
@@ -21,7 +21,7 @@
       "watchDirectory": "useFsEvents",
       "fallbackPolling": "dynamicPriority"
   },
-  "lib": [ "es2020" ],
+  "lib": [ "es2019" ],
   "types": [
       "node"
   ]

examples/sam/tsconfig.json

@@ -2,7 +2,7 @@
   "compilerOptions": {
       "experimentalDecorators": true,
       "noImplicitAny": true,
-      "target": "ES2020",
+      "target": "ES2019",
       "module": "commonjs",
       "declaration": true,
       "declarationMap": true,
@@ -21,7 +21,7 @@
       "watchDirectory": "useFsEvents",
       "fallbackPolling": "dynamicPriority"
   },
-  "lib": [ "es2020" ],
+  "lib": [ "es2019" ],
   "types": [
       "node"
   ]

package-lock.json

@@ -57,6 +57,7 @@
     "@types/aws-lambda": "^8.10.72",
     "@types/jest": "^27.4.0",
     "@types/node": "^17.0.8",
+    "@types/uuid": "^8.3.4",
     "@typescript-eslint/eslint-plugin": "^5.12.1",
     "@typescript-eslint/parser": "^5.12.1",
     "archiver": "^5.3.0",
@@ -78,7 +79,8 @@
     "ts-node": "^10.0.0",
     "typedoc": "^0.22.11",
     "typedoc-plugin-missing-exports": "^0.22.6",
-    "typescript": "^4.1.3"
+    "typescript": "^4.1.3",
+    "uuid": "^8.3.2"
   },
   "files": [
     "lib/**/*"

package.json

@@ -2,7 +2,7 @@
     "compilerOptions": {
         "experimentalDecorators": true,
         "noImplicitAny": true,
-        "target": "ES2020",
+        "target": "ES2019",
         "module": "commonjs",
         "declaration": true,
         "declarationMap": true,
@@ -23,7 +23,7 @@
         "watchDirectory": "useFsEvents",
         "fallbackPolling": "dynamicPriority"
     },
-    "lib": [ "es2020" ],
+    "lib": [ "es2019" ],
     "types": [
         "jest",
         "node"

packages/commons/tsconfig-dev.json

@@ -2,7 +2,7 @@
     "compilerOptions": {
         "experimentalDecorators": true,
         "noImplicitAny": true,
-        "target": "ES2020",
+        "target": "ES2019",
         "module": "commonjs",
         "declaration": true,
         "declarationMap": true,
@@ -23,7 +23,7 @@
         "watchDirectory": "useFsEvents",
         "fallbackPolling": "dynamicPriority"
     },
-    "lib": [ "es2020" ],
+    "lib": [ "es2019" ],
     "types": [
         "jest",
         "node"