Skip to content

Commit 7d505d7

Browse files
committed
address sonarqube findings
1 parent 1893744 commit 7d505d7

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

.github/workflows/layers_partitions.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# Partitioned Layer Publish
22
# ---
3-
# This workflow publishes a specific layer version in an AWS account based on the environment input.
3+
# This workflow publishes a specific layer version in an AWS account based on the partition input.
44
#
5-
# We pull each the version of the layer and store them as artifacts, the we upload them to each of the Partitioned AWS accounts.
5+
# We pull the version of the layer and store them as artifacts, the we upload them to each of the Partitioned AWS accounts.
66
#
77
# A number of safety checks are performed to ensure safety.
88
#
@@ -12,7 +12,7 @@
1212
# 3. [Copy & Verify] deploy the layer to all regions in the target partition and validate layer deployment by comparing SHA256, description, and version numbers
1313
#
1414
# === Manual activities ===
15-
# 1. After the `make-release` workflow finishes and the PR for the documentation update gets created, trigger this workflow manually via `workflow_dispatch` with environment, version, and partition inputs for each Gamma and Prod environment in the China and GovCloud partitions
15+
# 1. After the `make-release` workflow finishes and the PR for the documentation update gets created, trigger this workflow manually via `workflow_dispatch` with partition inputs for each China and GovCloud partitions
1616
# 2. Monitor deployment progress and verify successful layer publication across all target regions
1717
# 3. Once this workflow is completed, the PR for the documentation update can me merged
1818
#

.github/workflows/layers_partitions_deploy.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,12 +79,13 @@ jobs:
7979
env:
8080
LAYER_VERSION: ${{ steps.create-layer.outputs.LAYER_VERSION }}
8181
ENVIRONMENT: ${{ inputs.environment }}
82+
PARTITION: ${{ inputs.partition }}
8283
run: |
8384
set -euo pipefail
8485
layer_output="AWSLambdaPowertoolsTypeScriptV2-${{ matrix.region }}.json"
8586
8687
aws --region "${{ matrix.region }}" lambda get-layer-version-by-arn \
87-
--arn "arn:${{ inputs.partition }}:lambda:${{ matrix.region }}:${{ secrets[format('AWS_ACCOUNT_{0}', steps.transform.outputs.CONVERTED_REGION)] }}:layer:AWSLambdaPowertoolsTypeScriptV2:${LAYER_VERSION}" \
88+
--arn "arn:${PARTITION}:lambda:${{ matrix.region }}:${{ secrets[format('AWS_ACCOUNT_{0}', steps.transform.outputs.CONVERTED_REGION)] }}:layer:AWSLambdaPowertoolsTypeScriptV2:${LAYER_VERSION}" \
8889
> "$layer_output"
8990
9091
REMOTE_SHA=$(jq -r '.Content.CodeSha256' "$layer_output")

0 commit comments

Comments
 (0)