test changes logging debug -> error (#64)

### Changes
- disable adopted resource test from canaries until its stable
- test logging debug -> error since log level is set to [INFO in PR builds](https://github.com/aws-controllers-k8s/sagemaker-controller/blob/522c147abcca72d97539f7296f000105b7b1dc26/test/e2e/service_bootstrap.py#L123)
- add missing tags assertion in feature group and increase the timeout
- tags test might be flaky changed the position. lets see if that works

### Testing
PR build

Author: surajkota

test/canary/scripts/run_test.sh

@@ -45,6 +45,7 @@ function cleanup {
   kubectl delete adoptedresources --all
   kubectl delete featuregroups --all
   kubectl delete modelpackagegroups --all
+  kubectl delete modelpackages --all
 
   print_controller_logs
 

test/e2e/common/fixtures.py

@@ -52,7 +52,7 @@ def xgboost_churn_endpoint(sagemaker_client):
     )
     assert model_resource is not None
     if k8s.get_resource_arn(model_resource) is None:
-        logging.debug(
+        logging.error(
             f"ARN for this resource is None, resource status is: {model_resource['status']}"
         )
     assert k8s.get_resource_arn(model_resource) is not None
@@ -69,7 +69,7 @@ def xgboost_churn_endpoint(sagemaker_client):
     )
     assert endpoint_config_resource is not None
     if k8s.get_resource_arn(endpoint_config_resource) is None:
-        logging.debug(
+        logging.error(
             f"ARN for this resource is None, resource status is: {endpoint_config_resource['status']}"
         )
     assert k8s.get_resource_arn(endpoint_config_resource) is not None
@@ -82,7 +82,7 @@ def xgboost_churn_endpoint(sagemaker_client):
     )
     assert endpoint_resource is not None
     if k8s.get_resource_arn(endpoint_resource) is None:
-        logging.debug(
+        logging.error(
             f"ARN for this resource is None, resource status is: {endpoint_resource['status']}"
         )
     assert k8s.get_resource_arn(endpoint_resource) is not None

test/e2e/tests/test_adopt_endpoint.py

@@ -170,7 +170,6 @@ def adopted_endpoint(sdk_endpoint):
 
 
 @service_marker
-@pytest.mark.canary
 class TestAdoptedEndpoint:
     def test_smoke(self, sdk_endpoint, adopted_endpoint):
         (

test/e2e/tests/test_endpoint.py

@@ -55,7 +55,7 @@ def single_container_model(name_suffix):
     )
     assert model_resource is not None
     if k8s.get_resource_arn(model_resource) is None:
-        logging.debug(
+        logging.error(
             f"ARN for this resource is None, resource status is: {model_resource['status']}"
         )
     assert k8s.get_resource_arn(model_resource) is not None
@@ -84,7 +84,7 @@ def multi_variant_config(name_suffix, single_container_model):
     )
     assert config_resource is not None
     if k8s.get_resource_arn(config_resource) is None:
-        logging.debug(
+        logging.error(
             f"ARN for this resource is None, resource status is: {config_resource['status']}"
         )
     assert k8s.get_resource_arn(config_resource) is not None
@@ -113,7 +113,7 @@ def single_variant_config(name_suffix, single_container_model):
     )
     assert config_resource is not None
     if k8s.get_resource_arn(config_resource) is None:
-        logging.debug(
+        logging.error(
             f"ARN for this resource is None, resource status is: {config_resource['status']}"
         )
     assert k8s.get_resource_arn(config_resource) is not None
@@ -175,7 +175,7 @@ def faulty_config(name_suffix, single_container_model):
     )
     assert model_resource is not None
     if k8s.get_resource_arn(model_resource) is None:
-        logging.debug(
+        logging.error(
             f"ARN for this resource is None, resource status is: {model_resource['status']}"
         )
     assert k8s.get_resource_arn(model_resource) is not None
@@ -195,7 +195,7 @@ def faulty_config(name_suffix, single_container_model):
     )
     assert config_resource is not None
     if k8s.get_resource_arn(config_resource) is None:
-        logging.debug(
+        logging.error(
             f"ARN for this resource is None, resource status is: {config_resource['status']}"
         )
     assert k8s.get_resource_arn(config_resource) is not None

test/e2e/tests/test_endpoint_config.py

@@ -48,7 +48,7 @@ def single_variant_config():
     )
     assert model_resource is not None
     if k8s.get_resource_arn(model_resource) is None:
-        logging.debug(
+        logging.error(
             f"ARN for this resource is None, resource status is: {model_resource['status']}"
         )
     assert k8s.get_resource_arn(model_resource) is not None

test/e2e/tests/test_feature_group.py

@@ -36,10 +36,9 @@
 SPEC_FILE = "feature_group"
 FEATURE_GROUP_STATUS_CREATING = "Creating"
 FEATURE_GROUP_STATUS_CREATED = "Created"
-WAIT_PERIOD_COUNT = 3
-# A 15 second wait period is used because we sometimes see
-# time out errors at a 10 second wait period.
-WAIT_PERIOD_LENGTH = 15
+# longer wait is used because we sometimes see server taking time to create/delete
+WAIT_PERIOD_COUNT = 4
+WAIT_PERIOD_LENGTH = 30
 STATUS = "status"
 RESOURCE_STATUS = "featureGroupStatus"
 
@@ -140,15 +139,13 @@ def test_create_feature_group(self, feature_group):
 
         feature_group_name = resource["spec"].get("featureGroupName", None)
         assert feature_group_name is not None
-        
-        feature_group_describe_response = get_sagemaker_feature_group(feature_group_name)
-        
-        assert (
-            k8s.get_resource_arn(resource)
-            == feature_group_describe_response["FeatureGroupArn"]
-        )
 
-        assert feature_group_describe_response["FeatureGroupStatus"] == FEATURE_GROUP_STATUS_CREATING
+        feature_group_sm_desc = get_sagemaker_feature_group(feature_group_name)
+        feature_group_arn = feature_group_sm_desc["FeatureGroupArn"]
+
+        assert k8s.get_resource_arn(resource) == feature_group_arn
+
+        assert feature_group_sm_desc["FeatureGroupStatus"] == FEATURE_GROUP_STATUS_CREATING
 
         assert k8s.wait_on_condition(reference, "ACK.ResourceSynced", "False")
 
@@ -158,6 +155,9 @@ def test_create_feature_group(self, feature_group):
 
         assert k8s.wait_on_condition(reference, "ACK.ResourceSynced", "True")
 
+        resource_tags = resource["spec"].get("tags", None)
+        assert_tags_in_sync(feature_group_arn, resource_tags)
+
         # Delete the k8s resource.
         _, deleted = k8s.delete_custom_resource(
             reference, WAIT_PERIOD_COUNT, WAIT_PERIOD_LENGTH

test/e2e/tests/test_hpo.py

@@ -48,7 +48,7 @@ def xgboost_hpojob():
     )
     assert resource is not None
     if k8s.get_resource_arn(resource) is None:
-        logging.debug(
+        logging.error(
             f"ARN for this resource is None, resource status is: {resource['status']}"
         )
     assert k8s.get_resource_arn(resource) is not None

test/e2e/tests/test_processingjob.py

@@ -48,7 +48,7 @@ def kmeans_processing_job():
 
     assert resource is not None
     if k8s.get_resource_arn(resource) is None:
-        logging.debug(
+        logging.error(
             f"ARN for this resource is None, resource status is: {resource['status']}"
         )
     assert k8s.get_resource_arn(resource) is not None

test/e2e/tests/test_trainingjob.py

@@ -48,7 +48,7 @@ def xgboost_training_job():
 
     assert resource is not None
     if k8s.get_resource_arn(resource) is None:
-        logging.debug(
+        logging.error(
             f"ARN for this resource is None, resource status is: {resource['status']}"
         )
     assert k8s.get_resource_arn(resource) is not None

test/e2e/tests/test_trainingjob_debugger.py

@@ -46,7 +46,7 @@ def xgboost_training_job_debugger():
         replacements=replacements,
     )
     if k8s.get_resource_arn(resource) is None:
-        logging.debug(
+        logging.error(
             f"ARN for this resource is None, resource status is: {resource['status']}"
         )
     assert resource is not None