Fix creation of buckets in regions where acceleratation not allowed (#166)

simonoff · web-flow · commit 6eade302fe22 · 2025-06-03T15:14:32.000Z
Description of changes:

There were a chnages which causes again an issues with accelerated setting for bucket.
There need to check not only empty status but also a null getAccelerateResponse. 

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
diff --git a/pkg/resource/bucket/hook.go b/pkg/resource/bucket/hook.go
@@ -323,10 +323,10 @@ func (rm *resourceManager) addPutFieldsToSpec(
 			return err
 		}
 	}
-	if getAccelerateResponse.Status != "" {
-		ko.Spec.Accelerate = rm.setResourceAccelerate(r, getAccelerateResponse)
-	} else {
+	if getAccelerateResponse == nil || getAccelerateResponse.Status == "" {
 		ko.Spec.Accelerate = nil
+	} else {
+		ko.Spec.Accelerate = rm.setResourceAccelerate(r, getAccelerateResponse)
 	}
 
 	listAnalyticsResponse, err := rm.sdkapi.ListBucketAnalyticsConfigurations(ctx, rm.newListBucketAnalyticsPayload(r))

Original file line number	Diff line number	Diff line change
`@@ -323,10 +323,10 @@ func (rm *resourceManager) addPutFieldsToSpec(`
`323`	`323`	`return err`
`324`	`324`	`}`
`325`	`325`	`}`
`326`		`- if getAccelerateResponse.Status != "" {`
`327`		`- ko.Spec.Accelerate = rm.setResourceAccelerate(r, getAccelerateResponse)`
`328`		`- } else {`
	`326`	`+ if getAccelerateResponse == nil \|\| getAccelerateResponse.Status == "" {`
`329`	`327`	`ko.Spec.Accelerate = nil`
	`328`	`+ } else {`
	`329`	`+ ko.Spec.Accelerate = rm.setResourceAccelerate(r, getAccelerateResponse)`
`330`	`330`	`}`
`331`	`331`
`332`	`332`	`listAnalyticsResponse, err := rm.sdkapi.ListBucketAnalyticsConfigurations(ctx, rm.newListBucketAnalyticsPayload(r))`