Terminal codes for Security Group (#70)

Issue #, if available: [1362](aws-controllers-k8s/community#1362)

Description of changes:

- Removed `InvalidVpcId.NotFound`, `InvalidVpcId.Malformed` and `VPCIdNotSpecified` errors from terminal codes.
- Removed integeration test for `InvalidVpcId.NotFound` terminal code.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Author: LikithaVemulapalli

apis/v1alpha1/ack-generate-metadata.yaml

@@ -1,13 +1,13 @@
 ack_generate_info:
-  build_date: "2022-08-15T17:09:48Z"
+  build_date: "2022-08-15T17:56:40Z"
   build_hash: 87477ae8ca8ac6ddb8c565bbd910cc7e30f55ed0
   go_version: go1.18.3
   version: v0.19.3
 api_directory_checksum: ff86d89efc3212fed4eb14bdc83af54601428a83
 api_version: v1alpha1
 aws_sdk_go_version: v1.42.0
 generator_config_info:
-  file_checksum: 8b8371fa96d088f1656b21e76951932d4daa48fb
+  file_checksum: ca6ca773378da313559135dd2c614353077be06f
   original_file_name: generator.yaml
 last_modification:
   reason: API generation

apis/v1alpha1/generator.yaml

@@ -381,11 +381,6 @@ resources:
           input_fields:
             GroupIds: Ids
             GroupNames: Names
-    exceptions:
-      terminal_codes:
-        - InvalidVpcID.Malformed
-        - InvalidVpcID.NotFound
-        - VPCIdNotSpecified
     hooks:
       sdk_create_post_build_request:
         template_path: hooks/security_group/sdk_create_post_build_request.go.tpl

generator.yaml

@@ -381,11 +381,6 @@ resources:
           input_fields:
             GroupIds: Ids
             GroupNames: Names
-    exceptions:
-      terminal_codes:
-        - InvalidVpcID.Malformed
-        - InvalidVpcID.NotFound
-        - VPCIdNotSpecified
     hooks:
       sdk_create_post_build_request:
         template_path: hooks/security_group/sdk_create_post_build_request.go.tpl

pkg/resource/security_group/sdk.go

@@ -79,40 +79,6 @@ def test_create_delete(self, ec2_client):
         # Check Security Group no longer exists in AWS
         ec2_validator.assert_security_group(resource_id, exists=False)
 
-    def test_terminal_condition(self):
-        test_resource_values = REPLACEMENT_VALUES.copy()
-        resource_name = random_suffix_name("security-group-fail", 24)
-
-        test_resource_values["SECURITY_GROUP_NAME"] = resource_name
-        test_resource_values["VPC_ID"] = "InvalidVpcId"
-        test_resource_values["SECURITY_GROUP_DESCRIPTION"] = "TestSecurityGroup-terminal"
-
-        # Load Security Group CR
-        resource_data = load_ec2_resource(
-            "security_group",
-            additional_replacements=test_resource_values,
-        )
-        logging.debug(resource_data)
-
-        # Create k8s resource
-        ref = k8s.CustomResourceReference(
-            CRD_GROUP, CRD_VERSION, RESOURCE_PLURAL,
-            resource_name, namespace="default",
-        )
-        k8s.create_custom_resource(ref, resource_data)
-        cr = k8s.wait_resource_consumed_by_controller(ref)
-
-        assert cr is not None
-        assert k8s.get_resource_exists(ref)
-
-        expected_msg = "InvalidVpcID.NotFound: The vpc ID 'InvalidVpcId' does not exist"
-        terminal_condition = k8s.get_resource_condition(ref, "ACK.Terminal")
-        # Example condition message:
-        #   InvalidVpcID.NotFound: The vpc ID 'InvalidVpcId' does not exist
-        #   status code: 400, request id: 5801fc80-67cf-465f-8b83-5e02d517d554
-        # This check only verifies the error message; the request hash is irrelevant and therefore can be ignored.
-        assert expected_msg in terminal_condition['message']
-
     def test_rules_create_update_delete(self, ec2_client):
         test_resource_values = REPLACEMENT_VALUES.copy()
         resource_name = random_suffix_name("sec-group-rules", 24)