Terminal Codes Nat Gateway (#61)

Issue #, if available: [1362](aws-controllers-k8s/community#1362)

Description of changes:

- Mapped terminal codes for Nat Gateway resource.
- Added integration tests for mapped terminal codes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Author: LikithaVemulapalli

apis/v1alpha1/ack-generate-metadata.yaml

@@ -1,13 +1,13 @@
 ack_generate_info:
-  build_date: "2022-07-21T17:09:05Z"
+  build_date: "2022-07-22T19:16:29Z"
   build_hash: 208b1e15257d57c46729698f47a40fd59441ecbd
   go_version: go1.18.3
   version: v0.19.2-1-g208b1e1
 api_directory_checksum: 8c35bdcab21768638dfaa277896e05fdd8a11969
 api_version: v1alpha1
 aws_sdk_go_version: v1.42.0
 generator_config_info:
-  file_checksum: 2d139419a1025deea1337589c5831061d23499bb
+  file_checksum: e6b4abcc020960d535a8a1022c087323ea2c40a6
   original_file_name: generator.yaml
 last_modification:
   reason: API generation

apis/v1alpha1/generator.yaml

@@ -263,6 +263,11 @@ resources:
     update_operation:
       custom_method_name: customUpdateInternetGateway
   NatGateway:
+    exceptions:
+      terminal_codes:
+      - InvalidSubnet
+      - InvalidElasticIpID.Malformed
+      - MissingParameter
     fields:
       AllocationId:
         references:

generator.yaml

@@ -263,6 +263,11 @@ resources:
     update_operation:
       custom_method_name: customUpdateInternetGateway
   NatGateway:
+    exceptions:
+      terminal_codes:
+      - InvalidSubnet
+      - InvalidElasticIpID.Malformed
+      - MissingParameter
     fields:
       AllocationId:
         references:

pkg/resource/nat_gateway/sdk.go

@@ -117,4 +117,113 @@ def test_create_delete(self, standard_elastic_address, ec2_client):
         time.sleep(DELETE_WAIT_AFTER_SECONDS)
 
         # Check NAT Gateway no longer exists in AWS
-        ec2_validator.assert_nat_gateway(resource_id, exists=False)
+        ec2_validator.assert_nat_gateway(resource_id, exists=False)
+
+    def test_terminal_condition_invalid_subnet(self, standard_elastic_address):
+        test_resource_values = REPLACEMENT_VALUES.copy()
+        resource_name = random_suffix_name("nat-gateway-fail-1", 24)
+        subnet_id = "InvalidSubnet"
+
+        (_, eip) = standard_elastic_address
+
+        test_resource_values["NAT_GATEWAY_NAME"] = resource_name
+        test_resource_values["SUBNET_ID"] = subnet_id
+        test_resource_values["ALLOCATION_ID"] = eip["status"]["allocationID"]
+
+        # Load NAT Gateway CR
+        resource_data = load_ec2_resource(
+            "nat_gateway",
+            additional_replacements=test_resource_values,
+        )
+        logging.debug(resource_data)
+
+        # Create k8s resource
+        ref = k8s.CustomResourceReference(
+            CRD_GROUP, CRD_VERSION, RESOURCE_PLURAL,
+            resource_name, namespace="default",
+        )
+        k8s.create_custom_resource(ref, resource_data)
+        cr = k8s.wait_resource_consumed_by_controller(ref)
+
+        assert cr is not None
+        assert k8s.get_resource_exists(ref)
+
+        expected_msg = "InvalidSubnet: The subnet ID 'InvalidSubnet' is malformed"
+        terminal_condition = k8s.get_resource_condition(ref, "ACK.Terminal")
+        # Example condition message:
+        # An error occurred (InvalidSubnet) when calling the CreateNatGateway operation:
+        # The subnet ID 'InvalidSubnet' is malformed
+        assert expected_msg in terminal_condition['message']
+
+    def test_terminal_condition_malformed_elastic_ip(self):
+        test_resource_values = REPLACEMENT_VALUES.copy()
+        resource_name = random_suffix_name("nat-gateway-fail-2", 24)
+        test_vpc = get_bootstrap_resources().SharedTestVPC
+        subnet_id = test_vpc.public_subnets.subnet_ids[0]
+
+        test_resource_values["NAT_GATEWAY_NAME"] = resource_name
+        test_resource_values["SUBNET_ID"] = subnet_id
+        test_resource_values["ALLOCATION_ID"] = "MalformedElasticIpId"
+
+        # Load NAT Gateway CR
+        resource_data = load_ec2_resource(
+            "nat_gateway",
+            additional_replacements=test_resource_values,
+        )
+        logging.debug(resource_data)
+
+        # Create k8s resource
+        ref = k8s.CustomResourceReference(
+            CRD_GROUP, CRD_VERSION, RESOURCE_PLURAL,
+            resource_name, namespace="default",
+        )
+        k8s.create_custom_resource(ref, resource_data)
+        cr = k8s.wait_resource_consumed_by_controller(ref)
+
+        assert cr is not None
+        assert k8s.get_resource_exists(ref)
+
+        expected_msg = "InvalidElasticIpID.Malformed: The elastic-ip ID 'MalformedElasticIpId' is malformed"
+        terminal_condition = k8s.get_resource_condition(ref, "ACK.Terminal")
+        # Example condition message:
+        # An error occurred (InvalidElasticIpID.Malformed) when calling the CreateNatGateway operation:
+        # The elastic-ip ID 'MalformedElasticIpId' is malformed"
+        assert expected_msg in terminal_condition['message']
+
+    def test_terminal_condition_missing_parameter(self):
+        test_resource_values = REPLACEMENT_VALUES.copy()
+        resource_name = random_suffix_name("nat-gateway-fail-3", 24)
+        test_vpc = get_bootstrap_resources().SharedTestVPC
+        subnet_id = test_vpc.public_subnets.subnet_ids[0]
+
+        test_resource_values["NAT_GATEWAY_NAME"] = resource_name
+        test_resource_values["SUBNET_ID"] = subnet_id
+
+        # ALLOCATION_ID is required for creating public nat gateways only
+        test_resource_values["ALLOCATION_ID"] = ""
+
+        # Load NAT Gateway CR
+        resource_data = load_ec2_resource(
+            "nat_gateway",
+            additional_replacements=test_resource_values,
+        )
+        logging.debug(resource_data)
+
+        # Create k8s resource
+        ref = k8s.CustomResourceReference(
+            CRD_GROUP, CRD_VERSION, RESOURCE_PLURAL,
+            resource_name, namespace="default",
+        )
+        k8s.create_custom_resource(ref, resource_data)
+        cr = k8s.wait_resource_consumed_by_controller(ref)
+
+        assert cr is not None
+        assert k8s.get_resource_exists(ref)
+
+        expected_msg = "MissingParameter: The request must include the AllocationId parameter. Add the required parameter and retry the request."
+        terminal_condition = k8s.get_resource_condition(ref, "ACK.Terminal")
+        # Example condition message:
+        # An error occurred (MissingParameter) when calling the CreateNatGateway operation:
+        # The request must include the AllocationId parameter. 
+        # Add the required parameter and retry the request.
+        assert expected_msg in terminal_condition['message']