#146 - Module code isn't constructing in topologically sorted order?

Author: rbygrave

inject-generator/src/main/java/io/avaje/inject/generator/MetaDataOrdering.java

@@ -175,7 +175,9 @@ private boolean allDependenciesWired(MetaData queuedMeta) {
         // check non-provider dependency is satisfied
         ProviderList providerList = providers.get(dependency);
         if (providerList == null) {
-          return scopeInfo.providedByOtherModule(dependency);
+          if (!scopeInfo.providedByOtherModule(dependency)) {
+            return false;
+          }
         } else {
           if (!providerList.isAllWired()) {
             return false;

inject-test/src/test/java/org/example/custom3/TcsA.java

@@ -0,0 +1,18 @@
+package org.example.custom3;
+
+import org.example.custom2.OcsOne;
+
+@MyThreeScope
+public class TcsA {
+
+  final OcsOne one;
+  final TcsRed red;
+
+  /**
+   * Other module supplied dependency is first (Issue #146)
+   */
+  public TcsA(OcsOne one, TcsRed red) {
+    this.one = one;
+    this.red = red;
+  }
+}

inject-test/src/test/java/org/example/custom3/TcsArt.java

@@ -0,0 +1,11 @@
+package org.example.custom3;
+
+@MyThreeScope
+public class TcsArt {
+
+  final TcsBart bart;
+
+  public TcsArt(TcsBart bart) {
+    this.bart = bart;
+  }
+}

inject-test/src/test/java/org/example/custom3/TcsBart.java

@@ -0,0 +1,11 @@
+package org.example.custom3;
+
+@MyThreeScope
+public class TcsBart {
+
+  final TcsCart cart;
+
+  public TcsBart(TcsCart cart) {
+    this.cart = cart;
+  }
+}

inject-test/src/test/java/org/example/custom3/TcsCart.java

@@ -0,0 +1,6 @@
+package org.example.custom3;
+
+@MyThreeScope
+public class TcsCart {
+
+}

inject-test/src/test/java/org/example/custom3/TcsRed.java

@@ -6,4 +6,10 @@
 @OciMarker
 @MyThreeScope
 public class TcsRed implements OciRock {
+
+  final TcsArt art;
+
+  public TcsRed(TcsArt art) {
+    this.art = art;
+  }
 }