Make ValidationResponse package private and final (it's not jpms exported)

Plus formating changes

Author: rob-bygrave

http-inject-plugin/src/main/java/io/avaje/http/inject/HelidonHandler.java

@@ -15,15 +15,14 @@ final class HelidonHandler implements HttpFeature {
 
   @Override
   public void setup(Builder routing) {
-
     routing.error(ValidationException.class, this::handle);
   }
 
   private void handle(ServerRequest req, ServerResponse res, ValidationException ex) {
     try (var os =
-        res.status(ex.getStatus())
-            .header("Content-Type", "application/problem+json")
-            .outputStream()) {
+           res.status(ex.getStatus())
+             .header("Content-Type", "application/problem+json")
+             .outputStream()) {
       new ValidationResponse(ex.getStatus(), ex.getErrors(), req.path().rawPath()).toJson(os);
     } catch (IOException e) {
       throw new UncheckedIOException(e);

http-inject-plugin/src/main/java/io/avaje/http/inject/HttpValidatorErrorPlugin.java

@@ -7,50 +7,49 @@
 import io.avaje.jex.Routing.HttpService;
 import io.helidon.webserver.http.HttpFeature;
 
-/** Plugin for avaje inject that provides a default Validator Handler */
+/**
+ * Plugin for avaje inject that provides a default Validator Handler
+ */
 @PluginProvides(
-    providesStrings = {
-      "io.helidon.webserver.http.HttpFeature",
-      "io.avaje.http.api.AvajeJavalinPlugin",
-      "io.avaje.jex.Routing.HttpService",
-    })
+  providesStrings = {
+    "io.helidon.webserver.http.HttpFeature",
+    "io.avaje.http.api.AvajeJavalinPlugin",
+    "io.avaje.jex.Routing.HttpService",
+  })
 public final class HttpValidatorErrorPlugin implements InjectPlugin {
 
   @Override
   public void apply(BeanScopeBuilder builder) {
-
     ModuleLayer bootLayer = ModuleLayer.boot();
 
-    bootLayer
-        .findModule("io.avaje.http.plugin")
-        .ifPresentOrElse(
-            m -> {
-              if (bootLayer.findModule("io.avaje.jex").isPresent()) {
-                builder.provideDefault(HttpService.class, JexHandler::new);
-              } else if (bootLayer.findModule("io.helidon.webserver").isPresent()) {
-                builder.provideDefault(HttpFeature.class, HelidonHandler::new);
-              } else if (bootLayer.findModule("io.javalin").isPresent()) {
-                builder.provideDefault(AvajeJavalinPlugin.class, JavalinHandler::new);
-              }
-            },
-            () -> {
-              try {
-                builder.provideDefault(HttpService.class, JexHandler::new);
-                return;
-              } catch (NoClassDefFoundError e) {
-                // not present
-              }
-              try {
-                builder.provideDefault(HttpFeature.class, HelidonHandler::new);
-                return;
-              } catch (NoClassDefFoundError e) {
-                // not present
-              }
-              try {
-                builder.provideDefault(AvajeJavalinPlugin.class, JavalinHandler::new);
-              } catch (NoClassDefFoundError e) {
-                // not present
-              }
-            });
+    bootLayer.findModule("io.avaje.http.plugin")
+      .ifPresentOrElse(m -> {
+          if (bootLayer.findModule("io.avaje.jex").isPresent()) {
+            builder.provideDefault(HttpService.class, JexHandler::new);
+          } else if (bootLayer.findModule("io.helidon.webserver").isPresent()) {
+            builder.provideDefault(HttpFeature.class, HelidonHandler::new);
+          } else if (bootLayer.findModule("io.javalin").isPresent()) {
+            builder.provideDefault(AvajeJavalinPlugin.class, JavalinHandler::new);
+          }
+        },
+        () -> {
+          try {
+            builder.provideDefault(HttpService.class, JexHandler::new);
+            return;
+          } catch (NoClassDefFoundError e) {
+            // not present
+          }
+          try {
+            builder.provideDefault(HttpFeature.class, HelidonHandler::new);
+            return;
+          } catch (NoClassDefFoundError e) {
+            // not present
+          }
+          try {
+            builder.provideDefault(AvajeJavalinPlugin.class, JavalinHandler::new);
+          } catch (NoClassDefFoundError e) {
+            // not present
+          }
+        });
   }
 }

http-inject-plugin/src/main/java/io/avaje/http/inject/JavalinHandler.java

@@ -9,6 +9,7 @@
 import io.javalin.http.Context;
 
 final class JavalinHandler extends AvajeJavalinPlugin {
+
   @Override
   public void onStart(JavalinConfig config) {
     config.router.mount(r -> r.exception(ValidationException.class, this::handler));

http-inject-plugin/src/main/java/io/avaje/http/inject/JexHandler.java

@@ -16,7 +16,6 @@ public void add(Routing arg0) {
   }
 
   private void handler(Context ctx, ValidationException ex) {
-
     try (var os =
         ctx.contentType("application/problem+json").status(ex.getStatus()).outputStream()) {
       new ValidationResponse(ex.getStatus(), ex.getErrors(), ctx.path()).toJson(os);

http-inject-plugin/src/main/java/io/avaje/http/inject/ValidationResponse.java

@@ -4,27 +4,28 @@
 import java.io.OutputStream;
 import java.io.OutputStreamWriter;
 import java.io.Writer;
+import java.nio.charset.StandardCharsets;
 import java.util.List;
 
 import io.avaje.http.api.ValidationException.Violation;
 
-public class ValidationResponse {
-  
-  private static String title = "Request Failed Validation";
-  private static String detail = "You tried to call this endpoint, but a io.avaje.http.api.ValidationException was thrown";
+final class ValidationResponse {
+
+  private static final String title = "Request Failed Validation";
+  private static final String detail = "You tried to call this endpoint, but a io.avaje.http.api.ValidationException was thrown";
   private final int status;
   private final List<Violation> errors;
   private final String instance;
 
-  public ValidationResponse(int status, List<Violation> errors, String instance) {
+  ValidationResponse(int status, List<Violation> errors, String instance) {
     this.status = status;
     this.errors = errors;
     this.instance = instance;
   }
-  
+
   // custom serialize as this is a simple class
-  public void toJson(OutputStream os) throws IOException {
-    try (Writer writer = new OutputStreamWriter(os, "UTF-8")) {
+  void toJson(OutputStream os) throws IOException {
+    try (Writer writer = new OutputStreamWriter(os, StandardCharsets.UTF_8)) {
       writeJsonInternal(writer);
     }
   }