fix: uniqueByShape util (#294)

* fix: uniqueByShape util

* test: add dupe test

Author: atomiks

src/utils.js

@@ -32,15 +32,42 @@ export function toDataAttributes(attrs) {
   return dataAttrs;
 }
 
+function deepEqual(x, y) {
+  if (x === y) {
+    return true;
+  } else if (
+    typeof x === 'object' &&
+    x != null &&
+    typeof y === 'object' &&
+    y != null
+  ) {
+    if (Object.keys(x).length !== Object.keys(y).length) {
+      return false;
+    }
+
+    for (const prop in x) {
+      if (y.hasOwnProperty(prop)) {
+        if (!deepEqual(x[prop], y[prop])) {
+          return false;
+        }
+      } else {
+        return false;
+      }
+    }
+
+    return true;
+  } else {
+    return false;
+  }
+}
+
 export function uniqueByShape(arr) {
   const output = [];
-  const lookup = Object.create(null);
 
   arr.forEach(item => {
-    if (lookup[JSON.stringify(item)] === undefined) {
+    if (!output.find(outputItem => deepEqual(item, outputItem))) {
       output.push(item);
     }
-    lookup[JSON.stringify(item)] = true;
   });
 
   return output;

test/utils.test.js

@@ -1,17 +1,23 @@
 import {uniqueByShape} from '../src/utils';
 
+const date = new Date();
+const element = document.body;
+
 describe('uniqueByShape', () => {
   it('filters duplicates', () => {
     expect(
       uniqueByShape([
         {name: 'hello'},
         {name: 'hello'},
-        {name: 'hello', enabled: false},
+        {name: 'hello', enabled: false, options: {date, element}},
+        {name: 'hello', enabled: false, options: {date, element}},
+        {name: 'hello', options: {element, x: true}},
         {name: 'hello2'},
       ]),
     ).toEqual([
       {name: 'hello'},
-      {name: 'hello', enabled: false},
+      {name: 'hello', enabled: false, options: {date, element}},
+      {name: 'hello', options: {x: true, element}},
       {name: 'hello2'},
     ]);
   });