Skip to content

Commit 93bf877

Browse files
committed
ignoring the list return vs the typical dictionary
1 parent d1db0f6 commit 93bf877

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

atlassian/jira.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3372,17 +3372,17 @@ def get_all_available_screen_fields(self, screen_id: T_id) -> T_resp_json:
33723372
url = f"{base_url}/{screen_id}/availableFields"
33733373
return self.get(url)
33743374

3375-
def get_screen_tabs(self, screen_id: T_id) -> list:
3375+
def get_screen_tabs(self, screen_id: T_id) -> Optional[list]:
33763376
"""
33773377
Get tabs for the screen id
33783378
:param screen_id:
33793379
:return:
33803380
"""
33813381
base_url = self.resource_url("screens")
33823382
url = f"{base_url}/{screen_id}/tabs"
3383-
return self.get(url)
3383+
return self.get(url) # type: ignore[return-value]
33843384

3385-
def get_screen_tab_fields(self, screen_id: T_id, tab_id: T_id) -> list:
3385+
def get_screen_tab_fields(self, screen_id: T_id, tab_id: T_id) -> Optional[list]:
33863386
"""
33873387
Get fields by the tab id and the screen id
33883388
:param tab_id:
@@ -3391,20 +3391,20 @@ def get_screen_tab_fields(self, screen_id: T_id, tab_id: T_id) -> list:
33913391
"""
33923392
base_url = self.resource_url("screens")
33933393
url = f"{base_url}/{screen_id}/tabs/{tab_id}/fields"
3394-
return self.get(url)
3394+
return self.get(url) # type: ignore[return-value]
33953395

33963396
def get_all_screen_fields(self, screen_id: T_id) -> list:
33973397
"""
33983398
Get all fields by screen id
33993399
:param screen_id:
34003400
:return:
34013401
"""
3402-
screen_tabs = self.get_screen_tabs(screen_id)
3402+
screen_tabs = self.get_screen_tabs(screen_id) or []
34033403
fields: list = []
34043404
for screen_tab in screen_tabs:
34053405
tab_id = screen_tab["id"]
34063406
if tab_id:
3407-
tab_fields = self.get_screen_tab_fields(screen_id=screen_id, tab_id=tab_id)
3407+
tab_fields = self.get_screen_tab_fields(screen_id=screen_id, tab_id=tab_id) or []
34083408
fields = fields + tab_fields
34093409
return fields
34103410

0 commit comments

Comments
 (0)