Ignore cache errors (#892)

Author: Nyholm

src/Credentials/PsrCacheProvider.php

@@ -5,7 +5,9 @@
 namespace AsyncAws\Core\Credentials;
 
 use AsyncAws\Core\Configuration;
+use Psr\Cache\CacheException;
 use Psr\Cache\CacheItemPoolInterface;
+use Psr\Log\LoggerInterface;
 
 /**
  * Cache the Credential generated by the decorated CredentialProvider with PSR-6.
@@ -20,13 +22,32 @@ final class PsrCacheProvider implements CredentialProvider
 
     private $decorated;
 
-    public function __construct(CredentialProvider $decorated, CacheItemPoolInterface $cache)
+    private $logger;
+
+    public function __construct(CredentialProvider $decorated, CacheItemPoolInterface $cache, ?LoggerInterface $logger = null)
     {
         $this->decorated = $decorated;
         $this->cache = $cache;
+        $this->logger = $logger;
     }
 
     public function getCredentials(Configuration $configuration): ?Credentials
+    {
+        try {
+            return $this->getFromCache($configuration);
+        } catch (CacheException $e) {
+            if (null !== $this->logger) {
+                $this->logger->error('Failed to get AWS credentials from cache.', ['exception' => $e]);
+            }
+
+            return $this->decorated->getCredentials($configuration);
+        }
+    }
+
+    /**
+     * @throws \Psr\Cache\CacheException
+     */
+    private function getFromCache(Configuration $configuration): ?Credentials
     {
         $item = $this->cache->getItem('AsyncAws.Credentials.' . sha1(\serialize([$configuration, \get_class($this->decorated)])));
         if (!$item->isHit()) {

src/Credentials/SymfonyCacheProvider.php

@@ -5,6 +5,8 @@
 namespace AsyncAws\Core\Credentials;
 
 use AsyncAws\Core\Configuration;
+use Psr\Cache\CacheException;
+use Psr\Log\LoggerInterface;
 use Symfony\Contracts\Cache\CacheInterface;
 use Symfony\Contracts\Cache\ItemInterface;
 
@@ -23,16 +25,20 @@ final class SymfonyCacheProvider implements CredentialProvider
 
     private $decorated;
 
-    public function __construct(CredentialProvider $decorated, CacheInterface $cache)
+    private $logger;
+
+    public function __construct(CredentialProvider $decorated, CacheInterface $cache, ?LoggerInterface $logger = null)
     {
         $this->decorated = $decorated;
         $this->cache = $cache;
+        $this->logger = $logger;
     }
 
     public function getCredentials(Configuration $configuration): ?Credentials
     {
-        return $this->cache->get('AsyncAws.Credentials.' . sha1(\serialize([$configuration, \get_class($this->decorated)])), function (ItemInterface $item) use ($configuration) {
-            $credential = $this->decorated->getCredentials($configuration);
+        $provider = $this->decorated;
+        $closure = \Closure::fromCallable(static function (ItemInterface $item) use ($configuration, $provider) {
+            $credential = $provider->getCredentials($configuration);
 
             if (null !== $credential && null !== $exp = $credential->getExpireDate()) {
                 $item->expiresAt($exp);
@@ -42,5 +48,15 @@ public function getCredentials(Configuration $configuration): ?Credentials
 
             return $credential;
         });
+
+        try {
+            return $this->cache->get('AsyncAws.Credentials.' . sha1(\serialize([$configuration, \get_class($this->decorated)])), $closure);
+        } catch (CacheException $e) {
+            if (null !== $this->logger) {
+                $this->logger->error('Failed to get AWS credentials from cache.', ['exception' => $e]);
+            }
+
+            return $provider->getCredentials($configuration);
+        }
     }
 }