Rename ParseResponse (#869)

* Rename ParseResponse

* Rename to ParseResponseException

* Updated changelog

* Rename to UnparsableResponse

* Cs fix

Author: Nyholm

CHANGELOG.md

@@ -8,7 +8,7 @@
 - Support for Elastic Container Registry (ECR) in `AwsClientFactory`
 - Read "region" from ini files.
 - Support for hard coded `roleArn` in `ConfigurationProvider`
-- Added exception `AsyncAws\Core\Exception\UnexpectedValue` and `AsyncAws\Core\Exception\ParseResponse`
+- Added exception `AsyncAws\Core\Exception\UnexpectedValue` and `AsyncAws\Core\Exception\UnparsableResponse`
 
 ### Fixed
 

src/AwsError/AwsErrorFactory.php

@@ -2,9 +2,9 @@
 
 namespace AsyncAws\Core\AwsError;
 
-use AsyncAws\Core\Exception\ParseResponse;
 use AsyncAws\Core\Exception\RuntimeException;
 use AsyncAws\Core\Exception\UnexpectedValue;
+use AsyncAws\Core\Exception\UnparsableResponse;
 use Symfony\Contracts\HttpClient\ResponseInterface;
 
 /**
@@ -42,7 +42,7 @@ static function ($errno, $errstr, $errfile, $errline) {
 
             return self::parseXml($xml);
         } catch (\Throwable $e) {
-            throw new ParseResponse('Failed to parse AWS error: ' . $content, 0, $e);
+            throw new UnparsableResponse('Failed to parse AWS error: ' . $content, 0, $e);
         }
     }
 

src/Exception/Http/HttpExceptionTrait.php

@@ -4,7 +4,7 @@
 
 use AsyncAws\Core\AwsError\AwsError;
 use AsyncAws\Core\AwsError\AwsErrorFactory;
-use AsyncAws\Core\Exception\ParseResponse;
+use AsyncAws\Core\Exception\UnparsableResponse;
 use Symfony\Contracts\HttpClient\ResponseInterface;
 
 /**
@@ -36,7 +36,7 @@ public function __construct(ResponseInterface $response)
 
         try {
             $this->awsError = AwsErrorFactory::createFromResponse($response);
-        } catch (ParseResponse $e) {
+        } catch (UnparsableResponse $e) {
             // Ignore parsing error
         }
 

src/Exception/ParseResponse.php renamed to src/Exception/UnparsableResponse.php

@@ -4,6 +4,6 @@
 
 namespace AsyncAws\Core\Exception;
 
-class ParseResponse extends \RuntimeException implements Exception
+class UnparsableResponse extends \RuntimeException implements Exception
 {
 }

src/HttpClient/AwsRetryStrategy.php

@@ -3,7 +3,7 @@
 namespace AsyncAws\Core\HttpClient;
 
 use AsyncAws\Core\AwsError\AwsErrorFactory;
-use AsyncAws\Core\Exception\ParseResponse;
+use AsyncAws\Core\Exception\UnparsableResponse;
 use Symfony\Component\HttpClient\Response\AsyncContext;
 use Symfony\Component\HttpClient\Retry\GenericRetryStrategy;
 use Symfony\Contracts\HttpClient\Exception\TransportExceptionInterface;
@@ -37,7 +37,7 @@ public function shouldRetry(AsyncContext $context, ?string $responseContent, ?Tr
 
         try {
             $error = AwsErrorFactory::createFromContent($responseContent, $context->getHeaders());
-        } catch (ParseResponse $e) {
+        } catch (UnparsableResponse $e) {
             return false;
         }