Add retry-http client (#726)

* Add retry-http client

* Add comment about double test on getChunk

* Refactore retry handling

* Reduce default timeout

* Improve logging messages

* Use symfony/httpexception in tests

* Use Symfony RetryableHttpClient

* Remove timeout

Author: jderusse

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## NOT RELEASED
 
+### Added
+
+- Use Symfony `RetryableHttpClient` when available.
+
 ### Fixed
 
 - Allow signing request with non-standard region when using custom endpoint?
@@ -72,7 +76,7 @@
 
 - Support for ECS Credentials Provider
 - Support for Cognito Identity Provider client in `AwsClientFactory`
-- Support for CloudWatch Logs client in `AwsClientFactory`
+- Support for Cloud Watch Log client in `AwsClientFactory`
 
 ### Fixed
 

src/AbstractApi.php

@@ -15,6 +15,7 @@
 use Psr\Log\LoggerInterface;
 use Psr\Log\NullLogger;
 use Symfony\Component\HttpClient\HttpClient;
+use Symfony\Component\HttpClient\RetryableHttpClient;
 use Symfony\Contracts\HttpClient\HttpClientInterface;
 
 /**
@@ -61,8 +62,14 @@ public function __construct($configuration = [], ?CredentialProvider $credential
             throw new InvalidArgument(sprintf('Second argument to "%s::__construct()" must be an array or an instance of "%s"', __CLASS__, Configuration::class));
         }
 
-        $this->httpClient = $httpClient ?? HttpClient::create();
         $this->logger = $logger ?? new NullLogger();
+        if (!isset($httpClient)) {
+            $httpClient = HttpClient::create();
+            if (\class_exists(RetryableHttpClient::class)) {
+                $httpClient = new RetryableHttpClient($httpClient, null, null, 3, $this->logger);
+            }
+        }
+        $this->httpClient = $httpClient;
         $this->configuration = $configuration;
         $this->credentialProvider = $credentialProvider ?? new CacheProvider(ChainProvider::createDefaultChain($this->httpClient, $this->logger));
     }

src/Stream/ResponseBodyStream.php

@@ -46,7 +46,9 @@ public function __toString()
     public function getChunks(): iterable
     {
         if (null !== $this->fallback) {
-            return $this->fallback->getChunks();
+            yield from $this->fallback->getChunks();
+
+            return;
         }
         if ($this->partialRead) {
             throw new LogicException(\sprintf('You can not call "%s". Another process doesn\'t reading "getChunks" till the end.', __METHOD__));