Make sure passing "null" to the configuration does not have any effect (#631)

Author: Nyholm

src/Configuration.php

@@ -103,7 +103,12 @@ public static function create(array $options)
         }
 
         $configuration = new Configuration();
-        $configuration->userData = \array_fill_keys(\array_keys($options), true);
+        $configuration->userData = [];
+        foreach ($options as $key => $value) {
+            if (null !== $value) {
+                $configuration->userData[$key] = true;
+            }
+        }
 
         foreach (self::DEFAULT_OPTIONS as $optionTrigger => $defaultValue) {
             if (isset($options[$optionTrigger])) {

tests/Unit/ConfigurationTest.php

@@ -38,6 +38,29 @@ public function testIsDefault()
         self::assertFalse($config->isDefault('region'));
     }
 
+    /**
+     * Make sure passing "null" is the same as no passing anything.
+     */
+    public function testIsDefaultWhenPassingNull()
+    {
+        $config = Configuration::create([
+            'region' => null,
+            'accessKeyId' => null,
+            'accessKeySecret' => null,
+        ]);
+
+        self::assertFalse($config->has('accessKeyId'));
+        self::assertFalse($config->has('accessKeySecret'));
+
+        self::assertTrue($config->isDefault('region'));
+        self::assertTrue($config->isDefault('accessKeyId'));
+        self::assertTrue($config->isDefault('accessKeySecret'));
+
+        self::assertEquals(Configuration::DEFAULT_REGION, $config->get('region'));
+        self::assertNull($config->get('accessKeyId'));
+        self::assertNull($config->get('accessKeySecret'));
+    }
+
     public function provideConfiguration(): iterable
     {
         yield 'simple config' => [['endpoint' => 'foo'], [], ['endpoint' => 'foo']];