fix(inventory.getall<t>()): no longer crashes when used with a custom item entry type

Was crashing due to a failed LINQ cast that sometimes silently failed.

fix #20

Author: ashblue

Assets/com.fluid.elastic-inventory/Runtime/Inventory/InventoryInstance.cs

@@ -182,9 +182,18 @@ public List<T> GetAll<T> (
             string category = null
         ) where T : IItemEntryReadOnly {
             var allEntries = new List<T>();
-            allEntries.AddRange(_uniqueEntries.Cast<T>());
-            allEntries.AddRange(_entries.Values.Cast<T>());
 
+            // Find valid entries from both unique and non-unique lists
+            foreach (var i in _uniqueEntries) {
+                if (i is T valid) allEntries.Add(valid);
+            }
+
+            foreach (var VARIABLE in _entries.Values) {
+                if (VARIABLE is T valid) allEntries.Add(valid);
+
+            }
+
+            // Include additional filters
             if (definitionType != null) {
                 allEntries = allEntries.Where(e => definitionType.IsInstanceOfType(e.Definition)).ToList();
             }

Assets/com.fluid.elastic-inventory/Tests/Editor/Scripts/InventoryInstanceTest.cs

@@ -424,42 +424,83 @@ public void It_should_trigger_a_remove_event_when_removing_a_unique_item () {
             }
         }
 
-        public class GetAll_Method : InventoryInstanceTest {
-            [Test]
-            public void It_should_return_all_added_item_entries () {
-                var definition = A.ItemDefinition().Build();
-                var inventory = Setup();
+        public class GetAll_Method {
+            public class Defaults : InventoryInstanceTest {
+                [Test]
+                public void It_should_return_all_added_item_entries () {
+                    var definition = A.ItemDefinition().Build();
+                    var inventory = Setup();
 
-                inventory.Add(definition);
-                var entries = inventory.GetAll();
+                    inventory.Add(definition);
+                    var entries = inventory.GetAll();
 
-                Assert.AreEqual(1, entries.Count);
-            }
+                    Assert.AreEqual(1, entries.Count);
+                }
 
-            [Test]
-            public void It_should_get_all_items_by_definition_type () {
-                var definition = A.ItemDefinition().Build();
-                var inventory = Setup();
+                [Test]
+                public void It_should_get_all_items_by_definition_type () {
+                    var definition = A.ItemDefinition().Build();
+                    var inventory = Setup();
 
-                inventory.Add(definition);
-                var entries = inventory.GetAll(typeof(IItemDefinition));
+                    inventory.Add(definition);
+                    var entries = inventory.GetAll(typeof(IItemDefinition));
+
+                    Assert.AreEqual(1, entries.Count);
+                }
+
+                [Test]
+                public void It_should_get_all_items_by_category () {
+                    var category = "Weapon";
+                    var definitionA = A.ItemDefinition().WithCategory(category).Build();
+                    var definitionB = A.ItemDefinition().Build();
+                    var inventory = Setup();
+
+                    inventory.Add(definitionA);
+                    inventory.Add(definitionB);
+                    var entries = inventory.GetAll(category: category);
 
-                Assert.AreEqual(1, entries.Count);
+                    Assert.AreEqual(1, entries.Count);
+                    Assert.AreEqual(definitionA, entries[0].Definition);
+                }
             }
 
-            [Test]
-            public void It_should_get_all_items_by_category () {
-                var category = "Weapon";
-                var definitionA = A.ItemDefinition().WithCategory(category).Build();
-                var definitionB = A.ItemDefinition().Build();
-                var inventory = Setup();
+            public class WithCustomData : InventoryInstanceTest {
+                public class TEST_ItemEntryCustom : ItemEntryBase {
+                }
+
+                public class TEST_ItemEntryDataResolverCustom : ItemEntryDataResolverBase<TEST_ItemEntryCustom> {
+                }
+
+                public class TEST_ItemDefinitionCustom : ItemDefinitionBase {
+                    public override string DisplayName { get; }
+                    public override string Category { get; }
+
+                    public override IItemEntryDataResolver DataResolver => new TEST_ItemEntryDataResolverCustom();
 
-                inventory.Add(definitionA);
-                inventory.Add(definitionB);
-                var entries = inventory.GetAll(category: category);
+                    public override IItemEntry CreateItemEntry (IItemDatabase database, int quantity = 1, string id = null, int? createdAt = null, int? updatedAt = null) {
+                        // We have to initialize a new implementation of the entry here
+                        // This is because the database doesn't know about our custom entry type
+                        var entry = new TEST_ItemEntryCustom();
+                        entry.Setup(database, this, quantity, id, createdAt, updatedAt);
 
-                Assert.AreEqual(1, entries.Count);
-                Assert.AreEqual(definitionA, entries[0].Definition);
+                        return entry;
+                    }
+                }
+
+                [Test]
+                public void It_should_not_fail_on_a_custom_item_entry_type () {
+                    var definitionGeneric = A.ItemDefinition().Build();
+                    var definition = ScriptableObject.CreateInstance<TEST_ItemDefinitionCustom>();
+                    var inventory = Setup();
+
+                    inventory.Add(definitionGeneric);
+                    inventory.Add(definition);
+
+                    Assert.DoesNotThrow(() => {
+                        var entries = inventory.GetAll<TEST_ItemEntryCustom>();
+                        Assert.AreEqual(1, entries.Count);
+                    });
+                }
             }
         }