Merge pull request #206 from per1234/fix-symlink-detection

Make symlink prohibition rule catch links with folder target

Author: per1234

internal/rule/rulefunction/library.go

@@ -88,7 +88,6 @@ func LibraryContainsSymlinks() (result ruleresult.Type, output string) {
 	if err != nil {
 		panic(err)
 	}
-	projectPathListing.FilterOutDirs()
 
 	symlinkPaths := []string{}
 	for _, projectPathItem := range projectPathListing {

internal/rule/rulefunction/library_test.go

@@ -105,14 +105,28 @@ func TestLibraryHasSubmodule(t *testing.T) {
 
 func TestLibraryContainsSymlinks(t *testing.T) {
 	testLibrary := "Recursive"
+	// Set up a library with a file target symlink.
 	symlinkPath := librariesTestDataPath.Join(testLibrary, "test-symlink")
 	// It's probably most friendly to developers using Windows to create the symlink needed for the test on demand.
 	err := os.Symlink(librariesTestDataPath.Join(testLibrary, "library.properties").String(), symlinkPath.String())
 	require.Nil(t, err, "This test must be run as administrator on Windows to have symlink creation privilege.")
 	defer symlinkPath.RemoveAll() // clean up
 
 	testTables := []libraryRuleFunctionTestTable{
-		{"Has symlink", testLibrary, ruleresult.Fail, ""},
+		{"Has file target symlink", testLibrary, ruleresult.Fail, ""},
+	}
+
+	checkLibraryRuleFunction(LibraryContainsSymlinks, testTables, t)
+
+	err = symlinkPath.RemoveAll()
+	require.Nil(t, err)
+
+	// Set up a library with a folder target symlink.
+	err = os.Symlink(librariesTestDataPath.Join(testLibrary, "src").String(), symlinkPath.String())
+	require.Nil(t, err)
+
+	testTables = []libraryRuleFunctionTestTable{
+		{"Has folder target symlink", testLibrary, ruleresult.Fail, ""},
 	}
 
 	checkLibraryRuleFunction(LibraryContainsSymlinks, testTables, t)