Apply review suggestion

Author: MatteoPologruto

check_for_updates.go

@@ -17,21 +17,23 @@ package main
 
 import (
 	"encoding/json"
+	"fmt"
 	"net/http"
 	"strings"
+	"time"
 
 	semver "go.bug.st/relaxed-semver"
-
-	"github.com/arduino/arduino-flasher-cli/updater"
 )
 
+const maxTime time.Duration = 1 * time.Second
+
 func checkForUpdates() (string, error) {
 	currentVersion, err := semver.Parse(Version)
 	if err != nil {
 		return "", err
 	}
 
-    client := http.Client{Timeout: maxTime}
+	client := http.Client{Timeout: maxTime}
 	resp, err := client.Get("https://api.github.com/repos/arduino/arduino-flasher-cli/releases/latest")
 	if err != nil {
 		return "", err

main.go

@@ -65,18 +65,18 @@ func main() {
 					Name:    "Arduino Flasher CLI",
 					Version: Version,
 				})
-				
-				latest, err := checkForUpdates(1 * time.Second)
+
+				latest, err := checkForUpdates()
 				if err != nil {
 					feedback.Warning(color.YellowString("Failed to check for updates: "+err.Error()) + "\n")
 				}
 				if latest != "" {
-					msg := fmt.Sprintf("%s %s → %s\n%s",
+					msg := fmt.Sprintf("\n\n%s %s → %s\n%s",
 						color.YellowString(i18n.Tr("A new release of Arduino Flasher CLI is available:")),
 						color.CyanString(Version),
 						color.CyanString(latest),
 						color.YellowString("https://www.arduino.cc/en/software/#flasher-tool"))
-					feedback.Warning(msg + "\n")
+					feedback.Warning(msg)
 				}
 			},
 		})
@@ -87,3 +87,17 @@ func main() {
 		slog.Error(err.Error())
 	}
 }
+
+type versionResult struct {
+	Name    string `json:"name"`
+	Version string `json:"version"`
+}
+
+func (r versionResult) String() string {
+	resultMessage := fmt.Sprintf("Arduino Flasher CLI version %s", r.Version)
+	return resultMessage
+}
+
+func (r versionResult) Data() interface{} {
+	return r
+}