commands: fix panic when calling NewSketch with empty directories.user

alessio-perugini · alessio-perugini · commit fc495daefb90 · 2025-03-12T08:56:30.000+01:00
We were calling directly a function that lookup for user definied
settings. In case an user did not set explictly the directory it would
return an empty string causing a panic. Instead we should have used a
dedicated function `UserDir` that uses a fallback the default
directories.user
diff --git a/commands/service_sketch_new.go b/commands/service_sketch_new.go
@@ -48,7 +48,7 @@ func (s *arduinoCoreServerImpl) NewSketch(ctx context.Context, req *rpc.NewSketc
 	if len(req.GetSketchDir()) > 0 {
 		sketchesDir = req.GetSketchDir()
 	} else {
-		sketchesDir = s.settings.GetString("directories.User")
+		sketchesDir = s.settings.UserDir().String()
 	}
 
 	if err := validateSketchName(req.GetSketchName()); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ func (s arduinoCoreServerImpl) NewSketch(ctx context.Context, req rpc.NewSketc`
`48`	`48`	`if len(req.GetSketchDir()) > 0 {`
`49`	`49`	`sketchesDir = req.GetSketchDir()`
`50`	`50`	`} else {`
`51`		`- sketchesDir = s.settings.GetString("directories.User")`
	`51`	`+ sketchesDir = s.settings.UserDir().String()`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`if err := validateSketchName(req.GetSketchName()); err != nil {`