code review fix

Author: mirkoCrobu

debian/arduino-app-cli/usr/sbin/arduino-avahi-serial.sh

@@ -1,10 +1,6 @@
 #!/bin/sh
-#
 # Configure Avahi with the serial number.
-# This operation is non-blocking: if it fails,
-# the script will exit with success in order to 
-# not to interrupt the post-install process.
-#
+
 
 TARGET_FILE="/etc/avahi/services/arduino.service"
 MARKER_LINE="</service>"
@@ -13,30 +9,29 @@ SERIAL_NUMBER_PATH="/sys/devices/soc0/serial_number"
 echo "Configuring Avahi with serial number for network discovery..."
 
 if [ ! -f "$SERIAL_NUMBER_PATH" ]; then
-    echo "Warning: Serial number path not found at $SERIAL_NUMBER_PATH. Skipping." >&2
-    exit 0 
+    echo "Error: Serial number path not found at $SERIAL_NUMBER_PATH." >&2
+    exit 1 
 fi
 
 
 if [ ! -w "$TARGET_FILE" ]; then
-    echo "Warning: Target file $TARGET_FILE not found or not writable. Skipping." >&2
-    exit 0
+    echo "Error: Target file $TARGET_FILE not found or not writable." >&2
+    exit 1
 fi
 
 SERIAL_NUMBER=$(cat "$SERIAL_NUMBER_PATH")
 
 if [ -z "$SERIAL_NUMBER" ]; then
-    echo "Warning: Serial number file is empty. Skipping." >&2
-    exit 0 
+    echo "Error: Serial number file is empty." >&2
+    exit 1 
 fi
 
 if grep -q "serial_number=${SERIAL_NUMBER}" "$TARGET_FILE"; then
     echo "Serial number ($SERIAL_NUMBER) already configured. Skipping."
     exit 0
 fi
 
-SERIAL_NUMBER_ESCAPED=$(echo "$SERIAL_NUMBER" | sed -e 's/\\/\\\\/g' -e 's/\//\\\//g' -e 's/\&/\\\&/g')
-NEW_LINE="  <txt-record>serial_number=${SERIAL_NUMBER_ESCAPED}</txt-record>"
+NEW_LINE="  <txt-record>serial_number=${SERIAL_NUMBER}</txt-record>"
 
 echo "Adding serial number to $TARGET_FILE..."