Call setScrollerFor port menu only once

facchinm · facchinm · commit 76f4668f02e1 · 2017-06-26T09:43:22.000+02:00
diff --git a/app/src/processing/app/Editor.java b/app/src/processing/app/Editor.java
@@ -761,6 +761,7 @@ public void actionPerformed(ActionEvent e) {
       portMenu = new JMenu(tr("Port"));
     populatePortMenu();
     toolsMenu.add(portMenu);
+    MenuScroller.setScrollerFor(portMenu);
     item = new JMenuItem(tr("Get Board Info"));
     item.addActionListener(e -> handleBoardInfo());
     toolsMenu.add(item);
@@ -1108,9 +1109,6 @@ public int compare(BoardPort o1, BoardPort o2) {
     }
 
     portMenu.setEnabled(portMenu.getMenuComponentCount() > 0);
-    if (portMenu.getMenuComponentCount() > 0) {
-      MenuScroller.setScrollerFor(portMenu);
-    }
   }
 
 

Original file line number	Diff line number	Diff line change
`@@ -761,6 +761,7 @@ public void actionPerformed(ActionEvent e) {`
`761`	`761`	`portMenu = new JMenu(tr("Port"));`
`762`	`762`	`populatePortMenu();`
`763`	`763`	`toolsMenu.add(portMenu);`
	`764`	`+ MenuScroller.setScrollerFor(portMenu);`
`764`	`765`	`item = new JMenuItem(tr("Get Board Info"));`
`765`	`766`	`item.addActionListener(e -> handleBoardInfo());`
`766`	`767`	`toolsMenu.add(item);`
`@@ -1108,9 +1109,6 @@ public int compare(BoardPort o1, BoardPort o2) {`
`1108`	`1109`	`}`
`1109`	`1110`
`1110`	`1111`	`portMenu.setEnabled(portMenu.getMenuComponentCount() > 0);`
`1111`		`- if (portMenu.getMenuComponentCount() > 0) {`
`1112`		`- MenuScroller.setScrollerFor(portMenu);`
`1113`		`- }`
`1114`	`1112`	`}`
`1115`	`1113`
`1116`	`1114`