Update for Go 1.24 and dependency upgrades (#713)

* Update for Go 1.24 and dependency upgrades

* Update for Go 1.24 and dependency upgrades

* Update for Go 1.24 and dependency upgrades

* Migrate to the new linter v2

* fix go.sum

* fix async test

Author: jwierzbo

.circleci/config.yml

@@ -4,7 +4,7 @@ orbs:
 executors:
   golang-executor:
     docker:
-      - image: gcr.io/gcr-for-testing/golang:1.23.12
+      - image: gcr.io/gcr-for-testing/golang:1.24.9
   machine-executor:
     machine:
       image: ubuntu-2204:current
@@ -19,7 +19,7 @@ aliases:
 parameters:
   goImage:
     type: string
-    default: "gcr.io/gcr-for-testing/golang:1.23.12"
+    default: "gcr.io/gcr-for-testing/golang:1.24.9"
   arangodbImage:
     type: string
     default: "gcr.io/gcr-for-testing/arangodb/enterprise-preview:latest"

.golangci.yaml

@@ -1,52 +1,77 @@
----
-
+version: 2
 run:
   issues-exit-code: 3
-  timeout: 30m
-  skip-dirs:
-    - vendor
-
 linters:
-  fast: false
-  enable-all: false
-  disable-all: false
-  presets:
-    - performance
-    - format
-    - complexity
-    - bugs
-    - unused
+  enable:
+    - asasalint
+    - asciicheck
+    - bidichk
+    - bodyclose
+    - durationcheck
+    - fatcontext
+    - gocheckcompilerdirectives
+    - gochecksumtype
+    - gosmopolitan
+    - loggercheck
+    - makezero
+    - nilerr
+    - nilnesserr
+    - perfsprint
+    - protogetter
+    - reassign
+    - recvcheck
+    - rowserrcheck
+    - spancheck
+    - sqlclosecheck
+#    - testifylint
+#    - zerologlint
   disable:
-    - staticcheck
-    - errcheck
-    - govet
-    - gosec
-    - ineffassign
-    - noctx
     - contextcheck
-    - unparam
-    - scopelint
-    - exhaustive
     - cyclop
-    - errorlint
+    - errcheck
     - errchkjson
-    - nestif
-    - prealloc
-    - maligned
+    - errorlint
+    - exhaustive
     - funlen
-    - typecheck
-    - deadcode
-    - unused
-    - maintidx
-    - varcheck
     - gocognit
-    - gofumpt
     - gocyclo
-    - musttag # seems to be broken
-linters-settings:
-  gci:
-    sections:
-      - standard
-      - default
-      - prefix(github.com/arangodb)
-      - prefix(github.com/arangodb/go-driver)
+    - gosec
+    - govet
+    - ineffassign
+    - maintidx
+    - musttag
+    - nestif
+    - noctx
+    - prealloc
+    - staticcheck
+    - unparam
+    - unused
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  enable:
+    - gci
+    - gofmt
+    - goimports
+  settings:
+    gci:
+      sections:
+        - standard
+        - default
+        - prefix(github.com/arangodb)
+        - prefix(github.com/arangodb/go-driver)
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

CHANGELOG.md

@@ -1,6 +1,7 @@
 # Change Log
 
 ## [master](https://github.com/arangodb/go-driver/tree/master) (N/A)
+- Switch to Go 1.24.9
 
 ## [1.6.7](https://github.com/arangodb/go-driver/tree/v1.6.7) (2025-08-31)
 - Switch to Go 1.22.12

Makefile

@@ -4,7 +4,7 @@ SCRIPTDIR := $(shell pwd)
 CURR=$(shell dirname $(realpath $(lastword $(MAKEFILE_LIST))))
 ROOTDIR:=$(CURR)
 
-GOVERSION ?= 1.23.12
+GOVERSION ?= 1.24.9
 GOTOOLCHAIN ?= auto
 GOIMAGE ?= golang:$(GOVERSION)
 GOV2IMAGE ?= $(GOIMAGE)
@@ -559,9 +559,9 @@ endif
 .PHONY: tools
 tools: __dir_setup
 	@echo ">> Fetching golangci-lint linter"
-	@GOBIN=$(TMPDIR)/bin go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.52.2
+	@GOBIN=$(TMPDIR)/bin go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.6.1
 	@echo ">> Fetching goimports"
-	@GOBIN=$(TMPDIR)/bin go install golang.org/x/tools/cmd/goimports@v0.32.0
+	@GOBIN=$(TMPDIR)/bin go install golang.org/x/tools/cmd/goimports@v0.38.0
 	@echo ">> Fetching license check"
 	@GOBIN=$(TMPDIR)/bin go install github.com/google/addlicense@v1.0.0
 	@echo ">> Fetching govulncheck"
@@ -591,6 +591,7 @@ fmt-verify: license-verify
 
 .PHONY: linter
 linter: fmt-verify
+	@echo ">> Running linter"
 	@$(TMPDIR)/bin/golangci-lint run ./...
 
 .PHONY: vulncheck

agency/agency_connection.go

@@ -1,7 +1,7 @@
 //
 // DISCLAIMER
 //
-// Copyright 2018 ArangoDB GmbH, Cologne, Germany
+// Copyright 2018-2025 ArangoDB GmbH, Cologne, Germany
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -17,13 +17,12 @@
 //
 // Copyright holder is ArangoDB GmbH, Cologne, Germany
 //
-// Author Ewout Prangsma
-//
 
 package agency
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"sync"
 	"time"
@@ -69,7 +68,7 @@ func (c *agencyConnection) NewRequest(method, path string) (driver.Request, erro
 	defer c.mutex.RUnlock()
 
 	if len(c.connections) == 0 {
-		return nil, driver.WithStack(fmt.Errorf("no connections"))
+		return nil, driver.WithStack(errors.New("no connections"))
 	}
 	r, err := c.connections[0].NewRequest(method, path)
 	if err != nil {
@@ -132,7 +131,7 @@ func (c *agencyConnection) doOnce(ctx context.Context, req driver.Request) (driv
 	c.mutex.RUnlock()
 
 	if len(c.connections) == 0 {
-		return nil, true, driver.WithStack(fmt.Errorf("no connections"))
+		return nil, true, driver.WithStack(errors.New("no connections"))
 	}
 
 	parallelRequests := true
@@ -208,7 +207,7 @@ func (c *agencyConnection) doOnce(ctx context.Context, req driver.Request) (driv
 
 func isSuccess(resp driver.Response) error {
 	if resp == nil {
-		return driver.WithStack(fmt.Errorf("Response is nil"))
+		return driver.WithStack(errors.New("Response is nil"))
 	}
 	statusCode := resp.StatusCode()
 	if statusCode >= 200 && statusCode < 300 {
@@ -235,7 +234,7 @@ func (c *agencyConnection) Unmarshal(data driver.RawObject, result interface{})
 	defer c.mutex.RUnlock()
 
 	if len(c.connections) == 0 {
-		return driver.WithStack(fmt.Errorf("no connections"))
+		return driver.WithStack(errors.New("no connections"))
 	}
 	if err := c.connections[0].Unmarshal(data, result); err != nil {
 		return driver.WithStack(err)

agency/agency_health.go

@@ -1,7 +1,7 @@
 //
 // DISCLAIMER
 //
-// Copyright 2018 ArangoDB GmbH, Cologne, Germany
+// Copyright 2018-2025 ArangoDB GmbH, Cologne, Germany
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -17,13 +17,12 @@
 //
 // Copyright holder is ArangoDB GmbH, Cologne, Germany
 //
-// Author Ewout Prangsma
-//
 
 package agency
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"net/http"
 	"net/url"
@@ -134,7 +133,7 @@ func AreAgentsHealthy(ctx context.Context, clients []driver.Connection) error {
 			// Compare leader endpoint with previous
 			prev := statuses[i-1].LeaderEndpoint
 			if !IsSameEndpoint(prev, status.LeaderEndpoint) {
-				return driver.WithStack(fmt.Errorf("Not all agents report the same leader endpoint"))
+				return driver.WithStack(errors.New("Not all agents report the same leader endpoint"))
 			}
 		}
 	}

agency/agency_impl.go

@@ -23,6 +23,7 @@ package agency
 import (
 	"context"
 	"encoding/json"
+	"errors"
 	"fmt"
 	"strings"
 	"time"
@@ -155,7 +156,7 @@ func (c *agency) WriteKey(ctx context.Context, key []string, value interface{},
 	case 1:
 		cond = condition[0]
 	default:
-		return driver.WithStack(fmt.Errorf("too many conditions"))
+		return driver.WithStack(errors.New("too many conditions"))
 	}
 
 	transaction := NewTransaction("", TransactionOptions{})
@@ -296,7 +297,7 @@ func (c *agency) RemoveKey(ctx context.Context, key []string, condition ...Write
 	case 1:
 		cond = condition[0]
 	default:
-		return driver.WithStack(fmt.Errorf("too many conditions"))
+		return driver.WithStack(errors.New("too many conditions"))
 	}
 
 	transaction := NewTransaction("", TransactionOptions{})

agency/transaction.go

@@ -1,7 +1,7 @@
 //
 // DISCLAIMER
 //
-// Copyright 2020-2023 ArangoDB GmbH, Cologne, Germany
+// Copyright 2020-2025 ArangoDB GmbH, Cologne, Germany
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@
 package agency
 
 import (
-	"fmt"
+	"errors"
 
 	"github.com/arangodb/go-driver"
 )
@@ -43,7 +43,7 @@ type Transaction struct {
 // The argument 'clientID' should be used to mark that transaction sender uniquely.
 func NewTransaction(clientID string, options TransactionOptions) Transaction {
 	if clientID == "" {
-		clientID = fmt.Sprintf("go-driver/%s", driver.DriverVersion())
+		clientID = "go-driver/" + driver.DriverVersion()
 	}
 
 	return Transaction{
@@ -60,7 +60,7 @@ func (k *Transaction) AddConditionByFullKey(fullKey string, condition KeyConditi
 
 	if _, ok := k.conditions[fullKey]; ok {
 		// For the time being one key can have only one condition. It is a limitation in agency
-		return driver.WithStack(fmt.Errorf("too many conditions"))
+		return driver.WithStack(errors.New("too many conditions"))
 	}
 
 	k.conditions[fullKey] = condition

asyncjob_impl.go

@@ -1,7 +1,7 @@
 //
 // DISCLAIMER
 //
-// Copyright 2023 ArangoDB GmbH, Cologne, Germany
+// Copyright 2023-2025 ArangoDB GmbH, Cologne, Germany
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -22,8 +22,8 @@ package driver
 
 import (
 	"context"
-	"fmt"
 	"path"
+	"strconv"
 )
 
 const asyncJobAPI = "_api/job"
@@ -45,7 +45,7 @@ func (c *clientAsyncJob) List(ctx context.Context, jobType AsyncJobStatusType, o
 	}
 
 	if opts != nil && opts.Count != 0 {
-		req.SetQuery("count", fmt.Sprintf("%d", opts.Count))
+		req.SetQuery("count", strconv.Itoa(opts.Count))
 	}
 
 	var rawResponse []byte
@@ -141,7 +141,7 @@ func (c *clientAsyncJob) Delete(ctx context.Context, deleteType AsyncJobDeleteTy
 	}
 
 	if deleteType == DeleteExpiredJobs {
-		req.SetQuery("stamp", fmt.Sprintf("%d", opts.Stamp.Unix()))
+		req.SetQuery("stamp", strconv.FormatInt(opts.Stamp.Unix(), 10))
 	}
 
 	resp, err := c.conn.Do(ctx, req)

client.go

@@ -140,7 +140,7 @@ func (v *VersionInfo) IsEnterprise() bool {
 }
 
 // String creates a string representation of the given VersionInfo.
-func (v VersionInfo) String() string {
+func (v *VersionInfo) String() string {
 	result := fmt.Sprintf("%s, version %s, license %s", v.Server, v.Version, v.License)
 	if len(v.Details) > 0 {
 		lines := make([]string, 0, len(v.Details))