[Fix] Cleanup collections with defer (#262)

Author: ajanikow

test/agency_test.go

@@ -26,19 +26,20 @@ import (
 	"context"
 	"crypto/tls"
 	"fmt"
+	"net/http"
+	"os"
+	"reflect"
+	"strings"
+	"testing"
+	"time"
+
 	driver "github.com/arangodb/go-driver"
 	"github.com/arangodb/go-driver/agency"
 	httpdriver "github.com/arangodb/go-driver/http"
 	"github.com/arangodb/go-driver/jwt"
 	"github.com/arangodb/go-driver/util"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
-	"net/http"
-	"os"
-	"reflect"
-	"strings"
-	"testing"
-	"time"
 )
 
 // getAgencyEndpoints queries the cluster to get all agency endpoints.

test/clean.go

@@ -0,0 +1,38 @@
+//
+// DISCLAIMER
+//
+// Copyright 2018 ArangoDB GmbH, Cologne, Germany
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+// Copyright holder is ArangoDB GmbH, Cologne, Germany
+//
+// Author Ewout Prangsma
+//
+
+package test
+
+import (
+	"context"
+	"testing"
+
+	"github.com/stretchr/testify/require"
+)
+
+type remove interface {
+	Remove(ctx context.Context) error
+}
+
+func clean(t *testing.T, ctx context.Context, col remove) {
+	require.NoError(t, col.Remove(ctx))
+}

test/client_test.go

@@ -397,6 +397,7 @@ func TestResponseHeader(t *testing.T) {
 		var resp driver.Response
 		db := ensureDatabase(ctx, c, "_system", nil, t)
 		col := ensureCollection(ctx, db, "response_header_test", nil, t)
+		defer clean(t, ctx, col)
 
 		// `ETag` header must contain the `_rev` of the new document in quotes.
 		doc := map[string]string{

test/cluster_test.go

@@ -133,9 +133,10 @@ func TestClusterDatabaseInventorySatellite(t *testing.T) {
 		if err != nil {
 			t.Fatalf("Failed to open _system database: %s", describe(err))
 		}
-		ensureCollection(ctx, db, name, &driver.CreateCollectionOptions{
+		col := ensureCollection(ctx, db, name, &driver.CreateCollectionOptions{
 			ReplicationFactor: driver.ReplicationFactorSatellite,
 		}, t)
+		defer clean(t, ctx, col)
 		h, err := cl.Health(ctx)
 		if err != nil {
 			t.Fatalf("Health failed: %s", describe(err))
@@ -185,11 +186,12 @@ func TestClusterDatabaseInventorySmartJoin(t *testing.T) {
 		if err != nil {
 			t.Fatalf("Failed to open _system database: %s", describe(err))
 		}
-		ensureCollection(ctx, db, name, &driver.CreateCollectionOptions{
+		col := ensureCollection(ctx, db, name, &driver.CreateCollectionOptions{
 			ShardKeys:          []string{"_key:"},
 			SmartJoinAttribute: "smart",
 			NumberOfShards:     2,
 		}, t)
+		defer clean(t, ctx, col)
 		inv, err := cl.DatabaseInventory(ctx, db)
 		if err != nil {
 			t.Fatalf("DatabaseInventory failed: %s", describe(err))
@@ -225,9 +227,10 @@ func TestClusterDatabaseInventoryShardingStrategy(t *testing.T) {
 		if err != nil {
 			t.Fatalf("Failed to open _system database: %s", describe(err))
 		}
-		ensureCollection(ctx, db, name, &driver.CreateCollectionOptions{
+		col := ensureCollection(ctx, db, name, &driver.CreateCollectionOptions{
 			ShardingStrategy: driver.ShardingStrategyCommunityCompat,
 		}, t)
+		defer clean(t, ctx, col)
 		inv, err := cl.DatabaseInventory(ctx, db)
 		if err != nil {
 			t.Fatalf("DatabaseInventory failed: %s", describe(err))
@@ -261,6 +264,7 @@ func TestClusterMoveShard(t *testing.T) {
 		col, err := db.CreateCollection(ctx, "test_move_shard", &driver.CreateCollectionOptions{
 			NumberOfShards: 12,
 		})
+		defer clean(t, ctx, col)
 		if err != nil {
 			t.Fatalf("CreateCollection failed: %s", describe(err))
 		}
@@ -361,6 +365,7 @@ func TestClusterResignLeadership(t *testing.T) {
 			NumberOfShards:    12,
 			ReplicationFactor: 2,
 		})
+		defer clean(t, ctx, col)
 		if err != nil {
 			t.Fatalf("CreateCollection failed: %s", describe(err))
 		}
@@ -448,6 +453,7 @@ func TestClusterMoveShardWithViews(t *testing.T) {
 		col, err := db.CreateCollection(ctx, "test_move_shard_with_view", &driver.CreateCollectionOptions{
 			NumberOfShards: 12,
 		})
+		clean(t, ctx, col)
 		if err != nil {
 			t.Fatalf("CreateCollection failed: %s", describe(err))
 		}
@@ -457,7 +463,9 @@ func TestClusterMoveShardWithViews(t *testing.T) {
 			},
 		}
 		viewName := "test_move_shard_view"
-		if _, err := db.CreateArangoSearchView(ctx, viewName, opts); err != nil {
+		view, err := db.CreateArangoSearchView(ctx, viewName, opts)
+		clean(t, ctx, view)
+		if err != nil {
 			t.Fatalf("Failed to create view '%s': %s", viewName, describe(err))
 		}
 		h, err := cl.Health(ctx)

test/database_collection_defaults_test.go

@@ -23,10 +23,11 @@
 package test
 
 import (
-	"github.com/dchest/uniuri"
 	"strings"
 	"testing"
 
+	"github.com/dchest/uniuri"
+
 	"github.com/arangodb/go-driver"
 	"github.com/stretchr/testify/require"
 )

test/database_test.go

@@ -25,11 +25,12 @@ package test
 import (
 	"context"
 	"fmt"
-	"github.com/dchest/uniuri"
-	"github.com/stretchr/testify/require"
 	"strings"
 	"testing"
 
+	"github.com/dchest/uniuri"
+	"github.com/stretchr/testify/require"
+
 	"github.com/arangodb/go-driver"
 )
 

test/foxx_test.go

@@ -23,11 +23,12 @@ package test
 
 import (
 	"context"
-	"github.com/arangodb/go-driver"
-	"github.com/stretchr/testify/require"
 	"os"
 	"testing"
 	"time"
+
+	"github.com/arangodb/go-driver"
+	"github.com/stretchr/testify/require"
 )
 
 func TestFoxxItzpapalotlService(t *testing.T) {

test/graph_creation_test.go

@@ -24,10 +24,11 @@ package test
 
 import (
 	"context"
-	"github.com/arangodb/go-driver"
-	"github.com/stretchr/testify/require"
 	"testing"
 	"time"
+
+	"github.com/arangodb/go-driver"
+	"github.com/stretchr/testify/require"
 )
 
 func newGraphOpts(db driver.Database) (driver.CreateGraphOptions, []string) {

test/revisions_test.go

@@ -4,11 +4,12 @@ import (
 	"context"
 	"encoding/json"
 	"fmt"
-	"github.com/arangodb/go-driver"
-	"github.com/stretchr/testify/require"
 	"net/http"
 	"testing"
 	"time"
+
+	"github.com/arangodb/go-driver"
+	"github.com/stretchr/testify/require"
 )
 
 func TestRevisionTree(t *testing.T) {

test/server_mode_auth_test.go

@@ -62,6 +62,7 @@ func TestServerModeAndGrants(t *testing.T) {
 		db := ensureDatabase(ctx, c, "_system", nil, t)
 		colName := "server_mode_and_grants_test1"
 		col := ensureCollection(ctx, db, colName, nil, t)
+		clean(t, ctx, col)
 
 		// Get database & collection access
 		defaultDBAccess, err := u.GetDatabaseAccess(ctx, db)