Couple of minor improvements

Author: aplteam

APLSource/GitHubAPIv3.aplc

@@ -16,17 +16,17 @@
 
     ∇ r←Version
       :Access Public Shared
-      r←'GitHub' '0.3.0.8' '2019-02-17'
+      r←'GitHub' '0.3.0.11' '2019-04-16'
     ∇
 
     ∇ History
       :Access Public Shared
     ⍝ * 0.3.0
-    ⍝   * Oktokit support added.
     ⍝   * Versioning corrected.
     ⍝   * Documentation polished.
     ⍝   * :Include ##.APLTreeUtils fixed
-    ⍝   * Now compatible with 1.50
+    ⍝   * Bug fixes
+    ⍝     * `CastTagname2Number` did not accept something like `1.0.2`
     ⍝ * 0.0.2
     ⍝   * Method `GetAllTopics` added.
     ⍝ * 0.0.1
@@ -158,6 +158,8 @@
     ⍝ Assumptions:
     ⍝ * `text` may or may not start with a non-digit. All leading non-digit characters are ignored.\\
     ⍝   Therefore both `1.2.3` and `v.1.2.3` are valid input.
+    ⍝ * None is allowed to start with a zero followd by a non-zero digit. Therefore 1.0.0 is valid input but
+    ⍝   01.02.3, 1.02.3 and 1.2.03 are not.
     ⍝ * The remaining `text` must consist of nothing but digits and dots.
     ⍝ * The first two numbers ("major" and "minor") must not be bigger than 99.
     ⍝ * The third number ("path") must not be bigger than 999.
@@ -171,24 +173,23 @@
     ⍝ If the tag name does not fulfil the assumptions the conversion might crash. In that case `⍬` is
     ⍝ returned as result.
       number←⍬
-      text←{⍵↓⍨+/∧\0=⍵∊⎕D}text
-      :If 0=+/{+/∧\'0'=⍵}¨'.'Split text
+      :If 0<≢text←{⍵↓⍨+/∧\0=⍵∊⎕D}text
+      :AndIf 0=+/{(1<⊃≢⍵)∧⊃'0'=1↑⍵}¨'.'Split text
           (bool vec)←'.'⎕VFI text
-          :If 3 4∊⍨⍴bool
-              vec←{⍵↑⍨3⌈4⌊⍴⍵}↑vec
-              :If 3=⍴vec
-                  :If ∧/100 100 1000>vec
-                  :AndIf 0=number←100 100 1000⊥vec
-                      number←⍬
-                  :EndIf
-              :Else
-                  :If ~∧/100 100 1000 100000>vec
-                      number←⍬
-                  :ElseIf 0=number←100 100 1000 100000⊥vec
-                      number←⍬
-                  :EndIf
-                  number÷←100000
+      :AndIf 3 4∊⍨⍴bool
+          vec←{⍵↑⍨3⌈4⌊⍴⍵}↑vec
+          :If 3=⍴vec
+              :If ∧/100 100 1000>vec
+              :AndIf 0=number←100 100 1000⊥vec
+                  number←⍬
+              :EndIf
+          :Else
+              :If ~∧/100 100 1000 100000>vec
+                  number←⍬
+              :ElseIf 0=number←100 100 1000 100000⊥vec
+                  number←⍬
               :EndIf
+              number÷←100000
           :EndIf
       :EndIf
     ∇
@@ -318,7 +319,7 @@
               ∘∘∘           ⍝ Huuh?!
           :EndIf
       :Else
-          r←⍎'type ⎕JSON filename'
+          r←⍎'type ⎕JSON y'
       :EndIf
     ∇
 

APLSource/TestCases/Test_006.aplf

@@ -10,7 +10,11 @@
  →PassesIf 102003.00001=##.GitHubAPIv3.CastTagname2Number'1.2.3.1'
  →PassesIf 102003.09999=##.GitHubAPIv3.CastTagname2Number'1.2.3.9999'
 
- →PassesIf 102003=##.GitHubAPIv3.CastTagname2Number'v1.2.3'
+ →PassesIf 1000=##.GitHubAPIv3.CastTagname2Number'v0.1.0'
+ →PassesIf 100000=##.GitHubAPIv3.CastTagname2Number'v1.0.0'
+ →PassesIf 100000≡##.GitHubAPIv3.CastTagname2Number'1.0.0'
+ →PassesIf 100000≡##.GitHubAPIv3.CastTagname2Number'1.0.0.0'
+ →PassesIf 102000=##.GitHubAPIv3.CastTagname2Number'v1.2.0'
  →PassesIf 1002003=##.GitHubAPIv3.CastTagname2Number'v10.2.3'
  →PassesIf 1020003=##.GitHubAPIv3.CastTagname2Number'v10.20.3'
  →PassesIf 1020030=##.GitHubAPIv3.CastTagname2Number'v10.20.30'

Dist/GitHubAPIv3-0.3..11.zip

@@ -1,2 +1,2 @@
-"C:\Program Files\Dyalog\Dyalog APL-64 16.0 Unicode\dyalog.exe" %1 maxw=64000 %2 %3 %4
+"C:\Program Files\Dyalog\Dyalog APL-64 15.0 Unicode\dyalog.exe" %1 maxw=64000 %2 %3 %4
 IF %ERRORLEVEL% NEQ 0 echo ERROR

Dist/GitHubAPIv3.zip

@@ -1 +1 @@
-<tool name="GitHubAPIv3">  <version>0.3.0</version>  <date>2019-02-17</date>  <files></files>  <container>#._GitHubAPIv3</container>  <needs>    <script>APLTreeUtils</script>    <script>FilesAndDirs</script>    <script>OS</script>    <script>Tester</script>  </needs>  <scriptOnly>1</scriptOnly>  <wsid>Development</wsid>  <autoload>1</autoload>  <buildid>9</buildid></tool>
+<tool name="GitHubAPIv3">  <version>0.3.0</version>  <date>2019-04-16</date>  <files></files>  <container>#._GitHubAPIv3</container>  <needs>    <script>APLTreeUtils</script>    <script>FilesAndDirs</script>    <script>OS</script>    <script>Tester</script>  </needs>  <scriptOnly>1</scriptOnly>  <wsid>Development</wsid>  <autoload>1</autoload>  <buildid>11</buildid></tool>