Is Tatin package now

Author: aplteam

.gitignore

@@ -1,2 +1,5 @@
 .acre/
 aplcore
+Dist/
+change_history/
+.gitignore

APLSource/GitHubAPIv3.aplc

@@ -12,17 +12,18 @@
 ⍝ It is part of the [APLTree library](https://github.com/aplteam/apltree/wiki)
 ⍝ Kai Jaeger ⋄ APL Team Ltd
 
-    :Include APLTreeUtils
-
     ⎕IO←1 ⋄ ⎕ML←1
 
     ∇ r←Version
       :Access Public Shared
-      r←'GitHub' '0.6.0.18' '2020-03-23'
+      r←'GitHub' '0.7.0+22' '2020-03-17'
     ∇
 
     ∇ History
       :Access Public Shared
+    ⍝ * 0.7.0
+    ⍝   * Is a Tatin package now and therefore requires 18.0 Unicode or better
+    ⍝   * Does not :Include APLTreeUtils anymore (but does depend on APLTreeUtils2 being a sibling)
     ⍝ * 0.6.0
     ⍝   * File extension is now .aplc rather than .dyalog
     ⍝ * 0.5.0
@@ -79,6 +80,7 @@
       :Implements Constructor
       _owner←owner
       _regEx←'setup_<repoName>_<version>[.\]*.[0-9]{0,6}\.exe'  ⍝ After version there _might_ be a built number
+      A←(⊃⊃⎕CLASS ⎕THIS).##.APLTreeUtils2
     ∇
 
     ∇ (rc msg ns)←GetLatestReleaseInfo repoName;gitPath
@@ -213,7 +215,7 @@
       :EndIf
     ∇
 
-    ∇ (rc msg endpoints)←GetAllEndpoints;gitPath;msg;rc
+    ∇ (rc msg endpoints)←GetAllEndpoints;gitPath;msg;rc;A
       :Access Public Shared
     ⍝ This method returns all REST endpoints offered by the API.\\
     ⍝ It returns a namespace. Use the built-in `List` function for an overview.
@@ -224,6 +226,7 @@
     ⍝ : Is empty in case `rc ←→ 0` but might offer addtional information otherwise.
     ⍝ `ns`
     ⍝ : Namespace with the data received from GitHub.
+      A←##.APLTreeUtils2
       gitPath←'https://api.github.com/'
       endpoints←⎕NS''
       (rc msg endpoints)←GetJson gitPath
@@ -269,9 +272,14 @@
     ⍝ + 1.20.333 transforms into 120333
     ⍝ + 12.12.123.12345 transforms into 1212123.12345\\
       number←⍬
+      ⍝ This function might be called from a Shared method. when we need to address APLTreeUtils2 explicitly,
+      ⍝ or from a n Instance method, when `A` is a ref pointing to APLTreeUtils2.
+      :If 0<##.⎕NC'APLTreeUtils2'
+          A←##.APLTreeUtils2
+      :EndIf
       :If 0<≢text←{⍵↓⍨+/∧\0=⍵∊⎕D}text
           text,←⊃,/(0⌈2-text+.='.')⍴⊂'.0'
-      :AndIf 0=+/{(1<⊃≢⍵)∧⊃'0'=1↑⍵}¨'.'Split text
+      :AndIf 0=+/{(1<⊃≢⍵)∧⊃'0'=1↑⍵}¨'.'A.Split text
           (bool vec)←'.'⎕VFI text
       :AndIf 3 4∊⍨⍴bool
           vec←{⍵↑⍨3⌈4⌊⍴⍵}↑vec
@@ -307,7 +315,7 @@
       :If 0=⎕NC'regEx'
           regEx←_regEx
       :EndIf
-      type←Uppercase type
+      type←1 ⎕C type
       'Invalid right argument ("type")'⎕SIGNAL 11/⍨~(⊂type)∊'EXE' 'ZIP' 'TAR'
       :If 0=⎕NC'tag'
           (rc more info)←GetLatestReleaseInfo repoName
@@ -331,7 +339,7 @@
               regEx←'/',_owner,'/',repoName,'/releases/download/v',tag,'/',regEx
               :If 1=≢buff←regEx ⎕S 2 0 1⍠('Greedy' 0)('IC' 1)⊣html
                   (itemNo offset length)←⊃buff
-                  url←'https://github.com/',1↓(1+length)↑(offset-1)↓(itemNo+1)⊃(⎕UCS 10)Split html
+                  url←'https://github.com/',1↓(1+length)↑(offset-1)↓(itemNo+1)⊃(⎕UCS 10)A.Split html
               :EndIf
           :EndIf
       :EndIf
@@ -342,8 +350,13 @@
     ⍝ Note that drafted release and pre-release are both ignored.
       :Access Public Instance
       (rc more ns)←GetLatestReleaseInfo repoName
-      :If ∨/'Error'⍷∊more
-          'Error accessin GitHub via the REST API'⎕SIGNAL 11
+      :If 0≠rc
+      :OrIf ∨/'Error'⍷∊more
+          :If 0=≢more
+              'Error accessing GitHub via the REST API'⎕SIGNAL 11
+          :Else
+              more ⎕SIGNAL 11
+          :EndIf
       :Else
           tag←ns.tag_name
       :EndIf
@@ -418,10 +431,10 @@
       GetNoOfPages←{
    ⍝ Takes HTTP headers and returns the number of pages. If there are not any a zero is returned.
           headers←⍵
-          bool←'Link:'{⍺∘≡¨(⍴⍺)↑¨⍵}headers
+          bool←'link:'{⍺∘≡¨(⍴⍺)↑¨⍵}⎕C headers
           0=+/bool:0
           link←(bool⍳1)⊃headers
-          buff←' 'Split link
+          buff←' 'A.Split link
           last←(¯1+⍴buff)⊃buff
           buff←{⍵{(⍴'?page-')↓⍵[2]↑⍵[1]↓⍺}⊃'(&|\?)page=[0-9]{1,}'⎕S 0 1⊣⍵}last
           ⊃⊃(//)⎕VFI buff
@@ -430,16 +443,16 @@
       GetLinkToNextPage←{
    ⍝ Takes HTTP headers and returns the link pointing to the next page, if any
           headers←⍵
-          bool←'Link:'{⍺∘≡¨(⍴⍺)↑¨⍵}headers
+          bool←'link:'{⍺∘≡¨(⍴⍺)↑¨⍵}⎕C headers
           0=+/bool:0
           link←(bool⍳1)⊃headers
-          buff←' 'Split link
+          buff←' 'A.Split link
           1↓¯2↓⊃1↓buff
       }
 
       SplitHeaders←{
           headers←⍵↑⍨1⍳⍨(⎕UCS 10 13)⍷⍵
-          (⎕UCS 13 10)Split headers
+          A.Split headers
       }
 
     ∇ txt←GetText obj;ts
@@ -451,19 +464,16 @@
     ⍝ Takes `gitURL`which must specify a valid GitHub API URL and returns the data from GitHub.\\
     ⍝ `⍵`: Project URL, for example 'api.github.com/repos/aplteam/testrepo/releases/latest'
     ⍝ `⍺`: Optional parameter space, typically create by calling `CreateHttpParms`.
-    ⍝ `rc`
-    ⍝ : Either 0 for okay or an error code.\\
-    ⍝ `msg`
-    ⍝ : Is empty in case `rc←→0` but might offer addtional information otherwise.
-    ⍝ `ns`
-    ⍝ : Namespace with the data received from GitHub.
+    ⍝ | `rc`  | Either 0 for okay or an error code.
+    ⍝ | `msg` | Is empty in case `rc←→0` but might offer addtional information otherwise.
+    ⍝ | `ns`  | Namespace with the data received from GitHub.
       parms←{0<⎕NC ⍵:⍎⍵ ⋄ CreateHttpParms}'parms'
       :If 0=⎕NC'_owner'
           owner←'APL GitHub API'
       :Else
           owner←_owner
       :EndIf
-      gitURL←'https://'{⍵,⍨⍺/⍨⍺≢(⍴⍺)↑⍵}Lowercase gitURL
+      gitURL←'https://'{⍵,⍨⍺/⍨⍺≢(⍴⍺)↑⍵}⎕C gitURL
       rc←0
       msg←''
       ns←⎕NS''
@@ -517,7 +527,7 @@
           :If 0=type        ⍝ Import?
               r←7159⌶y
           :ElseIf 1=type    ⍝ Export!
-              ∘∘∘ ⍝ Not implemented yet (because not required)
+              ∘∘∘           ⍝ Not implemented yet (because never required)
               7160⌶
           :Else
               ∘∘∘           ⍝ Huuh?!

APLSource/Initialize.aplf

@@ -0,0 +1,10 @@
+ {r}←Initialize;⎕TRAP;parent
+ ⎕TRAP←0 'S'
+ r←⍬
+ {}⎕SE.UCMD'cd ',AcreConfig.ProjectFolder
+ ⎕WSID←AcreConfig.ProjectFolder,'project.dws'
+ parent←⍕⎕THIS
+ {}⎕SE.Tatin.LoadDependencies'./packages/'parent
+ parent,←'.TestCases'
+ {}⎕SE.Tatin.LoadDependencies'./packages_dev/'parent
+⍝Done

APLSource/TestCases/Prepare.aplf

@@ -1,2 +1,18 @@
- Prepare
- T←⎕NEW ##.Tester2 ⎕THIS
+ Prepare;testPath;testFilename;ask;answer
+ ⎕IO←1 ⋄ ⎕ML←1
+ T←⎕NEW Tester2 ⎕THIS
+ testPath←(⊃1 ⎕NPARTS''),'TestResults'
+ testFilename←testPath,'/CodeCoverage'
+ :If ⎕NEXISTS testPath
+     :If ⎕NEXISTS testFilename,'.dcf'
+         ask←{⎕←⍵,'; 1=append, 2=replace' ⋄ a←⎕ ⋄ ~(⊂a)∊1 2:∇ ⍵ ⋄ ⊃a}
+         answer←⊃ask'Coverage file already exists'
+         :If 2≡answer
+             1 ⎕NDELETE testFilename,'.dcf'
+         :EndIf
+     :EndIf
+ :EndIf
+ 3 ⎕MKDIR testPath  ⍝
+ T.codeCoverage←⎕NEW CodeCoverage(,⊂'#.',{⍵,'.',⍵}2↓⍕⎕THIS.##)
+ T.codeCoverage.filename←testFilename
+⍝Done

APLSource/TestCases/RunTests.aplf

@@ -0,0 +1,8 @@
+ RunTests;htmlFilename
+ Prepare
+ T.Run 1
+ htmlFilename←CodeCoverage.ProcessDataAndCreateReport T.codeCoverage.filename
+ :If 1 ∆YesOrNo'View CodeCoverage report?'
+     APLTreeUtils2.GoToWebPage'file://',htmlFilename
+ :EndIf
+⍝Done

APLSource/TestCases/Test_GetRelease_003.aplf

@@ -3,7 +3,7 @@
  ⎕TRAP←(999 'C' '. ⍝ Deliberate error')(0 'N')
  R←T._Failed
 
- url←∆MyGitHubAPI.GetRelease'APLTreeUtils' 'EXE'              ⍝ Becauss this test project has no EXE!
+ url←∆MyGitHubAPI.GetRelease'APLTreeUtils2' 'EXE'             ⍝ Becauss this test project has no EXE!
  →T.PassesIf 0=≢url
  url←∆MyGitHubAPI.GetRelease'TestRepo' 'EXE'                  ⍝ This one has an EXE!
  →T.PassesIf'https://'{⍺≡(≢⍺)↑⍵}url

APLSource/TestCases/Test_Misc_001.aplf

@@ -6,7 +6,7 @@
  (rc more data)←∆MyGitHubAPI.GetAllRepos
  →T.PassesIf 0=rc
  →T.PassesIf 0=≢more
- →T.PassesIf 30<≢data  ⍝ Important: GitHub pages requests to a max of 30 items per page,
+ →T.PassesIf 30<≢data  ⍝ Important: GitHub returns by default a maximum of 30 items per page; there are more repositories, and all should be delivered
 
  R←T._OK
 ⍝Done

APLSource/TestCases/Test_Misc_030.aplf

@@ -5,7 +5,7 @@
 
  (rc more data)←∆MyGitHubAPI.GetAllTopics'TestRepo'
  →T.PassesIf 0=rc
- →T.PassesIf 0=≢more
+ →T.PassesIf 0=≢more   ⍝ You will possibly get a 403 if the test cases are executed too often (GitHub does allow only so many requests without authentication)
  →T.PassesIf 0<≢data
 
  :If 0

APLSource/TestCases/Test_ZZZ_998.aplf

@@ -1,23 +1,22 @@
- R←Test_ZZZ_998(stopFlag batchFlag);⎕IO;⎕ML;⎕TRAP;report;buff;xml;source
+ R←Test_ZZZ_998(stopFlag batchFlag);⎕IO;⎕ML;⎕TRAP;report;buff;rf
 ⍝ Checks on two text vectors: "⍝TODO⍝" and "⍝CHECK⍝"; never fails, just reports.
- ⎕IO←0 ⋄ ⎕ML←3
+ ⎕IO←1 ⋄ ⎕ML←1
  ⎕TRAP←(999 'C' '. ⍝ Deliberate error')(0 'N')
  R←T._OK
  report←''
+ rf←##.GitHubAPIv3
 
- xml←⎕XML'flat'##.APLTreeUtils.ReadUtf8File'publish.config'
- source←2⊃xml[xml[;1]⍳⊂'container';]
- buff←T.FindSpecialString'⍝CHECK⍝'
- buff←(buff[;0]≢¨⎕XSI[0])⌿buff ⍝ remove caller
- :If ~0∊⍴buff
+ buff←rf T.FindSpecialString'⍝CHECK⍝'
+ buff←(buff[;1]≢¨⎕XSI[1])⌿buff ⍝ remove caller
+ :If 0≠≢buff
      report,←↓(⊂' ⍝CHECK⍝ found:'),(⊂'   '),¨buff
  :EndIf
- buff←T.FindSpecialString'⍝TODO⍝'
- buff←(buff[;0]≢¨⎕XSI[0])⌿buff ⍝ remove caller
- :If ~0∊⍴buff
+ buff←rf T.FindSpecialString'⍝TODO⍝'
+ buff←(buff[;1]≢¨⎕XSI[1])⌿buff ⍝ remove caller
+ :If 0≠≢buff
      report,←↓(⊂' ⍝TODO⍝ found:'),(⊂'   '),¨buff
  :EndIf
- :If 1=⍴,report
+ :If 1=≢report
      report,←⊂'    Nothing found!'
  :Else
      ⎕←'Checking for ⍝TODO⍝ and ⍝CHECK⍝ '{⍵↑,'--- ',⍺,' ',⍵⍴'-'}80⌊⎕PW-1