Fix symfony 4.4 compat (#3285)

* rename for clarity

* correctly detect if we can use the new ErrorListener in symfony 4.4

The ErrorListener may be remvoved from the container if deprecated configuration is used.
We must use the deprecated Exception listener if so.
https://github.com/symfony/symfony/blob/bfae515d521a421b413cb39e8fae727ffb4ca28b/src/Symfony/Bundle/TwigBundle/DependencyInjection/Compiler/ExceptionListenerPass.php#L37

Author: bendavies

src/Bridge/Symfony/Bundle/Resources/config/api.xml

@@ -214,6 +214,8 @@
         <service id="api_platform.listener.exception" class="ApiPlatform\Core\EventListener\ExceptionListener">
             <argument>api_platform.action.exception</argument>
             <argument type="service" id="logger" on-invalid="null" />
+            <argument>false</argument>
+            <argument type="service" id="exception_listener" on-invalid="null" />
 
             <tag name="kernel.event_listener" event="kernel.exception" method="onKernelException" priority="-96" />
             <tag name="monolog.logger" channel="request" />

src/EventListener/ExceptionListener.php

@@ -17,7 +17,7 @@
 use Psr\Log\LoggerInterface;
 use Symfony\Component\HttpKernel\Event\ExceptionEvent;
 use Symfony\Component\HttpKernel\EventListener\ErrorListener;
-use Symfony\Component\HttpKernel\EventListener\ExceptionListener as BaseExceptionListener;
+use Symfony\Component\HttpKernel\EventListener\ExceptionListener as LegacyExceptionListener;
 
 /**
  * Handles requests errors.
@@ -29,12 +29,12 @@ final class ExceptionListener
 {
     private $exceptionListener;
 
-    public function __construct($controller, LoggerInterface $logger = null, $debug = false)
+    public function __construct($controller, LoggerInterface $logger = null, $debug = false, ErrorListener $errorListener = null)
     {
-        if (class_exists(ErrorListener::class)) {
+        if (null !== $errorListener) {
             $this->exceptionListener = new ErrorListener($controller, $logger, $debug);
         } else {
-            $this->exceptionListener = new BaseExceptionListener($controller, $logger, $debug);
+            $this->exceptionListener = new LegacyExceptionListener($controller, $logger, $debug);
         }
     }
 

tests/EventListener/ExceptionListenerTest.php

@@ -19,6 +19,7 @@
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpKernel\Event\ExceptionEvent;
+use Symfony\Component\HttpKernel\EventListener\ErrorListener;
 use Symfony\Component\HttpKernel\HttpKernelInterface;
 
 /**
@@ -44,7 +45,7 @@ public function testOnKernelException(Request $request)
         $eventProphecy->getKernel()->willReturn($kernel);
         $eventProphecy->setResponse(Argument::type(Response::class))->shouldBeCalled();
 
-        $listener = new ExceptionListener('foo:bar');
+        $listener = new ExceptionListener('foo:bar', null, false, class_exists(ErrorListener::class) ? $this->prophesize(ErrorListener::class)->reveal() : null);
         $listener->onKernelException($eventProphecy->reveal());
     }
 
@@ -62,7 +63,7 @@ public function testDoNothingWhenNotAnApiCall()
         $eventProphecy->getRequest()->willReturn(new Request());
         $eventProphecy->setResponse(Argument::type(Response::class))->shouldNotBeCalled();
 
-        $listener = new ExceptionListener('foo:bar');
+        $listener = new ExceptionListener('foo:bar', null, false, class_exists(ErrorListener::class) ? $this->prophesize(ErrorListener::class)->reveal() : null);
         $listener->onKernelException($eventProphecy->reveal());
     }
 
@@ -75,7 +76,7 @@ public function testDoNothingWhenHtmlRequested()
         $eventProphecy->getRequest()->willReturn($request);
         $eventProphecy->setResponse(Argument::type(Response::class))->shouldNotBeCalled();
 
-        $listener = new ExceptionListener('foo:bar');
+        $listener = new ExceptionListener('foo:bar', null, false, class_exists(ErrorListener::class) ? $this->prophesize(ErrorListener::class)->reveal() : null);
         $listener->onKernelException($eventProphecy->reveal());
     }
 }