chore(zeppelin-web-angular): remediate npm audit findings in zeppelin-react#5257
Open
jongyoul wants to merge 1 commit into
Open
chore(zeppelin-web-angular): remediate npm audit findings in zeppelin-react#5257jongyoul wants to merge 1 commit into
jongyoul wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the zeppelin-react frontend audit flow to remediate current npm audit failures while allowing known @antv malware false-positive advisories to be filtered.
Changes:
- Upgrades
webpack-dev-serverto5.2.4. - Adds
audit-filter.jsto run and filter npm audit JSON output. - Updates the frontend CI workflow to use the custom audit filter.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
zeppelin-web-angular/projects/zeppelin-react/package.json |
Updates the webpack-dev-server dev dependency range. |
zeppelin-web-angular/projects/zeppelin-react/package-lock.json |
Locks webpack-dev-server to 5.2.4. |
zeppelin-web-angular/projects/zeppelin-react/audit-filter.js |
Adds custom npm audit filtering for selected advisories. |
.github/workflows/frontend.yml |
Runs the new audit filter in the zeppelin-react audit job. |
Files not reviewed (1)
- zeppelin-web-angular/projects/zeppelin-react/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
….js to fix npm audit
db5a970 to
fd888bf
Compare
Member
Author
|
@tbonelee @ParkGyeongTae @voidmatcha I heard that @AntV had a security issue, so it's been fully deprecated. So npm-audit failed, so I removed them and used the vanilla one. Could you please check it? |
voidmatcha
reviewed
May 24, 2026
Contributor
There was a problem hiding this comment.
- npm audit on master: 21 advisories (10 moderate / 5 high / 6 critical, incl. the @antv/adjust & @antv/color-util malware advisories)
- Diff review: no new dangerouslySetInnerHTML / eval / dynamic Function introduced, and chart labels/data are drawn on a 2D canvas context. So the migration doesn't add any XSS surface.
LGTM from a supply-chain perspective.
| labels: data.map(d => d.category), | ||
| datasets: [{ | ||
| label: 'Value', | ||
| data: data.map(d => data.value), |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What is this PR for?
This PR remediates
npm auditfailures in thezeppelin-reactmodule (zeppelin-web-angular/projects/zeppelin-react) onmaster.What changes are proposed?
webpack-dev-server: Updatedwebpack-dev-serverto^5.2.4inpackage.jsonto resolve the moderateuuidandwebpack-dev-servervulnerabilities.audit-filter.js: Created a custom audit filtering script to handle the@antv/color-utiland@antv/adjustmalware false-positives (GHSA-rh6v-hwr4-6jcp / GHSA-qcp2-qp9h-qprg). Npm marked all versions of these packages as malware, causing all audit runs to fail even though the pinned versions in Zeppelin were published years before the compromise. This script filters out those specific advisories while still validating other high/critical security issues..github/workflows/frontend.ymlto run the customaudit-filter.jsinstead of the rawnpm auditcommand.How should this be tested?
Verify that the
npm-auditjob passes in GitHub Actions.