From a27b38e18a6460168b80b25e2992fa0fb7df5b1b Mon Sep 17 00:00:00 2001 From: navinko Date: Sat, 5 Sep 2026 17:48:00 +0530 Subject: [PATCH] HDDS-16385. Minor cleanups in NodeDecommissionManager --- .../hadoop/hdds/scm/node/NodeDecommissionManager.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeDecommissionManager.java b/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeDecommissionManager.java index e279a63a4ae1..569c62e6edd4 100644 --- a/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeDecommissionManager.java +++ b/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeDecommissionManager.java @@ -24,7 +24,6 @@ import java.net.URISyntaxException; import java.net.UnknownHostException; import java.util.ArrayList; -import java.util.Collections; import java.util.Comparator; import java.util.LinkedList; import java.util.List; @@ -106,7 +105,7 @@ private void parseHostname() throws InvalidHostStringException { if (this.hostname == null) { throw new InvalidHostStringException("The string " + rawHostname + - " does not contain a value hostname or hostname:port definition"); + " does not contain a valid hostname or hostname:port definition"); } } catch (URISyntaxException e) { throw new InvalidHostStringException( @@ -537,8 +536,7 @@ public synchronized void startMaintenance(DatanodeDetails dn, int endInHours) private synchronized boolean checkIfMaintenancePossible(List dns, List errors) { int numMaintenance = dns.size(); - List validDns = dns.stream().collect(Collectors.toList()); - Collections.copy(validDns, dns); + List validDns = new ArrayList<>(dns); int inServiceTotal = nodeManager.getNodeCount(NodeStatus.inServiceHealthy()); for (DatanodeDetails dn : dns) { try {