Privatize renderTo #1278
Merged
Privatize renderTo #1278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR tightens the encapsulation of the DefaultMessageHolder class by changing the visibility of the renderTo method from protected to private. Since Message is a private inner class and there are no subclasses of DefaultMessageHolder, the method can only be called internally within the class itself.
- Reduced visibility of
renderTomethod fromprotectedtoprivate
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
slachiewicz
approved these changes
Dec 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Message is a private class, the renderTo method can't be invoked by subclasses or any other class.