From a157ccbc91b98bd2f093fa0572c73e46aa39ff0f Mon Sep 17 00:00:00 2001 From: Sharang Gupta Date: Tue, 3 Nov 2026 16:33:42 +0000 Subject: [PATCH] Fail tests when the expected exception is missing testIOException and testNullCheckValueExceptionMessage only asserted inside the catch block, so they passed when nothing was thrown. --- .../java/org/apache/johnzon/core/JsonObjectBuilderImplTest.java | 2 ++ .../src/test/java/org/apache/johnzon/core/JsonParserTest.java | 1 + 2 files changed, 3 insertions(+) diff --git a/johnzon-core/src/test/java/org/apache/johnzon/core/JsonObjectBuilderImplTest.java b/johnzon-core/src/test/java/org/apache/johnzon/core/JsonObjectBuilderImplTest.java index 328217c2..383f82f7 100644 --- a/johnzon-core/src/test/java/org/apache/johnzon/core/JsonObjectBuilderImplTest.java +++ b/johnzon-core/src/test/java/org/apache/johnzon/core/JsonObjectBuilderImplTest.java @@ -26,6 +26,7 @@ import static java.util.Collections.singleton; import static java.util.Collections.singletonMap; import static org.junit.Assert.assertEquals; +import static org.junit.Assert.fail; import jakarta.json.Json; import jakarta.json.JsonConfig; @@ -169,6 +170,7 @@ public void testNullCheckValueExceptionMessage() { final JsonObjectBuilder builder = Json.createObjectBuilder(); try { builder.add("name", (JsonValue) null); + fail("Expected NullPointerException for a null value"); } catch (final NullPointerException e) { assertEquals("value/builder must not be null for name: name", e.getMessage()); } diff --git a/johnzon-core/src/test/java/org/apache/johnzon/core/JsonParserTest.java b/johnzon-core/src/test/java/org/apache/johnzon/core/JsonParserTest.java index bfcdacbf..f803ccb5 100644 --- a/johnzon-core/src/test/java/org/apache/johnzon/core/JsonParserTest.java +++ b/johnzon-core/src/test/java/org/apache/johnzon/core/JsonParserTest.java @@ -1074,6 +1074,7 @@ public int read() throws IOException { JsonParser parser = null; try { parser = Json.createParser(bin); + fail(); } catch (JsonException e) { assertEquals("We were expecting another cause", "Expected", e.getCause().getMessage()); } finally {