Skip to content

Commit 6935b41

Browse files
authored
Remove user flag from poetry installation (#2486)
related to #2425 # Rationale for this change Removing the user flag from the poetry installation to allow users who want to install poetry into a separate dedicated virtual environment. This virtual environment must be separate from the environment in which we install the iceberg-python repo. ## Are these changes tested? Yes manual testing ``` > python3 -m venv ~/.venvs/poetry > source ~/.venvs/poetry/bin/activate > echo $VIRTUAL_ENV /Users/geru/.venvs/poetry > python -m pip install -U pip setuptools wheel > poetry --version Poetry (version 2.1.4) > poetry show -v Using virtualenv: /Users/geru/workspace/iceberg-python/.venv > poetry install SUCCESS ``` ## Are there any user-facing changes? no cc: @kevinjqliu
1 parent 83789f0 commit 6935b41

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,12 +58,12 @@ help: ## Display this help message
5858
install-poetry: ## Ensure Poetry is installed at the specified version
5959
@if ! command -v ${POETRY} &> /dev/null; then \
6060
echo "Poetry not found. Installing..."; \
61-
${PIP} install --user poetry==$(POETRY_VERSION); \
61+
${PIP} install poetry==$(POETRY_VERSION); \
6262
else \
6363
INSTALLED_VERSION=$$(${PIP} show poetry | grep Version | awk '{print $$2}'); \
6464
if [ "$$INSTALLED_VERSION" != "$(POETRY_VERSION)" ]; then \
6565
echo "Updating Poetry to version $(POETRY_VERSION)..."; \
66-
${PIP} install --user --upgrade poetry==$(POETRY_VERSION); \
66+
${PIP} install --upgrade poetry==$(POETRY_VERSION); \
6767
else \
6868
echo "Poetry version $(POETRY_VERSION) already installed."; \
6969
fi; \

0 commit comments

Comments
 (0)