From 54c7cdd1a8118109fe6de64d12ab937a408a10b6 Mon Sep 17 00:00:00 2001 From: Zaheer Ahmad <129817147+ZaheerAhmadDev@users.noreply.github.com> Date: Sat, 25 Jul 2026 21:30:48 +0500 Subject: [PATCH] Cleanup: Remove unused private fields flagged by new UnusedPrivateField checkstyle check --- .../hadoop/hbase/backup/impl/BackupSystemTable.java | 1 - .../hadoop/hbase/mapreduce/TestTableInputFormat.java | 2 -- .../apache/hadoop/hbase/quotas/MasterQuotasObserver.java | 1 - .../org/apache/hadoop/hbase/regionserver/HMobStore.java | 1 - .../regionserver/metrics/MetricsThrottleExceptions.java | 9 --------- .../TestCompactionArchiveConcurrentClose.java | 1 - .../hbase/regionserver/TestMetricsUserAggregate.java | 1 - .../hadoop/hbase/regionserver/TestStoreScanner.java | 1 - 8 files changed, 17 deletions(-) diff --git a/hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupSystemTable.java b/hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupSystemTable.java index 124a791be776..6bf1430ce052 100644 --- a/hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupSystemTable.java +++ b/hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupSystemTable.java @@ -167,7 +167,6 @@ public String toString() { private final Connection connection; private final static String BACKUP_INFO_PREFIX = "session:"; - private final static String START_CODE_ROW = "startcode:"; private final static byte[] ACTIVE_SESSION_ROW = Bytes.toBytes("activesession:"); private final static byte[] ACTIVE_SESSION_COL = Bytes.toBytes("c"); diff --git a/hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormat.java b/hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormat.java index 8d9056e0f90e..8bcee436dd3a 100644 --- a/hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormat.java +++ b/hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableInputFormat.java @@ -79,8 +79,6 @@ public class TestTableInputFormat { private static MiniMRCluster mrCluster; static final byte[] FAMILY = Bytes.toBytes("family"); - private static final byte[][] columns = new byte[][] { FAMILY }; - @BeforeAll public static void beforeClass() throws Exception { UTIL.startMiniCluster(); diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/MasterQuotasObserver.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/MasterQuotasObserver.java index 0f6d904e8bbf..716f08a14af2 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/MasterQuotasObserver.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/MasterQuotasObserver.java @@ -45,7 +45,6 @@ public class MasterQuotasObserver implements MasterCoprocessor, MasterObserver { public static final String REMOVE_QUOTA_ON_TABLE_DELETE = "hbase.quota.remove.on.table.delete"; public static final boolean REMOVE_QUOTA_ON_TABLE_DELETE_DEFAULT = true; - private CoprocessorEnvironment cpEnv; private Configuration conf; private boolean quotasEnabled = false; private MasterServices masterServices; diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HMobStore.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HMobStore.java index daed80ee8db6..f828fe33cea5 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HMobStore.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HMobStore.java @@ -102,7 +102,6 @@ public class HMobStore extends HStore { // table, we need to find the original mob files by this table name. For details please see // cloning snapshot for mob files. private final byte[] refCellTags; - private StoreFileTracker mobStoreSFT = null; public HMobStore(final HRegion region, final ColumnFamilyDescriptor family, final Configuration confParam, boolean warmup) throws IOException { diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/MetricsThrottleExceptions.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/MetricsThrottleExceptions.java index ddf451ab2e29..b1eb2c1fb91a 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/MetricsThrottleExceptions.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/MetricsThrottleExceptions.java @@ -29,15 +29,6 @@ public class MetricsThrottleExceptions { */ private static final String METRICS_NAME = "ThrottleExceptions"; - /** - * The name of the metrics context that metrics will be under. - */ - private static final String METRICS_CONTEXT = "regionserver"; - - /** - * Description - */ - private static final String METRICS_DESCRIPTION = "Metrics about RPC throttling exceptions"; /** * The name of the metrics context that metrics will be under in jmx diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionArchiveConcurrentClose.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionArchiveConcurrentClose.java index ce58ce19140d..5c3ac0359146 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionArchiveConcurrentClose.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionArchiveConcurrentClose.java @@ -64,7 +64,6 @@ public class TestCompactionArchiveConcurrentClose { private HBaseTestingUtil testUtil; private Path testDir; - private AtomicBoolean archived = new AtomicBoolean(); // Static field to track archived state for the static inner class private static final AtomicBoolean STATIC_ARCHIVED = new AtomicBoolean(); diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsUserAggregate.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsUserAggregate.java index a845c01e40cf..bd2f824e98e9 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsUserAggregate.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMetricsUserAggregate.java @@ -47,7 +47,6 @@ public class TestMetricsUserAggregate { private MetricsRegionServerWrapperStub wrapper; private MetricsRegionServer rsm; private MetricsUserAggregate userAgg; - private TableName tableName = TableName.valueOf("testUserAggregateMetrics"); @BeforeAll public static void classSetUp() { diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java index f661e17e6ac7..04280c39e10a 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java @@ -98,7 +98,6 @@ public void setTestName(TestInfo testInfo) { private static final String CF_STR = "cf"; private static final byte[] CF = Bytes.toBytes(CF_STR); static Configuration CONF = HBaseConfiguration.create(); - private static final HBaseTestingUtil TEST_UTIL = new HBaseTestingUtil(); private ScanInfo scanInfo = new ScanInfo(CONF, CF, 0, Integer.MAX_VALUE, Long.MAX_VALUE, KeepDeletedCells.FALSE, HConstants.DEFAULT_BLOCKSIZE, 0, CellComparator.getInstance(), false);