From 64b03b12bed1b8e717773cc103c5cb557993e3fa Mon Sep 17 00:00:00 2001
From: englefly <zhouminghong@selectdb.com>
Date: Tue, 17 Mar 2026 20:42:34 +0800
Subject: [PATCH 1/4] make checkstyle.xml compatible to vscode

---
 fe/check/checkstyle/checkstyle.xml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fe/check/checkstyle/checkstyle.xml b/fe/check/checkstyle/checkstyle.xml
index 86f303d84c8113..2b87546548beed 100644
--- a/fe/check/checkstyle/checkstyle.xml
+++ b/fe/check/checkstyle/checkstyle.xml
@@ -33,7 +33,7 @@ under the License.
     </module>
 
     <module name="SuppressionFilter">
-        <property name="file" value="check/checkstyle/suppressions.xml"/>
+        <property name="file" value="${config_loc}/suppressions.xml"/>
         <property name="optional" value="true"/>
     </module>
     <module name="SuppressWithPlainTextCommentFilter">
@@ -45,7 +45,7 @@ under the License.
         <property name="eachLine" value="true"/>
     </module>
     <module name="Header">
-        <property name="headerFile" value="check/checkstyle/checkstyle-apache-header.txt"/>
+        <property name="headerFile" value="${config_loc}/checkstyle-apache-header.txt"/>
         <property name="fileExtensions" value="java"/>
     </module>
     <module name="LineLength">
@@ -161,7 +161,7 @@ under the License.
             <property name="tokens" value="IMPORT, STATIC_IMPORT, PACKAGE_DEF"/>
         </module>
         <module name="ImportControl">
-            <property name="file" value="check/checkstyle/import-control.xml"/>
+            <property name="file" value="${config_loc}/import-control.xml"/>
         </module>
         <module name="RedundantImport"/>
         <module name="UnusedImports"/>

From c0dbd409bc2a6f1732244715bb6a3b9b864128fc Mon Sep 17 00:00:00 2001
From: englefly <englefly@gmail.com>
Date: Wed, 18 Mar 2026 10:13:57 +0800
Subject: [PATCH 2/4] set config_loc for mvn < 3.0

---
 fe/pom.xml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/fe/pom.xml b/fe/pom.xml
index db6deaf5f3f428..7945acfeaf90b5 100644
--- a/fe/pom.xml
+++ b/fe/pom.xml
@@ -191,6 +191,11 @@ under the License.
                         <failsOnError>true</failsOnError>
                         <linkXRef>false</linkXRef>
                         <includeTestSourceDirectory>true</includeTestSourceDirectory>
+                        <!-- Explicitly set config_loc so that checkstyle.xml can reference sibling
+                             files via ${config_loc}/suppressions.xml etc.
+                             maven-checkstyle-plugin 3.0+ sets this automatically, but older
+                             versions do not, causing "Property ${config_loc} has not been set". -->
+                        <propertyExpansion>config_loc=${project.parent.basedir}/check/checkstyle</propertyExpansion>
                         <excludes>
                             **/apache/doris/thrift/**/*,
                             **/apache/parquet/**/*

From abbf6bc859e57d929c84aefa74a5641bc0afe968 Mon Sep 17 00:00:00 2001
From: englefly <englefly@gmail.com>
Date: Wed, 18 Mar 2026 10:27:04 +0800
Subject: [PATCH 3/4] fix

---
 fe/pom.xml | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/fe/pom.xml b/fe/pom.xml
index 7945acfeaf90b5..cc603c8ab9e51e 100644
--- a/fe/pom.xml
+++ b/fe/pom.xml
@@ -117,6 +117,13 @@ under the License.
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-checkstyle-plugin</artifactId>
+                <!-- fe is an aggregator pom with no Java sources; skip checkstyle for it.
+                     inherited=false ensures child modules are not affected and still
+                     use the pluginManagement configuration. -->
+                <configuration>
+                    <skip>true</skip>
+                </configuration>
+                <inherited>false</inherited>
             </plugin>
             <plugin>
                 <groupId>org.codehaus.mojo</groupId>
@@ -194,8 +201,11 @@ under the License.
                         <!-- Explicitly set config_loc so that checkstyle.xml can reference sibling
                              files via ${config_loc}/suppressions.xml etc.
                              maven-checkstyle-plugin 3.0+ sets this automatically, but older
-                             versions do not, causing "Property ${config_loc} has not been set". -->
-                        <propertyExpansion>config_loc=${project.parent.basedir}/check/checkstyle</propertyExpansion>
+                             versions do not, causing "Property ${config_loc} has not been set".
+                             ${maven.multiModuleProjectDirectory} always points to the directory
+                             from which Maven was invoked (the fe/ root), so this works for all
+                             submodules regardless of nesting depth. Requires Maven 3.3.1+. -->
+                        <propertyExpansion>config_loc=${maven.multiModuleProjectDirectory}/check/checkstyle</propertyExpansion>
                         <excludes>
                             **/apache/doris/thrift/**/*,
                             **/apache/parquet/**/*

From 155fea4b44fdf227158f231929d3972d936ada47 Mon Sep 17 00:00:00 2001
From: englefly <englefly@gmail.com>
Date: Wed, 18 Mar 2026 10:49:34 +0800
Subject: [PATCH 4/4] 2

---
 fe/pom.xml | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/fe/pom.xml b/fe/pom.xml
index cc603c8ab9e51e..6fa3dcd6b2a209 100644
--- a/fe/pom.xml
+++ b/fe/pom.xml
@@ -117,13 +117,6 @@ under the License.
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-checkstyle-plugin</artifactId>
-                <!-- fe is an aggregator pom with no Java sources; skip checkstyle for it.
-                     inherited=false ensures child modules are not affected and still
-                     use the pluginManagement configuration. -->
-                <configuration>
-                    <skip>true</skip>
-                </configuration>
-                <inherited>false</inherited>
             </plugin>
             <plugin>
                 <groupId>org.codehaus.mojo</groupId>