From 3c67c45045f5c16b6be7eab82162612fbc82d363 Mon Sep 17 00:00:00 2001 From: Nachiket Roy Date: Sat, 27 Dec 2025 11:46:00 +0000 Subject: [PATCH 1/4] docs : clarify unused test utility --- datafusion/ffi/tests/utils/mod.rs | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/datafusion/ffi/tests/utils/mod.rs b/datafusion/ffi/tests/utils/mod.rs index a83512f663cf2..296bfe4ab0562 100644 --- a/datafusion/ffi/tests/utils/mod.rs +++ b/datafusion/ffi/tests/utils/mod.rs @@ -23,6 +23,11 @@ use datafusion_ffi::execution::FFI_TaskContextProvider; use datafusion_ffi::proto::logical_extension_codec::FFI_LogicalExtensionCodec; use datafusion_proto::logical_plan::DefaultLogicalExtensionCodec; +// Creates a default SessionContext and FFI Logical Extension Codec +// for use in FFI integration tests. +// This helper centralizes setup logic and is kept intentionally +// for upcoming FFI test expansions. +#[allow(dead_code)] pub fn ctx_and_codec() -> (Arc, FFI_LogicalExtensionCodec) { let ctx = Arc::new(SessionContext::default()); let task_ctx_provider = Arc::clone(&ctx) as Arc; From 9aacabbb588a22b69f3b0446a75215f395264604 Mon Sep 17 00:00:00 2001 From: Nachiket Roy Date: Sat, 27 Dec 2025 13:27:20 +0000 Subject: [PATCH 2/4] fix : allow to expect --- datafusion/ffi/tests/utils/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datafusion/ffi/tests/utils/mod.rs b/datafusion/ffi/tests/utils/mod.rs index 296bfe4ab0562..015e90a6d08b9 100644 --- a/datafusion/ffi/tests/utils/mod.rs +++ b/datafusion/ffi/tests/utils/mod.rs @@ -27,7 +27,7 @@ use datafusion_proto::logical_plan::DefaultLogicalExtensionCodec; // for use in FFI integration tests. // This helper centralizes setup logic and is kept intentionally // for upcoming FFI test expansions. -#[allow(dead_code)] +#[expect(dead_code)] pub fn ctx_and_codec() -> (Arc, FFI_LogicalExtensionCodec) { let ctx = Arc::new(SessionContext::default()); let task_ctx_provider = Arc::clone(&ctx) as Arc; From 96f235e0f3057e1dc435e97226eed0d0b80ddffd Mon Sep 17 00:00:00 2001 From: Nachiket Roy Date: Sat, 27 Dec 2025 15:40:34 +0000 Subject: [PATCH 3/4] revert to allow(dead_code) --- datafusion/ffi/tests/utils/mod.rs | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/datafusion/ffi/tests/utils/mod.rs b/datafusion/ffi/tests/utils/mod.rs index 015e90a6d08b9..dbba71d64a831 100644 --- a/datafusion/ffi/tests/utils/mod.rs +++ b/datafusion/ffi/tests/utils/mod.rs @@ -25,9 +25,15 @@ use datafusion_proto::logical_plan::DefaultLogicalExtensionCodec; // Creates a default SessionContext and FFI Logical Extension Codec // for use in FFI integration tests. +// // This helper centralizes setup logic and is kept intentionally // for upcoming FFI test expansions. -#[expect(dead_code)] +// +// Note: This function may appear unused in non-test builds +// (e.g. rust-analyzer or `cargo check`) because it is only +// referenced from integration tests. The `allow(dead_code)` +// avoids spurious warnings in such cases. +#[allow(dead_code)] pub fn ctx_and_codec() -> (Arc, FFI_LogicalExtensionCodec) { let ctx = Arc::new(SessionContext::default()); let task_ctx_provider = Arc::clone(&ctx) as Arc; From 786135399dfed383a45694a2017168d39a7f8378 Mon Sep 17 00:00:00 2001 From: Nachiket Roy Date: Sun, 28 Dec 2025 08:33:29 +0000 Subject: [PATCH 4/4] conditionally expect dead_code for FFI test helper --- datafusion/ffi/tests/utils/mod.rs | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/datafusion/ffi/tests/utils/mod.rs b/datafusion/ffi/tests/utils/mod.rs index dbba71d64a831..acf59de7f3464 100644 --- a/datafusion/ffi/tests/utils/mod.rs +++ b/datafusion/ffi/tests/utils/mod.rs @@ -28,12 +28,7 @@ use datafusion_proto::logical_plan::DefaultLogicalExtensionCodec; // // This helper centralizes setup logic and is kept intentionally // for upcoming FFI test expansions. -// -// Note: This function may appear unused in non-test builds -// (e.g. rust-analyzer or `cargo check`) because it is only -// referenced from integration tests. The `allow(dead_code)` -// avoids spurious warnings in such cases. -#[allow(dead_code)] +#[cfg_attr(not(feature = "integration-tests"), expect(dead_code))] pub fn ctx_and_codec() -> (Arc, FFI_LogicalExtensionCodec) { let ctx = Arc::new(SessionContext::default()); let task_ctx_provider = Arc::clone(&ctx) as Arc;