Skip to content

Commit 6f0d76b

Browse files
committed
More CI updates, but expect pytest to fail until we switch to downloading the wheel artifacts from build stage
1 parent 4097003 commit 6f0d76b

File tree

2 files changed

+5
-24
lines changed

2 files changed

+5
-24
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,13 +49,14 @@ jobs:
4949
- name: Setup Rust
5050
uses: dtolnay/rust-toolchain@stable
5151
with:
52+
toolchain: "nightly"
5253
components: rustfmt
5354

5455
- name: Cache Cargo
5556
uses: Swatinem/rust-cache@v2
5657

5758
- name: Check formatting
58-
run: cargo fmt --all -- --check
59+
run: cargo +nightly fmt --all -- --check
5960

6061
lint-python:
6162
runs-on: ubuntu-latest

.github/workflows/test.yaml

Lines changed: 3 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,6 @@ jobs:
5959
- name: Setup Rust Toolchain
6060
uses: dtolnay/rust-toolchain@stable
6161
id: rust-toolchain
62-
with:
63-
components: clippy,rustfmt
6462

6563
- name: Install Protoc
6664
uses: arduino/setup-protoc@v3
@@ -79,22 +77,20 @@ jobs:
7977
path: ~/.cargo
8078
key: cargo-cache-${{ steps.rust-toolchain.outputs.cachekey }}-${{ hashFiles('Cargo.lock') }}
8179

82-
- name: Run Clippy
83-
if: ${{ matrix.python-version == '3.10' && matrix.toolchain == 'stable' }}
84-
run: cargo clippy --all-targets --all-features -- -D clippy::all -D warnings -A clippy::redundant_closure
85-
8680
- name: Install dependencies and build
8781
uses: astral-sh/setup-uv@v7
8882
with:
8983
enable-cache: true
9084

85+
# TODO: Download wheel and uv pip install
86+
9187
- name: Run tests
9288
env:
9389
RUST_BACKTRACE: 1
9490
run: |
9591
git submodule update --init
9692
uv sync --dev --no-install-package datafusion
97-
uv run --no-project maturin develop --uv
93+
# uv run --no-project maturin develop --uv
9894
uv run --no-project pytest -v .
9995

10096
- name: FFI unit tests
@@ -121,19 +117,3 @@ jobs:
121117
cd examples/tpch
122118
uv run --no-project python convert_data_to_parquet.py
123119
uv run --no-project pytest _tests.py
124-
125-
nightly-fmt:
126-
runs-on: ubuntu-latest
127-
128-
steps:
129-
- uses: actions/checkout@v6
130-
131-
- name: Setup Rust Toolchain
132-
uses: dtolnay/rust-toolchain@stable
133-
id: rust-toolchain
134-
with:
135-
toolchain: "nightly"
136-
components: clippy,rustfmt
137-
138-
- name: Check Formatting
139-
run: cargo +nightly fmt -- --check

0 commit comments

Comments
 (0)