diff --git a/.claude/skills/review-comet-pr/SKILL.md b/.claude/skills/review-comet-pr/SKILL.md index cf87bcfc87..8c77605076 100644 --- a/.claude/skills/review-comet-pr/SKILL.md +++ b/.claude/skills/review-comet-pr/SKILL.md @@ -149,8 +149,6 @@ Categories include: `aggregate/`, `array/`, `string/`, `math/`, `struct/`, `map/ **SQL file structure:** ```sql --- ConfigMatrix: parquet.enable.dictionary=false,true - -- Create test data statement CREATE TABLE test_crc32(col string, a int, b float) USING parquet diff --git a/docs/source/contributor-guide/adding_a_new_expression.md b/docs/source/contributor-guide/adding_a_new_expression.md index e989b76362..10af50e069 100644 --- a/docs/source/contributor-guide/adding_a_new_expression.md +++ b/docs/source/contributor-guide/adding_a_new_expression.md @@ -217,8 +217,6 @@ It is important to verify that the new expression is correctly recognized by the Create a `.sql` file under the appropriate subdirectory in `spark/src/test/resources/sql-tests/expressions/` (e.g., `string/`, `math/`, `array/`). The file should create a table with test data, then run queries that exercise the expression. Here is an example for the `unhex` expression: ```sql --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_unhex(col string) USING parquet diff --git a/docs/source/contributor-guide/sql-file-tests.md b/docs/source/contributor-guide/sql-file-tests.md index 1a55323b84..bff8dc50df 100644 --- a/docs/source/contributor-guide/sql-file-tests.md +++ b/docs/source/contributor-guide/sql-file-tests.md @@ -76,8 +76,6 @@ A test file consists of SQL comments, directives, statements, and queries separa lines. Here is a minimal example: ```sql --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_abs(v double) USING parquet @@ -106,16 +104,19 @@ Runs the entire file once per combination of values. Multiple `ConfigMatrix` lin cross product of all combinations. ```sql --- ConfigMatrix: parquet.enable.dictionary=false,true +-- ConfigMatrix: spark.sql.optimizer.inSetConversionThreshold=100,0 ``` This generates two test cases: ``` -sql-file: expressions/cast/cast.sql [parquet.enable.dictionary=false] -sql-file: expressions/cast/cast.sql [parquet.enable.dictionary=true] +sql-file: expressions/conditional/in_set.sql [spark.sql.optimizer.inSetConversionThreshold=100] +sql-file: expressions/conditional/in_set.sql [spark.sql.optimizer.inSetConversionThreshold=0] ``` +Only add a `ConfigMatrix` directive when there is a real reason to run the test under +multiple configurations. Do not add `ConfigMatrix` directives speculatively. + #### `MinSparkVersion` Skips the file when running on a Spark version older than the specified version. @@ -223,12 +224,9 @@ SELECT array(1, 2, 3)[10] 2. Add the Apache license header as a SQL comment. -3. Add a `ConfigMatrix` directive if the test should run with multiple Parquet configurations. - Most expression tests use: - - ```sql - -- ConfigMatrix: parquet.enable.dictionary=false,true - ``` +3. Add a `ConfigMatrix` directive only if the test needs to run under multiple configurations + (e.g., testing behavior that varies with a specific Spark config). Do not add `ConfigMatrix` + directives speculatively. 4. Create tables and insert test data using `statement` blocks. Include edge cases such as `NULL`, boundary values, and negative numbers. diff --git a/spark/src/test/resources/sql-tests/expressions/aggregate/aggregate_filter.sql b/spark/src/test/resources/sql-tests/expressions/aggregate/aggregate_filter.sql index c8787868ac..50892c0285 100644 --- a/spark/src/test/resources/sql-tests/expressions/aggregate/aggregate_filter.sql +++ b/spark/src/test/resources/sql-tests/expressions/aggregate/aggregate_filter.sql @@ -83,4 +83,3 @@ SELECT AVG(d) FILTER (WHERE flag = true) FROM test_agg_filter query spark_answer_only SELECT grp, AVG(d) FILTER (WHERE flag = true) FROM test_agg_filter GROUP BY grp ORDER BY grp - diff --git a/spark/src/test/resources/sql-tests/expressions/aggregate/avg.sql b/spark/src/test/resources/sql-tests/expressions/aggregate/avg.sql index c46a14c617..c718a80ded 100644 --- a/spark/src/test/resources/sql-tests/expressions/aggregate/avg.sql +++ b/spark/src/test/resources/sql-tests/expressions/aggregate/avg.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_avg(i int, l long, f float, d double, grp string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/aggregate/bit_agg.sql b/spark/src/test/resources/sql-tests/expressions/aggregate/bit_agg.sql index 32a09febc2..0edb836d50 100644 --- a/spark/src/test/resources/sql-tests/expressions/aggregate/bit_agg.sql +++ b/spark/src/test/resources/sql-tests/expressions/aggregate/bit_agg.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_bit_agg(i int, grp string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/aggregate/corr.sql b/spark/src/test/resources/sql-tests/expressions/aggregate/corr.sql index 4231da316c..32525ca4cb 100644 --- a/spark/src/test/resources/sql-tests/expressions/aggregate/corr.sql +++ b/spark/src/test/resources/sql-tests/expressions/aggregate/corr.sql @@ -16,7 +16,6 @@ -- under the License. -- Config: spark.comet.expression.Corr.allowIncompatible=true --- ConfigMatrix: parquet.enable.dictionary=false,true statement CREATE TABLE test_corr(x double, y double, grp string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/aggregate/count.sql b/spark/src/test/resources/sql-tests/expressions/aggregate/count.sql index b7fec97557..076a6e5a65 100644 --- a/spark/src/test/resources/sql-tests/expressions/aggregate/count.sql +++ b/spark/src/test/resources/sql-tests/expressions/aggregate/count.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_count(i int, s string, grp string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/aggregate/covariance.sql b/spark/src/test/resources/sql-tests/expressions/aggregate/covariance.sql index eca4b5ff1b..45e979f365 100644 --- a/spark/src/test/resources/sql-tests/expressions/aggregate/covariance.sql +++ b/spark/src/test/resources/sql-tests/expressions/aggregate/covariance.sql @@ -1,3 +1,4 @@ + -- Licensed to the Apache Software Foundation (ASF) under one -- or more contributor license agreements. See the NOTICE file -- distributed with this work for additional information @@ -15,8 +16,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_covar(x double, y double, grp string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/aggregate/first_last.sql b/spark/src/test/resources/sql-tests/expressions/aggregate/first_last.sql index 7bc617bffd..8bc6c54db7 100644 --- a/spark/src/test/resources/sql-tests/expressions/aggregate/first_last.sql +++ b/spark/src/test/resources/sql-tests/expressions/aggregate/first_last.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_first_last(i int, grp string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/aggregate/min_max.sql b/spark/src/test/resources/sql-tests/expressions/aggregate/min_max.sql index 50a13d5896..dbec88e2f6 100644 --- a/spark/src/test/resources/sql-tests/expressions/aggregate/min_max.sql +++ b/spark/src/test/resources/sql-tests/expressions/aggregate/min_max.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_min_max(i int, d double, s string, grp string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/aggregate/stddev.sql b/spark/src/test/resources/sql-tests/expressions/aggregate/stddev.sql index cd70852daf..a9376c4d6b 100644 --- a/spark/src/test/resources/sql-tests/expressions/aggregate/stddev.sql +++ b/spark/src/test/resources/sql-tests/expressions/aggregate/stddev.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_stddev(d double, grp string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/aggregate/sum.sql b/spark/src/test/resources/sql-tests/expressions/aggregate/sum.sql index 306bbe9128..80f3c5de80 100644 --- a/spark/src/test/resources/sql-tests/expressions/aggregate/sum.sql +++ b/spark/src/test/resources/sql-tests/expressions/aggregate/sum.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_sum(i int, l long, f float, d double, grp string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/aggregate/variance.sql b/spark/src/test/resources/sql-tests/expressions/aggregate/variance.sql index be4905d5fa..127216f80d 100644 --- a/spark/src/test/resources/sql-tests/expressions/aggregate/variance.sql +++ b/spark/src/test/resources/sql-tests/expressions/aggregate/variance.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_variance(d double, grp string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/array/array_append.sql b/spark/src/test/resources/sql-tests/expressions/array/array_append.sql index 53f2593406..4453ab663e 100644 --- a/spark/src/test/resources/sql-tests/expressions/array/array_append.sql +++ b/spark/src/test/resources/sql-tests/expressions/array/array_append.sql @@ -18,7 +18,6 @@ -- On Spark 4.0, array_append is a RuntimeReplaceable that rewrites to array_insert(-1), -- so we need to allow the incompatible array_insert to run natively there. -- Config: spark.comet.expression.ArrayInsert.allowIncompatible=true --- ConfigMatrix: parquet.enable.dictionary=false,true statement CREATE TABLE test_array_append(arr array, val int) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/array/array_compact.sql b/spark/src/test/resources/sql-tests/expressions/array/array_compact.sql index 9b834a4dbd..3b6c607c04 100644 --- a/spark/src/test/resources/sql-tests/expressions/array/array_compact.sql +++ b/spark/src/test/resources/sql-tests/expressions/array/array_compact.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_array_compact(arr array) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/array/array_concat.sql b/spark/src/test/resources/sql-tests/expressions/array/array_concat.sql index 9a3a4a8138..21d83a7afb 100644 --- a/spark/src/test/resources/sql-tests/expressions/array/array_concat.sql +++ b/spark/src/test/resources/sql-tests/expressions/array/array_concat.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - -- migrated from CometExpressionSuite "test concat function - arrays" -- https://github.com/apache/datafusion-comet/issues/2647 diff --git a/spark/src/test/resources/sql-tests/expressions/array/array_contains.sql b/spark/src/test/resources/sql-tests/expressions/array/array_contains.sql index cdbe3e68c2..46e96c85ef 100644 --- a/spark/src/test/resources/sql-tests/expressions/array/array_contains.sql +++ b/spark/src/test/resources/sql-tests/expressions/array/array_contains.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_array_contains(arr array, val int) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/array/array_distinct.sql b/spark/src/test/resources/sql-tests/expressions/array/array_distinct.sql index 43c18e9889..5e42bb7d93 100644 --- a/spark/src/test/resources/sql-tests/expressions/array/array_distinct.sql +++ b/spark/src/test/resources/sql-tests/expressions/array/array_distinct.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_array_distinct(arr array) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/array/array_except.sql b/spark/src/test/resources/sql-tests/expressions/array/array_except.sql index 3b3f45111c..1b78896dbf 100644 --- a/spark/src/test/resources/sql-tests/expressions/array/array_except.sql +++ b/spark/src/test/resources/sql-tests/expressions/array/array_except.sql @@ -14,8 +14,8 @@ -- KIND, either express or implied. See the License for the -- specific language governing permissions and limitations -- under the License. + -- Config: spark.comet.expression.ArrayExcept.allowIncompatible=true --- ConfigMatrix: parquet.enable.dictionary=false,true statement CREATE TABLE test_array_except(a array, b array) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/array/array_filter.sql b/spark/src/test/resources/sql-tests/expressions/array/array_filter.sql index a5cc165815..7001ce5c36 100644 --- a/spark/src/test/resources/sql-tests/expressions/array/array_filter.sql +++ b/spark/src/test/resources/sql-tests/expressions/array/array_filter.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_array_filter(arr array) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/array/array_insert.sql b/spark/src/test/resources/sql-tests/expressions/array/array_insert.sql index 2d5754ea8e..b3288d868d 100644 --- a/spark/src/test/resources/sql-tests/expressions/array/array_insert.sql +++ b/spark/src/test/resources/sql-tests/expressions/array/array_insert.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_array_insert(arr array, pos int, val int) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/array/array_intersect.sql b/spark/src/test/resources/sql-tests/expressions/array/array_intersect.sql index d77cccd925..dc92f41edc 100644 --- a/spark/src/test/resources/sql-tests/expressions/array/array_intersect.sql +++ b/spark/src/test/resources/sql-tests/expressions/array/array_intersect.sql @@ -16,7 +16,6 @@ -- under the License. -- Config: spark.comet.expression.ArrayIntersect.allowIncompatible=true --- ConfigMatrix: parquet.enable.dictionary=false,true statement CREATE TABLE test_array_intersect(a array, b array) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/array/array_join.sql b/spark/src/test/resources/sql-tests/expressions/array/array_join.sql index 840fc3f2c8..e234196b40 100644 --- a/spark/src/test/resources/sql-tests/expressions/array/array_join.sql +++ b/spark/src/test/resources/sql-tests/expressions/array/array_join.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_array_join(arr array) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/array/array_max.sql b/spark/src/test/resources/sql-tests/expressions/array/array_max.sql index dd1211598c..9a90fc2d29 100644 --- a/spark/src/test/resources/sql-tests/expressions/array/array_max.sql +++ b/spark/src/test/resources/sql-tests/expressions/array/array_max.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_array_max(arr array) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/array/array_min.sql b/spark/src/test/resources/sql-tests/expressions/array/array_min.sql index da7f8f4d2c..bfd4ab8140 100644 --- a/spark/src/test/resources/sql-tests/expressions/array/array_min.sql +++ b/spark/src/test/resources/sql-tests/expressions/array/array_min.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_array_min(arr array) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/array/array_remove.sql b/spark/src/test/resources/sql-tests/expressions/array/array_remove.sql index aead1fa44d..b96747df6d 100644 --- a/spark/src/test/resources/sql-tests/expressions/array/array_remove.sql +++ b/spark/src/test/resources/sql-tests/expressions/array/array_remove.sql @@ -16,7 +16,6 @@ -- under the License. -- Config: spark.comet.expression.ArrayRemove.allowIncompatible=true --- ConfigMatrix: parquet.enable.dictionary=false,true statement CREATE TABLE test_array_remove(arr array, val int) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/array/array_repeat.sql b/spark/src/test/resources/sql-tests/expressions/array/array_repeat.sql index f9db5ec1ec..a265caf9b4 100644 --- a/spark/src/test/resources/sql-tests/expressions/array/array_repeat.sql +++ b/spark/src/test/resources/sql-tests/expressions/array/array_repeat.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_array_repeat(val int, cnt int) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/array/array_union.sql b/spark/src/test/resources/sql-tests/expressions/array/array_union.sql index cbff2dc67a..afcd873763 100644 --- a/spark/src/test/resources/sql-tests/expressions/array/array_union.sql +++ b/spark/src/test/resources/sql-tests/expressions/array/array_union.sql @@ -16,7 +16,6 @@ -- under the License. -- Config: spark.comet.expression.ArrayUnion.allowIncompatible=true --- ConfigMatrix: parquet.enable.dictionary=false,true statement CREATE TABLE test_array_union(a array, b array) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/array/arrays_overlap.sql b/spark/src/test/resources/sql-tests/expressions/array/arrays_overlap.sql index 27d28a7402..e9f107d568 100644 --- a/spark/src/test/resources/sql-tests/expressions/array/arrays_overlap.sql +++ b/spark/src/test/resources/sql-tests/expressions/array/arrays_overlap.sql @@ -16,7 +16,6 @@ -- under the License. -- Config: spark.comet.expression.ArraysOverlap.allowIncompatible=true --- ConfigMatrix: parquet.enable.dictionary=false,true statement CREATE TABLE test_arrays_overlap(a array, b array) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/array/create_array.sql b/spark/src/test/resources/sql-tests/expressions/array/create_array.sql index 0b41f0220c..5d59df4577 100644 --- a/spark/src/test/resources/sql-tests/expressions/array/create_array.sql +++ b/spark/src/test/resources/sql-tests/expressions/array/create_array.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_create_array(a int, b int, c int) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/array/element_at.sql b/spark/src/test/resources/sql-tests/expressions/array/element_at.sql index a2e98849fc..438a20cd59 100644 --- a/spark/src/test/resources/sql-tests/expressions/array/element_at.sql +++ b/spark/src/test/resources/sql-tests/expressions/array/element_at.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_element_at(arr array) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/array/flatten.sql b/spark/src/test/resources/sql-tests/expressions/array/flatten.sql index effc123605..8a9c60df24 100644 --- a/spark/src/test/resources/sql-tests/expressions/array/flatten.sql +++ b/spark/src/test/resources/sql-tests/expressions/array/flatten.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_flatten(arr array>) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/array/get_array_item.sql b/spark/src/test/resources/sql-tests/expressions/array/get_array_item.sql index c7ebdb514d..c00a21f3df 100644 --- a/spark/src/test/resources/sql-tests/expressions/array/get_array_item.sql +++ b/spark/src/test/resources/sql-tests/expressions/array/get_array_item.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_get_array_item(arr array, idx int) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/array/get_array_struct_fields.sql b/spark/src/test/resources/sql-tests/expressions/array/get_array_struct_fields.sql index e65bd297dd..935ab048a1 100644 --- a/spark/src/test/resources/sql-tests/expressions/array/get_array_struct_fields.sql +++ b/spark/src/test/resources/sql-tests/expressions/array/get_array_struct_fields.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_arr_struct(arr array>) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/array/size.sql b/spark/src/test/resources/sql-tests/expressions/array/size.sql index de989337f5..b006a4da0d 100644 --- a/spark/src/test/resources/sql-tests/expressions/array/size.sql +++ b/spark/src/test/resources/sql-tests/expressions/array/size.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_size(arr array, m map) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/bitwise/bitwise.sql b/spark/src/test/resources/sql-tests/expressions/bitwise/bitwise.sql index 74a971f368..8b7ade25f0 100644 --- a/spark/src/test/resources/sql-tests/expressions/bitwise/bitwise.sql +++ b/spark/src/test/resources/sql-tests/expressions/bitwise/bitwise.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - -- Setup statement CREATE TABLE test(col1 int, col2 int) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/cast/cast.sql b/spark/src/test/resources/sql-tests/expressions/cast/cast.sql index e848e0e636..4e49fac6c7 100644 --- a/spark/src/test/resources/sql-tests/expressions/cast/cast.sql +++ b/spark/src/test/resources/sql-tests/expressions/cast/cast.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_cast(i int, l long, f float, d double, s string, b boolean) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/cast/cast_double_to_string.sql b/spark/src/test/resources/sql-tests/expressions/cast/cast_double_to_string.sql index 876bfd0b5e..b2c7cf94b9 100644 --- a/spark/src/test/resources/sql-tests/expressions/cast/cast_double_to_string.sql +++ b/spark/src/test/resources/sql-tests/expressions/cast/cast_double_to_string.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_double_to_string(d double, id int) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/conditional/boolean.sql b/spark/src/test/resources/sql-tests/expressions/conditional/boolean.sql index 00688f5fa8..3d2e2f8109 100644 --- a/spark/src/test/resources/sql-tests/expressions/conditional/boolean.sql +++ b/spark/src/test/resources/sql-tests/expressions/conditional/boolean.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - -- compare true/false to negative zero statement CREATE TABLE test(col1 boolean, col2 float) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/conditional/case_when.sql b/spark/src/test/resources/sql-tests/expressions/conditional/case_when.sql index eff3123743..508571d728 100644 --- a/spark/src/test/resources/sql-tests/expressions/conditional/case_when.sql +++ b/spark/src/test/resources/sql-tests/expressions/conditional/case_when.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_case_when(i int, s string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/conditional/coalesce.sql b/spark/src/test/resources/sql-tests/expressions/conditional/coalesce.sql index 26fa6a2553..6457768aed 100644 --- a/spark/src/test/resources/sql-tests/expressions/conditional/coalesce.sql +++ b/spark/src/test/resources/sql-tests/expressions/conditional/coalesce.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_coalesce(a int, b int, c int) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/conditional/if_expr.sql b/spark/src/test/resources/sql-tests/expressions/conditional/if_expr.sql index ecc17f6b55..53b908ca79 100644 --- a/spark/src/test/resources/sql-tests/expressions/conditional/if_expr.sql +++ b/spark/src/test/resources/sql-tests/expressions/conditional/if_expr.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_if(cond boolean, a int, b int) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/conditional/in_set.sql b/spark/src/test/resources/sql-tests/expressions/conditional/in_set.sql index 1cb0f248a6..a7b66ff4f4 100644 --- a/spark/src/test/resources/sql-tests/expressions/conditional/in_set.sql +++ b/spark/src/test/resources/sql-tests/expressions/conditional/in_set.sql @@ -16,7 +16,6 @@ -- under the License. -- ConfigMatrix: spark.sql.optimizer.inSetConversionThreshold=100,0 --- ConfigMatrix: parquet.enable.dictionary=false,true -- test in(set)/not in(set) statement diff --git a/spark/src/test/resources/sql-tests/expressions/conditional/is_not_null.sql b/spark/src/test/resources/sql-tests/expressions/conditional/is_not_null.sql index d27a0a8b99..1404feb9e7 100644 --- a/spark/src/test/resources/sql-tests/expressions/conditional/is_not_null.sql +++ b/spark/src/test/resources/sql-tests/expressions/conditional/is_not_null.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_is_not_null(i int, s string, d double) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/conditional/is_null.sql b/spark/src/test/resources/sql-tests/expressions/conditional/is_null.sql index c3a1c5a741..f8727c4607 100644 --- a/spark/src/test/resources/sql-tests/expressions/conditional/is_null.sql +++ b/spark/src/test/resources/sql-tests/expressions/conditional/is_null.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_is_null(i int, s string, d double) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/conditional/predicates.sql b/spark/src/test/resources/sql-tests/expressions/conditional/predicates.sql index 089bcc30fc..51d6573f2c 100644 --- a/spark/src/test/resources/sql-tests/expressions/conditional/predicates.sql +++ b/spark/src/test/resources/sql-tests/expressions/conditional/predicates.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_pred(a int, b int) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/datetime/date_add.sql b/spark/src/test/resources/sql-tests/expressions/datetime/date_add.sql index c516cff07a..86d973353e 100644 --- a/spark/src/test/resources/sql-tests/expressions/datetime/date_add.sql +++ b/spark/src/test/resources/sql-tests/expressions/datetime/date_add.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_date_add(d date, n int) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/datetime/date_diff.sql b/spark/src/test/resources/sql-tests/expressions/datetime/date_diff.sql index 50ba8923c3..a049ca6569 100644 --- a/spark/src/test/resources/sql-tests/expressions/datetime/date_diff.sql +++ b/spark/src/test/resources/sql-tests/expressions/datetime/date_diff.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_datediff(d1 date, d2 date) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/datetime/date_format.sql b/spark/src/test/resources/sql-tests/expressions/datetime/date_format.sql index 7f31e8f811..09333f44d3 100644 --- a/spark/src/test/resources/sql-tests/expressions/datetime/date_format.sql +++ b/spark/src/test/resources/sql-tests/expressions/datetime/date_format.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_date_format(ts timestamp) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/datetime/date_format_enabled.sql b/spark/src/test/resources/sql-tests/expressions/datetime/date_format_enabled.sql index b225f9f1b6..666008b450 100644 --- a/spark/src/test/resources/sql-tests/expressions/datetime/date_format_enabled.sql +++ b/spark/src/test/resources/sql-tests/expressions/datetime/date_format_enabled.sql @@ -19,7 +19,6 @@ -- Uses UTC timezone to ensure results match Spark -- Config: spark.comet.expression.DateFormatClass.allowIncompatible=true -- Config: spark.sql.session.timeZone=UTC --- ConfigMatrix: parquet.enable.dictionary=false,true statement CREATE TABLE test_date_format_enabled(ts timestamp) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/datetime/date_sub.sql b/spark/src/test/resources/sql-tests/expressions/datetime/date_sub.sql index 2dafdee89b..8d65c6ae4f 100644 --- a/spark/src/test/resources/sql-tests/expressions/datetime/date_sub.sql +++ b/spark/src/test/resources/sql-tests/expressions/datetime/date_sub.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_date_sub(d date, n int) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/datetime/datetime.sql b/spark/src/test/resources/sql-tests/expressions/datetime/datetime.sql index a00516cdb3..7fdaf51812 100644 --- a/spark/src/test/resources/sql-tests/expressions/datetime/datetime.sql +++ b/spark/src/test/resources/sql-tests/expressions/datetime/datetime.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - -- DatePart functions statement CREATE TABLE test_dt(col timestamp) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/datetime/from_unix_time.sql b/spark/src/test/resources/sql-tests/expressions/datetime/from_unix_time.sql index 5af2864593..a7b0960570 100644 --- a/spark/src/test/resources/sql-tests/expressions/datetime/from_unix_time.sql +++ b/spark/src/test/resources/sql-tests/expressions/datetime/from_unix_time.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_from_unix_time(t long) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/datetime/from_unix_time_enabled.sql b/spark/src/test/resources/sql-tests/expressions/datetime/from_unix_time_enabled.sql index 293a03fb5f..1821a6a01e 100644 --- a/spark/src/test/resources/sql-tests/expressions/datetime/from_unix_time_enabled.sql +++ b/spark/src/test/resources/sql-tests/expressions/datetime/from_unix_time_enabled.sql @@ -19,7 +19,6 @@ -- Uses UTC timezone to ensure results match Spark -- Config: spark.comet.expression.FromUnixTime.allowIncompatible=true -- Config: spark.sql.session.timeZone=UTC --- ConfigMatrix: parquet.enable.dictionary=false,true statement CREATE TABLE test_from_unix_time_enabled(t long) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/datetime/hour.sql b/spark/src/test/resources/sql-tests/expressions/datetime/hour.sql index 551dd60c06..31edd56200 100644 --- a/spark/src/test/resources/sql-tests/expressions/datetime/hour.sql +++ b/spark/src/test/resources/sql-tests/expressions/datetime/hour.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_hour(ts timestamp) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/datetime/last_day.sql b/spark/src/test/resources/sql-tests/expressions/datetime/last_day.sql index b1482f13a5..da78e6020c 100644 --- a/spark/src/test/resources/sql-tests/expressions/datetime/last_day.sql +++ b/spark/src/test/resources/sql-tests/expressions/datetime/last_day.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_last_day(d date) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/datetime/make_date.sql b/spark/src/test/resources/sql-tests/expressions/datetime/make_date.sql index 544f3cc960..00357662a0 100644 --- a/spark/src/test/resources/sql-tests/expressions/datetime/make_date.sql +++ b/spark/src/test/resources/sql-tests/expressions/datetime/make_date.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_make_date(year int, month int, day int) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/datetime/minute.sql b/spark/src/test/resources/sql-tests/expressions/datetime/minute.sql index 0b75084352..f25ee27bad 100644 --- a/spark/src/test/resources/sql-tests/expressions/datetime/minute.sql +++ b/spark/src/test/resources/sql-tests/expressions/datetime/minute.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_minute(ts timestamp) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/datetime/next_day.sql b/spark/src/test/resources/sql-tests/expressions/datetime/next_day.sql index 0effb36aa5..057c9daea6 100644 --- a/spark/src/test/resources/sql-tests/expressions/datetime/next_day.sql +++ b/spark/src/test/resources/sql-tests/expressions/datetime/next_day.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_next_day(d date) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/datetime/second.sql b/spark/src/test/resources/sql-tests/expressions/datetime/second.sql index 5db4e9e743..85dc6205ec 100644 --- a/spark/src/test/resources/sql-tests/expressions/datetime/second.sql +++ b/spark/src/test/resources/sql-tests/expressions/datetime/second.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_second(ts timestamp) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/datetime/trunc_date.sql b/spark/src/test/resources/sql-tests/expressions/datetime/trunc_date.sql index f1d19ea8a9..672281627c 100644 --- a/spark/src/test/resources/sql-tests/expressions/datetime/trunc_date.sql +++ b/spark/src/test/resources/sql-tests/expressions/datetime/trunc_date.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_trunc_date(d date) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/datetime/trunc_timestamp.sql b/spark/src/test/resources/sql-tests/expressions/datetime/trunc_timestamp.sql index 670c8fbaad..1a8bbef988 100644 --- a/spark/src/test/resources/sql-tests/expressions/datetime/trunc_timestamp.sql +++ b/spark/src/test/resources/sql-tests/expressions/datetime/trunc_timestamp.sql @@ -16,7 +16,6 @@ -- under the License. -- Config: spark.comet.expression.TruncTimestamp.allowIncompatible=true --- ConfigMatrix: parquet.enable.dictionary=false,true statement CREATE TABLE test_trunc_ts(ts timestamp) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/datetime/unix_date.sql b/spark/src/test/resources/sql-tests/expressions/datetime/unix_date.sql index 3e067dfd00..e568737de9 100644 --- a/spark/src/test/resources/sql-tests/expressions/datetime/unix_date.sql +++ b/spark/src/test/resources/sql-tests/expressions/datetime/unix_date.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_unix_date(d date) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/datetime/unix_timestamp.sql b/spark/src/test/resources/sql-tests/expressions/datetime/unix_timestamp.sql index fa4d9df07f..3d09626035 100644 --- a/spark/src/test/resources/sql-tests/expressions/datetime/unix_timestamp.sql +++ b/spark/src/test/resources/sql-tests/expressions/datetime/unix_timestamp.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_unix_ts(ts timestamp) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/decimal/decimal_ops.sql b/spark/src/test/resources/sql-tests/expressions/decimal/decimal_ops.sql index 3a856eb565..19b52c80d9 100644 --- a/spark/src/test/resources/sql-tests/expressions/decimal/decimal_ops.sql +++ b/spark/src/test/resources/sql-tests/expressions/decimal/decimal_ops.sql @@ -16,7 +16,6 @@ -- under the License. -- Config: spark.comet.expression.Cast.allowIncompatible=true --- ConfigMatrix: parquet.enable.dictionary=false,true -- Decimal arithmetic exercises CheckOverflow, MakeDecimal, UnscaledValue statement diff --git a/spark/src/test/resources/sql-tests/expressions/hash/crc32.sql b/spark/src/test/resources/sql-tests/expressions/hash/crc32.sql index 64b401c98c..2535d2e727 100644 --- a/spark/src/test/resources/sql-tests/expressions/hash/crc32.sql +++ b/spark/src/test/resources/sql-tests/expressions/hash/crc32.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - -- crc32 function statement CREATE TABLE test(col string, a int, b float) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/hash/hash.sql b/spark/src/test/resources/sql-tests/expressions/hash/hash.sql index 35031ea7e4..42e75ecfd8 100644 --- a/spark/src/test/resources/sql-tests/expressions/hash/hash.sql +++ b/spark/src/test/resources/sql-tests/expressions/hash/hash.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - -- hash functions statement CREATE TABLE test(col string, a int, b float) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/map/get_map_value.sql b/spark/src/test/resources/sql-tests/expressions/map/get_map_value.sql index f97ffe8729..4b497177ce 100644 --- a/spark/src/test/resources/sql-tests/expressions/map/get_map_value.sql +++ b/spark/src/test/resources/sql-tests/expressions/map/get_map_value.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_map(m map) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/map/map_contains_key.sql b/spark/src/test/resources/sql-tests/expressions/map/map_contains_key.sql index a70f4a1bde..253398c0c4 100644 --- a/spark/src/test/resources/sql-tests/expressions/map/map_contains_key.sql +++ b/spark/src/test/resources/sql-tests/expressions/map/map_contains_key.sql @@ -16,7 +16,6 @@ -- under the License. -- Config: spark.comet.expression.ArrayContains.allowIncompatible=true --- ConfigMatrix: parquet.enable.dictionary=false,true -- TODO: replace map_from_arrays with map whenever map is supported in Comet diff --git a/spark/src/test/resources/sql-tests/expressions/map/map_entries.sql b/spark/src/test/resources/sql-tests/expressions/map/map_entries.sql index b89fdec060..91720cc2ab 100644 --- a/spark/src/test/resources/sql-tests/expressions/map/map_entries.sql +++ b/spark/src/test/resources/sql-tests/expressions/map/map_entries.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_map_entries(m map) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/map/map_from_arrays.sql b/spark/src/test/resources/sql-tests/expressions/map/map_from_arrays.sql index 3016eb5ff6..178c07f432 100644 --- a/spark/src/test/resources/sql-tests/expressions/map/map_from_arrays.sql +++ b/spark/src/test/resources/sql-tests/expressions/map/map_from_arrays.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_map_from_arrays(k array, v array) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/map/map_from_entries.sql b/spark/src/test/resources/sql-tests/expressions/map/map_from_entries.sql index 0d5f81f6d5..0beffcc292 100644 --- a/spark/src/test/resources/sql-tests/expressions/map/map_from_entries.sql +++ b/spark/src/test/resources/sql-tests/expressions/map/map_from_entries.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_map_from_entries(entries array>) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/map/map_keys.sql b/spark/src/test/resources/sql-tests/expressions/map/map_keys.sql index a6591ce800..89f2902f81 100644 --- a/spark/src/test/resources/sql-tests/expressions/map/map_keys.sql +++ b/spark/src/test/resources/sql-tests/expressions/map/map_keys.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_map_keys(m map) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/map/map_values.sql b/spark/src/test/resources/sql-tests/expressions/map/map_values.sql index 717e614e0d..480844358b 100644 --- a/spark/src/test/resources/sql-tests/expressions/map/map_values.sql +++ b/spark/src/test/resources/sql-tests/expressions/map/map_values.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_map_values(m map) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/math/abs.sql b/spark/src/test/resources/sql-tests/expressions/math/abs.sql index c51270ae35..5e811e7ea5 100644 --- a/spark/src/test/resources/sql-tests/expressions/math/abs.sql +++ b/spark/src/test/resources/sql-tests/expressions/math/abs.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_abs(i int, l long, f float, d double) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/math/acos.sql b/spark/src/test/resources/sql-tests/expressions/math/acos.sql index 8b8e3c2565..04488ae475 100644 --- a/spark/src/test/resources/sql-tests/expressions/math/acos.sql +++ b/spark/src/test/resources/sql-tests/expressions/math/acos.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_acos(d double) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/math/arithmetic.sql b/spark/src/test/resources/sql-tests/expressions/math/arithmetic.sql index de611ddfc7..969ddf1851 100644 --- a/spark/src/test/resources/sql-tests/expressions/math/arithmetic.sql +++ b/spark/src/test/resources/sql-tests/expressions/math/arithmetic.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - -- negative statement CREATE TABLE test_neg(col1 int) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/math/asin.sql b/spark/src/test/resources/sql-tests/expressions/math/asin.sql index 5a59ed944d..887f391188 100644 --- a/spark/src/test/resources/sql-tests/expressions/math/asin.sql +++ b/spark/src/test/resources/sql-tests/expressions/math/asin.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_asin(d double) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/math/atan.sql b/spark/src/test/resources/sql-tests/expressions/math/atan.sql index b9037c7775..2b09b483cc 100644 --- a/spark/src/test/resources/sql-tests/expressions/math/atan.sql +++ b/spark/src/test/resources/sql-tests/expressions/math/atan.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_atan(d double) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/math/atan2.sql b/spark/src/test/resources/sql-tests/expressions/math/atan2.sql index 7a912930b8..a276e7f741 100644 --- a/spark/src/test/resources/sql-tests/expressions/math/atan2.sql +++ b/spark/src/test/resources/sql-tests/expressions/math/atan2.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_atan2(y double, x double) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/math/ceil.sql b/spark/src/test/resources/sql-tests/expressions/math/ceil.sql index c11c42bedb..84adf3c9af 100644 --- a/spark/src/test/resources/sql-tests/expressions/math/ceil.sql +++ b/spark/src/test/resources/sql-tests/expressions/math/ceil.sql @@ -16,7 +16,6 @@ -- under the License. -- Config: spark.comet.expression.Ceil.allowIncompatible=true --- ConfigMatrix: parquet.enable.dictionary=false,true statement CREATE TABLE test_ceil(f float, d double) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/math/cos.sql b/spark/src/test/resources/sql-tests/expressions/math/cos.sql index 7ebc24bb99..e058ff9e4d 100644 --- a/spark/src/test/resources/sql-tests/expressions/math/cos.sql +++ b/spark/src/test/resources/sql-tests/expressions/math/cos.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_cos(d double) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/math/cosh.sql b/spark/src/test/resources/sql-tests/expressions/math/cosh.sql index a751960362..703ba2d5cc 100644 --- a/spark/src/test/resources/sql-tests/expressions/math/cosh.sql +++ b/spark/src/test/resources/sql-tests/expressions/math/cosh.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_cosh(d double) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/math/cot.sql b/spark/src/test/resources/sql-tests/expressions/math/cot.sql index fc6193f8f5..1f828f91b6 100644 --- a/spark/src/test/resources/sql-tests/expressions/math/cot.sql +++ b/spark/src/test/resources/sql-tests/expressions/math/cot.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_cot(d double) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/math/exp.sql b/spark/src/test/resources/sql-tests/expressions/math/exp.sql index 243aefba96..70f015857c 100644 --- a/spark/src/test/resources/sql-tests/expressions/math/exp.sql +++ b/spark/src/test/resources/sql-tests/expressions/math/exp.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_exp(d double) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/math/expm1.sql b/spark/src/test/resources/sql-tests/expressions/math/expm1.sql index 2eaba2b739..9416a10c87 100644 --- a/spark/src/test/resources/sql-tests/expressions/math/expm1.sql +++ b/spark/src/test/resources/sql-tests/expressions/math/expm1.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_expm1(d double) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/math/floor.sql b/spark/src/test/resources/sql-tests/expressions/math/floor.sql index 62fa2a4045..f9aae6e07e 100644 --- a/spark/src/test/resources/sql-tests/expressions/math/floor.sql +++ b/spark/src/test/resources/sql-tests/expressions/math/floor.sql @@ -16,7 +16,6 @@ -- under the License. -- Config: spark.comet.expression.Floor.allowIncompatible=true --- ConfigMatrix: parquet.enable.dictionary=false,true statement CREATE TABLE test_floor(f float, d double) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/math/isnan.sql b/spark/src/test/resources/sql-tests/expressions/math/isnan.sql index 7b7914c3cb..1422a6bf90 100644 --- a/spark/src/test/resources/sql-tests/expressions/math/isnan.sql +++ b/spark/src/test/resources/sql-tests/expressions/math/isnan.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_isnan(f float, d double) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/math/log.sql b/spark/src/test/resources/sql-tests/expressions/math/log.sql index 8ee5282cd6..a37213860b 100644 --- a/spark/src/test/resources/sql-tests/expressions/math/log.sql +++ b/spark/src/test/resources/sql-tests/expressions/math/log.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_log(d double) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/math/log10.sql b/spark/src/test/resources/sql-tests/expressions/math/log10.sql index 77019c9b66..4855451c81 100644 --- a/spark/src/test/resources/sql-tests/expressions/math/log10.sql +++ b/spark/src/test/resources/sql-tests/expressions/math/log10.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_log10(d double) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/math/log2.sql b/spark/src/test/resources/sql-tests/expressions/math/log2.sql index 01ff6f75b5..d00efbd5e2 100644 --- a/spark/src/test/resources/sql-tests/expressions/math/log2.sql +++ b/spark/src/test/resources/sql-tests/expressions/math/log2.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_log2(d double) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/math/pow.sql b/spark/src/test/resources/sql-tests/expressions/math/pow.sql index 82b1155303..78e4c3e6c4 100644 --- a/spark/src/test/resources/sql-tests/expressions/math/pow.sql +++ b/spark/src/test/resources/sql-tests/expressions/math/pow.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_pow(base double, exp double) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/math/round.sql b/spark/src/test/resources/sql-tests/expressions/math/round.sql index 617968eb35..7a821b8027 100644 --- a/spark/src/test/resources/sql-tests/expressions/math/round.sql +++ b/spark/src/test/resources/sql-tests/expressions/math/round.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_round(d double, i int) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/math/signum.sql b/spark/src/test/resources/sql-tests/expressions/math/signum.sql index 6dd2f2209a..04db8c3461 100644 --- a/spark/src/test/resources/sql-tests/expressions/math/signum.sql +++ b/spark/src/test/resources/sql-tests/expressions/math/signum.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_signum(d double) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/math/sin.sql b/spark/src/test/resources/sql-tests/expressions/math/sin.sql index dca3ad77b4..ac57bbeca3 100644 --- a/spark/src/test/resources/sql-tests/expressions/math/sin.sql +++ b/spark/src/test/resources/sql-tests/expressions/math/sin.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_sin(d double) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/math/sinh.sql b/spark/src/test/resources/sql-tests/expressions/math/sinh.sql index 432c58c583..2c9ea533d4 100644 --- a/spark/src/test/resources/sql-tests/expressions/math/sinh.sql +++ b/spark/src/test/resources/sql-tests/expressions/math/sinh.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_sinh(d double) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/math/sqrt.sql b/spark/src/test/resources/sql-tests/expressions/math/sqrt.sql index ec3c066eb9..10686929a1 100644 --- a/spark/src/test/resources/sql-tests/expressions/math/sqrt.sql +++ b/spark/src/test/resources/sql-tests/expressions/math/sqrt.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_sqrt(d double) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/math/tan.sql b/spark/src/test/resources/sql-tests/expressions/math/tan.sql index 9496844804..28c9fe32b6 100644 --- a/spark/src/test/resources/sql-tests/expressions/math/tan.sql +++ b/spark/src/test/resources/sql-tests/expressions/math/tan.sql @@ -15,7 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true -- Config: spark.comet.expression.Tan.allowIncompatible=true statement diff --git a/spark/src/test/resources/sql-tests/expressions/math/tanh.sql b/spark/src/test/resources/sql-tests/expressions/math/tanh.sql index 9d70202776..541c96e385 100644 --- a/spark/src/test/resources/sql-tests/expressions/math/tanh.sql +++ b/spark/src/test/resources/sql-tests/expressions/math/tanh.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_tanh(d double) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/ascii.sql b/spark/src/test/resources/sql-tests/expressions/string/ascii.sql index bca7b77932..25b84d8fcb 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/ascii.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/ascii.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_ascii(s string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/bit_length.sql b/spark/src/test/resources/sql-tests/expressions/string/bit_length.sql index 83044267de..34565d6fe3 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/bit_length.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/bit_length.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_bit_length(s string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/chr.sql b/spark/src/test/resources/sql-tests/expressions/string/chr.sql index bce93d75dd..13991cf543 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/chr.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/chr.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_chr(i long) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/concat.sql b/spark/src/test/resources/sql-tests/expressions/string/concat.sql index a1022f73d0..3fa2bb65d0 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/concat.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/concat.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_concat(a string, b string, c string, d string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/concat_ws.sql b/spark/src/test/resources/sql-tests/expressions/string/concat_ws.sql index 81ccfb0f36..3de4383e86 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/concat_ws.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/concat_ws.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_concat_ws(a string, b string, c string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/contains.sql b/spark/src/test/resources/sql-tests/expressions/string/contains.sql index 32a9bca01e..bd3711d934 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/contains.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/contains.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_contains(s string, sub string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/ends_with.sql b/spark/src/test/resources/sql-tests/expressions/string/ends_with.sql index 957cb93c12..9407c50ef3 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/ends_with.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/ends_with.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_ends_with(s string, suffix string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/hex.sql b/spark/src/test/resources/sql-tests/expressions/string/hex.sql index d0be03372d..a8cb5f94f8 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/hex.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/hex.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_hex(i int, l long, s string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/init_cap.sql b/spark/src/test/resources/sql-tests/expressions/string/init_cap.sql index 90f5afc8f4..e0df1a61a9 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/init_cap.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/init_cap.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_initcap(s string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/init_cap_enabled.sql b/spark/src/test/resources/sql-tests/expressions/string/init_cap_enabled.sql index 03c9de8817..4f2c364aab 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/init_cap_enabled.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/init_cap_enabled.sql @@ -17,7 +17,6 @@ -- Test initcap() with allowIncompatible enabled (happy path) -- Config: spark.comet.expression.InitCap.allowIncompatible=true --- ConfigMatrix: parquet.enable.dictionary=false,true statement CREATE TABLE test_initcap_enabled(s string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/left.sql b/spark/src/test/resources/sql-tests/expressions/string/left.sql index 31372f0a42..44af06d1dc 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/left.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/left.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_str_left(s string, n int) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/length.sql b/spark/src/test/resources/sql-tests/expressions/string/length.sql index c09fbe80c1..1e1e8ccc7a 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/length.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/length.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_length(s string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/like.sql b/spark/src/test/resources/sql-tests/expressions/string/like.sql index 5f56881d3c..9173b6abc1 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/like.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/like.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_like(s string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/lower.sql b/spark/src/test/resources/sql-tests/expressions/string/lower.sql index f2f8173c39..7233251820 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/lower.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/lower.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_lower(s string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/lower_enabled.sql b/spark/src/test/resources/sql-tests/expressions/string/lower_enabled.sql index b521d87f91..0461fce735 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/lower_enabled.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/lower_enabled.sql @@ -17,7 +17,6 @@ -- Test lower() with case conversion enabled (happy path) -- Config: spark.comet.caseConversion.enabled=true --- ConfigMatrix: parquet.enable.dictionary=false,true statement CREATE TABLE test_lower_enabled(s string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/luhn_check.sql b/spark/src/test/resources/sql-tests/expressions/string/luhn_check.sql index ea10808467..dbc6970407 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/luhn_check.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/luhn_check.sql @@ -16,7 +16,6 @@ -- under the License. -- MinSparkVersion: 3.5 --- ConfigMatrix: parquet.enable.dictionary=false,true statement CREATE TABLE test_luhn(s string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/octet_length.sql b/spark/src/test/resources/sql-tests/expressions/string/octet_length.sql index 2e006c688f..095d3e30a2 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/octet_length.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/octet_length.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_octet_length(s string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/regexp_replace.sql b/spark/src/test/resources/sql-tests/expressions/string/regexp_replace.sql index acaa238c00..967674a894 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/regexp_replace.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/regexp_replace.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_regexp_replace(s string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/regexp_replace_enabled.sql b/spark/src/test/resources/sql-tests/expressions/string/regexp_replace_enabled.sql index bf8a544515..97b4917c33 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/regexp_replace_enabled.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/regexp_replace_enabled.sql @@ -17,7 +17,6 @@ -- Test regexp_replace() with regexp allowIncompatible enabled (happy path) -- Config: spark.comet.expression.regexp.allowIncompatible=true --- ConfigMatrix: parquet.enable.dictionary=false,true statement CREATE TABLE test_regexp_replace_enabled(s string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/reverse.sql b/spark/src/test/resources/sql-tests/expressions/string/reverse.sql index 766b097932..88ed20824f 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/reverse.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/reverse.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_reverse(s string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/right.sql b/spark/src/test/resources/sql-tests/expressions/string/right.sql index 4fb9763bcc..0af2d562f6 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/right.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/right.sql @@ -19,9 +19,6 @@ -- If(IsNull(str), null, If(len <= 0, "", Substring(str, -len, len))) -- before Comet sees it. CometRight handles the serde, but the optimizer -- may replace it first. We use spark_answer_only to verify correctness. - --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_str_right(s string, n int) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/rlike.sql b/spark/src/test/resources/sql-tests/expressions/string/rlike.sql index 7c95211df9..97350918ba 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/rlike.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/rlike.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_rlike(s string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/rlike_enabled.sql b/spark/src/test/resources/sql-tests/expressions/string/rlike_enabled.sql index 1de215a770..5b2bd05fb3 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/rlike_enabled.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/rlike_enabled.sql @@ -17,7 +17,6 @@ -- Test RLIKE with regexp allowIncompatible enabled (happy path) -- Config: spark.comet.expression.regexp.allowIncompatible=true --- ConfigMatrix: parquet.enable.dictionary=false,true statement CREATE TABLE test_rlike_enabled(s string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/starts_with.sql b/spark/src/test/resources/sql-tests/expressions/string/starts_with.sql index eeea2b856d..292d10e83f 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/starts_with.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/starts_with.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_starts_with(s string, prefix string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/string_instr.sql b/spark/src/test/resources/sql-tests/expressions/string/string_instr.sql index 92298a143b..8f8b52ed49 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/string_instr.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/string_instr.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_instr(s string, sub string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/string_lpad.sql b/spark/src/test/resources/sql-tests/expressions/string/string_lpad.sql index 358be456b1..83d0ceaebb 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/string_lpad.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/string_lpad.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_lpad(s string, len int, pad string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/string_repeat.sql b/spark/src/test/resources/sql-tests/expressions/string/string_repeat.sql index 32f08db101..f645e7357b 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/string_repeat.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/string_repeat.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_repeat(s string, n int) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/string_replace.sql b/spark/src/test/resources/sql-tests/expressions/string/string_replace.sql index d1c03d18e6..c9dddebd63 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/string_replace.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/string_replace.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_str_replace(s string, search string, replace string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/string_rpad.sql b/spark/src/test/resources/sql-tests/expressions/string/string_rpad.sql index c2f526a88f..48d3fb6cec 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/string_rpad.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/string_rpad.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_rpad(s string, len int, pad string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/string_space.sql b/spark/src/test/resources/sql-tests/expressions/string/string_space.sql index 4b826fbe3d..45b9d8e594 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/string_space.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/string_space.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_space(n int) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/string_translate.sql b/spark/src/test/resources/sql-tests/expressions/string/string_translate.sql index 01f5426dd7..88bd1aa935 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/string_translate.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/string_translate.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_translate(s string, from_str string, to_str string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/string_trim.sql b/spark/src/test/resources/sql-tests/expressions/string/string_trim.sql index 9822643ef1..0828c8954b 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/string_trim.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/string_trim.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_trim(s string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/substring.sql b/spark/src/test/resources/sql-tests/expressions/string/substring.sql index 42b99f1900..4e6217fd5f 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/substring.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/substring.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_substring(s string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/unhex.sql b/spark/src/test/resources/sql-tests/expressions/string/unhex.sql index 2b20cf489f..0f31a880b3 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/unhex.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/unhex.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_unhex(s string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/upper.sql b/spark/src/test/resources/sql-tests/expressions/string/upper.sql index 6582a299ef..6a15efe59b 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/upper.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/upper.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_upper(s string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/string/upper_enabled.sql b/spark/src/test/resources/sql-tests/expressions/string/upper_enabled.sql index b8e4dc128d..95ad265229 100644 --- a/spark/src/test/resources/sql-tests/expressions/string/upper_enabled.sql +++ b/spark/src/test/resources/sql-tests/expressions/string/upper_enabled.sql @@ -17,7 +17,6 @@ -- Test upper() with case conversion enabled (happy path) -- Config: spark.comet.caseConversion.enabled=true --- ConfigMatrix: parquet.enable.dictionary=false,true statement CREATE TABLE test_upper_enabled(s string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/struct/create_named_struct.sql b/spark/src/test/resources/sql-tests/expressions/struct/create_named_struct.sql index d188aed7bb..a3ad834c3f 100644 --- a/spark/src/test/resources/sql-tests/expressions/struct/create_named_struct.sql +++ b/spark/src/test/resources/sql-tests/expressions/struct/create_named_struct.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_named_struct(a int, b string, c double) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/struct/get_struct_field.sql b/spark/src/test/resources/sql-tests/expressions/struct/get_struct_field.sql index cf569ae121..c5d9e64a63 100644 --- a/spark/src/test/resources/sql-tests/expressions/struct/get_struct_field.sql +++ b/spark/src/test/resources/sql-tests/expressions/struct/get_struct_field.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_struct(s struct) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/struct/json_to_structs.sql b/spark/src/test/resources/sql-tests/expressions/struct/json_to_structs.sql index a0ae20b655..ca8c0af2ce 100644 --- a/spark/src/test/resources/sql-tests/expressions/struct/json_to_structs.sql +++ b/spark/src/test/resources/sql-tests/expressions/struct/json_to_structs.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_from_json(j string) USING parquet diff --git a/spark/src/test/resources/sql-tests/expressions/struct/structs_to_json.sql b/spark/src/test/resources/sql-tests/expressions/struct/structs_to_json.sql index 7f2310f147..351a7009d0 100644 --- a/spark/src/test/resources/sql-tests/expressions/struct/structs_to_json.sql +++ b/spark/src/test/resources/sql-tests/expressions/struct/structs_to_json.sql @@ -15,8 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- ConfigMatrix: parquet.enable.dictionary=false,true - statement CREATE TABLE test_to_json(a int, b string) USING parquet