tan(-0.0) produces incorrect result

[andygrove]

Describe the bug

While working on #1896 I discovered that tan(-0.0) produces an incorrect result.

3.141592653589793 was not less than 1.0E-6 actual answer -3.141592653589793 not within 1.0E-6 of correct answer 0.0

Steps to reproduce

Uncomment the -0.0 in the test data in #1896 and run the tests

Expected behavior

No response

Additional context

No response

[andygrove]

The Tan expression is now marked as Incompatible in Comet, which means it falls back to Spark by default and only runs natively when spark.comet.expr.allowIncompatible=true is explicitly set. Since default behavior is now correct (via Spark fallback), this is no longer a bug. Relabeling as an enhancement to track fixing the tan(-0.0) edge case in the native implementation in the future.

[kazuyukitanimura]

Looks what is actually wrong is atan2 #3849
I plan to update the description of this issue later

[kazuyukitanimura]

I ended up fixing both tan and atan2 in #3849