[C++] deprecated-declarations warnings in bundled google-cloud-cpp

[kou]

Describe the bug, including details regarding any error messages, version, and platform.

ARM64 macOS GLib & Ruby https://github.com/apache/arrow/actions/runs/31872547761/job/94983313575?pr=50799 :

[382/662] Building CXX object src/arrow/CMakeFiles/arrow_filesystem.dir/filesystem/gcsfs.cc.o
FAILED: [code=1] src/arrow/CMakeFiles/arrow_filesystem.dir/filesystem/gcsfs.cc.o 
/opt/homebrew/bin/ccache /usr/bin/c++ -DARROW_HAVE_NEON -DARROW_WITH_TIMING_TESTS -DGOOGLE_CLOUD_CPP_HAVE_OPENSSL -I/Users/runner/work/arrow/arrow/build/cpp/src -I/Users/runner/work/arrow/arrow/cpp/src -isystem /Users/runner/work/arrow/arrow/build/cpp/_deps/google_cloud_cpp-src -isystem /opt/homebrew/include -isystem /Users/runner/work/arrow/arrow/build/cpp/_deps/google_cloud_cpp-build -isystem /Users/runner/work/arrow/arrow/build/cpp/_deps/opentelemetry_cpp-src/api/include -isystem /opt/homebrew/opt/openssl@3/include -isystem /Users/runner/work/arrow/arrow/build/cpp/_deps/nlohmann_json-src/include -isystem /Users/runner/work/arrow/arrow/cpp/thirdparty/hadoop/include -fno-aligned-new  -Qunused-arguments -fcolor-diagnostics  -Wall -Wextra -Wdocumentation -DARROW_WARN_DOCUMENTATION -Wshorten-64-to-32 -Wno-missing-braces -Wno-unused-parameter -Wno-constant-logical-operand -Wno-return-stack-address -Wdate-time -Wno-unknown-warning-option -Wno-pass-failed -march=armv8-a  -g -Werror -O0 -ggdb -g1 -std=c++20 -arch arm64 -fPIC -Wno-documentation -Wno-documentation-deprecated-sync -MD -MT src/arrow/CMakeFiles/arrow_filesystem.dir/filesystem/gcsfs.cc.o -MF src/arrow/CMakeFiles/arrow_filesystem.dir/filesystem/gcsfs.cc.o.d -o src/arrow/CMakeFiles/arrow_filesystem.dir/filesystem/gcsfs.cc.o -c /Users/runner/work/arrow/arrow/cpp/src/arrow/filesystem/gcsfs.cc
In file included from /Users/runner/work/arrow/arrow/cpp/src/arrow/filesystem/gcsfs.cc:23:
In file included from /Users/runner/work/arrow/arrow/build/cpp/_deps/google_cloud_cpp-src/google/cloud/storage/client.h:24:
In file included from /Users/runner/work/arrow/arrow/build/cpp/_deps/google_cloud_cpp-src/google/cloud/storage/list_buckets_extended_reader.h:20:
In file included from /Users/runner/work/arrow/arrow/build/cpp/_deps/google_cloud_cpp-src/google/cloud/internal/pagination_range.h:21:
/Users/runner/work/arrow/arrow/build/cpp/_deps/google_cloud_cpp-src/google/cloud/stream_range.h:208:11: error: 'visit<UnpackVariant, std::variant<google::cloud::Status, google::cloud::storage::ObjectMetadata>>' is deprecated [-Werror,-Wdeprecated-declarations]
  208 |     absl::visit(UnpackVariant{*this}, std::move(v));
      |           ^
/Users/runner/work/arrow/arrow/build/cpp/_deps/google_cloud_cpp-src/google/cloud/stream_range.h:245:5: note: in instantiation of member function 'google::cloud::StreamRange<google::cloud::storage::ObjectMetadata>::Next' requested here
  245 |     Next();
      |     ^
/Users/runner/work/arrow/arrow/build/cpp/_deps/google_cloud_cpp-src/google/cloud/stream_range.h:271:10: note: in instantiation of member function 'google::cloud::StreamRange<google::cloud::storage::ObjectMetadata>::StreamRange' requested here
  271 |   return StreamRange<T>{std::move(options), std::move(reader)};
      |          ^
/Users/runner/work/arrow/arrow/build/cpp/_deps/google_cloud_cpp-src/google/cloud/internal/pagination_range.h:239:10: note: in instantiation of function template specialization 'google::cloud::internal::MakeStreamRange<google::cloud::storage::ObjectMetadata>' requested here
  239 |   return MakeStreamRange<ValueType>(std::move(options),
      |          ^
/Users/runner/work/arrow/arrow/build/cpp/_deps/google_cloud_cpp-src/google/cloud/internal/pagination_range.h:254:10: note: in instantiation of function template specialization 'google::cloud::internal::MakePaginationRange<google::cloud::StreamRange<google::cloud::storage::ObjectMetadata>, google::cloud::storage::internal::ListObjectsRequest, (lambda at /Users/runner/work/arrow/arrow/build/cpp/_deps/google_cloud_cpp-src/google/cloud/internal/pagination_range.h:250:18), (lambda at /Users/runner/work/arrow/arrow/build/cpp/_deps/google_cloud_cpp-src/google/cloud/storage/client.h:1115:9), 0>' requested here
  254 |   return MakePaginationRange<Range>(SaveCurrentOptions(), std::move(request),
      |          ^
/Users/runner/work/arrow/arrow/build/cpp/_deps/google_cloud_cpp-src/google/cloud/storage/client.h:1110:37: note: in instantiation of function template specialization 'google::cloud::internal::MakePaginationRange<google::cloud::StreamRange<google::cloud::storage::ObjectMetadata>, google::cloud::storage::internal::ListObjectsRequest, (lambda at /Users/runner/work/arrow/arrow/build/cpp/_deps/google_cloud_cpp-src/google/cloud/storage/client.h:1112:9), (lambda at /Users/runner/work/arrow/arrow/build/cpp/_deps/google_cloud_cpp-src/google/cloud/storage/client.h:1115:9), 0>' requested here
 1110 |     return google::cloud::internal::MakePaginationRange<ListObjectsReader>(
      |                                     ^
/Users/runner/work/arrow/arrow/cpp/src/arrow/filesystem/gcsfs.cc:356:32: note: in instantiation of function template specialization 'google::cloud::storage::Client::ListObjects<google::cloud::storage::Prefix>' requested here
  356 |     auto list_result = client_.ListObjects(path.bucket, gcs::Prefix(canonical));
      |                                ^
/opt/homebrew/include/absl/types/variant.h:98:3: note: 'visit<UnpackVariant, std::variant<google::cloud::Status, google::cloud::storage::ObjectMetadata>>' has been explicitly marked deprecated here
   98 | [[deprecated]] constexpr decltype(std::visit(std::declval<Args>()...)) visit(
      |   ^
1 error generated.

Should we update bundled google-cloud-cpp?

Component(s)

C++

[KHARSHAVARDHAN-eng]

@kou ,

I’d be interested in investigating this issue. The failure appears to come from the bundled google-cloud-cpp using the deprecated absl::visit API, which becomes an error under the current warning settings on ARM64 macOS.

I’d like to trace the bundled dependency version and the Arrow build configuration to determine whether updating google-cloud-cpp is the appropriate fix or whether the warning should be handled differently.

Would a maintainer be okay with me investigating this and submitting a PR with a regression/CI validation where appropriate?

[kou]

@KHARSHAVARDHAN-eng Please stop posting auto generated comments.
Do you remember #50783 (comment) ?

If you don't stop it, I'll hide your auto generated comments next time.