From 593b77aadd62ff16de7861881073ba9227f1d071 Mon Sep 17 00:00:00 2001 From: Andy Grove Date: Sun, 1 Nov 2026 13:33:39 -0700 Subject: [PATCH] ci: upload JVM crash files when the RC Binaries job fails A crashed test JVM leaves hs_err_pid.log in the module directory and its crash banner in surefire's .dumpstream files, and the job uploaded neither, so a fork crash could not be diagnosed from CI. --- .github/workflows/rc.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.github/workflows/rc.yml b/.github/workflows/rc.yml index bc4ed5d5e6..7f061fc3e4 100644 --- a/.github/workflows/rc.yml +++ b/.github/workflows/rc.yml @@ -403,6 +403,18 @@ jobs: - name: Build bundled JAR and docs run: | ci/scripts/jni_full_build.sh . jni binaries + # A test JVM that crashes leaves its HotSpot error log in the module + # directory and the crash banner it printed in surefire's dump files. + - name: Upload JVM crash files + if: failure() + uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2 + with: + name: binaries-jvm-crash-files + path: | + **/hs_err_pid*.log + **/target/surefire-reports/*.dump + **/target/surefire-reports/*.dumpstream + if-no-files-found: ignore - name: Prepare docs run: | mkdir -p docs