Skip to content

Bump google-cloud-aiplatform to force upgrade of litellm#66632

Open
jscheffl wants to merge 1 commit into
apache:mainfrom
jscheffl:bugfix/bump-google-cloud-aiplatform-for-litellm
Open

Bump google-cloud-aiplatform to force upgrade of litellm#66632
jscheffl wants to merge 1 commit into
apache:mainfrom
jscheffl:bugfix/bump-google-cloud-aiplatform-for-litellm

Conversation

@jscheffl
Copy link
Copy Markdown
Contributor

@jscheffl jscheffl commented May 9, 2026

Sine a while we carry the transitive litellm vulnerability in Dependabot. This PR attempts to bump google-cloud-aiplatform in order to ensure a non vulnerable transitive dependency is enforced.

Not sure why but as a trade we need to lower the click dependency from >=8.3.0 to >=8.1.8 - is this acceptable as a trade?

This refers to to upgrade in click by @eladkal in #61613

Let's see if CI turns green...


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@jscheffl jscheffl added the full tests needed We need to run full set of tests for this PR to merge label May 9, 2026
@jscheffl jscheffl requested a review from potiuk as a code owner May 9, 2026 18:34
@jscheffl jscheffl added the all versions If set, the CI build will be forced to use all versions of Python/K8S/DBs label May 9, 2026
@boring-cyborg boring-cyborg Bot added area:dev-tools area:providers backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch kind:documentation provider:google Google (including GCP) related issues labels May 9, 2026
@jscheffl jscheffl force-pushed the bugfix/bump-google-cloud-aiplatform-for-litellm branch from c5cc4c7 to f0074af Compare May 9, 2026 20:04
@potiuk
Copy link
Copy Markdown
Member

potiuk commented May 9, 2026

It is pretty strange with 8.1.8 though.. Let me take a look

@jscheffl
Copy link
Copy Markdown
Contributor Author

jscheffl commented May 9, 2026

It is pretty strange with 8.1.8 though.. Let me take a look

It is litellm which exactly pins this version :-(
image

--> https://github.com/BerriAI/litellm/blob/v1.83.7-stable/pyproject.toml#L32

mhm... on un-released "main" they have releaxed meanwhile... https://github.com/BerriAI/litellm/blob/litellm_internal_staging/pyproject.toml#L24 (and pin is even still existing on RC1 of 1.84)

@jscheffl jscheffl force-pushed the bugfix/bump-google-cloud-aiplatform-for-litellm branch 3 times, most recently from 15858cd to 561815e Compare May 10, 2026 17:17
Copy link
Copy Markdown
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since they are going to relax soon - It looks fine :)

@jscheffl jscheffl force-pushed the bugfix/bump-google-cloud-aiplatform-for-litellm branch 3 times, most recently from 61eea23 to 13f5b56 Compare May 11, 2026 22:40
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

uv.lock on main just moved via #58929 ("Add support for influx3 in influxdb provider"), commit 8e51e68 and this PR currently conflicts.

Quickest fix:

git fetch upstream main && git rebase upstream/main
rm uv.lock && uv lock
git add uv.lock && git rebase --continue
git push --force-with-lease

Automated nudge — ignore if you're not ready to rebase. This comment is updated in place on future uv.lock bumps.

@jscheffl jscheffl force-pushed the bugfix/bump-google-cloud-aiplatform-for-litellm branch 4 times, most recently from 878724e to b696744 Compare May 14, 2026 18:27
@jscheffl
Copy link
Copy Markdown
Contributor Author

Mhm, considering that litellm with less restrictive pinning of click has been released 13h ago...
image
...and we cut a providers release Monday/Tuesday I'd suggest we wait a moment until the cooldown allows to get the newest and then we do not need to downgrade click with a lot less side effecs. Will park the PR until then.

  • Wait until Cooldown of 4 days is reached on 2026-05-18 and revert click downgrade

@jscheffl jscheffl force-pushed the bugfix/bump-google-cloud-aiplatform-for-litellm branch from b696744 to 95d0de4 Compare May 17, 2026 19:50
@jscheffl
Copy link
Copy Markdown
Contributor Author

Note: PR will fail in UV needs upgrading until cooldown is reached in ~24h Then needs a rebase and UV to be updated here.

@jscheffl
Copy link
Copy Markdown
Contributor Author

Still not working as the litellm version that is relaxing click dependency is not in the allowed range for google-cloud-aiplatform which is actually rendering the transitive dependency. Opened bug googleapis/python-aiplatform#6827 and PR googleapis/python-aiplatform#6828 in hoping the upper bound to litellm is relaxed.

@jscheffl jscheffl force-pushed the bugfix/bump-google-cloud-aiplatform-for-litellm branch from 95d0de4 to 64d24a7 Compare May 23, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

all versions If set, the CI build will be forced to use all versions of Python/K8S/DBs area:dev-tools area:providers backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch full tests needed We need to run full set of tests for this PR to merge kind:documentation provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants