Investigate failure condition when using table.bulk.max.tablets property

[ddanielr]

Describe the bug
On initial investigation any bulk imports that hit the table.bulk.max.tablets property seem to get into a isReady() run loop that never completes.

Versions (OS, Maven, Java, and others, as appropriate):

• Affected version(s) of this project: [e.g. 1.10.0] 2.1.4

Expected behavior
Hitting this property during a bulk import should not result in a infinite fate operation loop.

[kevinrr888]

Do you have a specific example or setup that demonstrates this issue? I wrote a test in 2.1.4 to check this and it failed as expected: error with the message ...attempted to import to 6 tablets. Max tablets allowed set to 5

[keith-turner]

Do you have a specific example or setup that demonstrates this issue? I wrote a test in 2.1.4 to check this and it failed as expected: error with the message ...attempted to import to 6 tablets. Max tablets allowed set to 5

In your test can you try to bulk import again after the failure from the same directory? Want to see if that hangs.

[keith-turner]

Suspect that bulk import 1 from dir A failed and left dir A reserved in ZK and then a 2nd attempt to bulk import dir A will hang because the dir is reserved.

[kevinrr888]

Both attempts fail without hanging. Here's the test for context (wrote in BulkNewIT)

  @Test
  public void testExceedsMaxTablets() throws Exception {
    try (AccumuloClient c = Accumulo.newClient().from(getClientProps()).build()) {
      final int maxTablets = 5;
      final int numTablets = 6;
      String dir = getDir("/testExceedsMaxTablets-");
      writeData(fs, dir + "/f1.", aconf, 0, numTablets);
      var props = Map.of(Property.TABLE_BULK_MAX_TABLETS.getKey(), maxTablets + "");
      var splits = IntStream.range(1, numTablets).mapToObj(BulkNewIT::row).map(Text::new)
              .collect(Collectors.toCollection(TreeSet::new));
      c.tableOperations().delete(tableName);
      c.tableOperations().create(tableName, new NewTableConfiguration().setProperties(props).withSplits(splits));
      try {
        c.tableOperations().importDirectory(dir).to(tableName).load();
      } catch (Exception e) {
        LOG.error("ignoring exception", e);
      }
      c.tableOperations().importDirectory(dir).to(tableName).load();
    }
  }