replace Long.parseLong+NumberFormatException with custom code for integer detection

Author: Dušan Markovič

src/main/java/io/github/delirius325/jmeter/backendlistener/elasticsearch/ElasticSearchMetric.java

@@ -31,8 +31,9 @@ public class ElasticSearchMetric {
     private boolean allReqHeaders;
     private boolean allResHeaders;
 
-    public ElasticSearchMetric(SampleResult sr, String testMode, String timeStamp, int buildNumber,
-                               boolean parseReqHeaders, boolean parseResHeaders, Set<String> fields) {
+    public ElasticSearchMetric(
+            SampleResult sr, String testMode, String timeStamp, int buildNumber,
+            boolean parseReqHeaders, boolean parseResHeaders, Set<String> fields) {
         this.sampleResult = sr;
         this.esTestMode = testMode.trim();
         this.esTimestamp = timeStamp.trim();
@@ -161,12 +162,9 @@ private void addCustomFields(BackendListenerContext context) {
 
             if (!parameterName.startsWith("es.") && context.containsParameter(parameterName)
                     && !"".equals(parameter = context.getParameter(parameterName).trim())) {
-
-                try {
+                if (isInteger(parameter)) {
                     addFilteredJSON(parameterName, Long.parseLong(parameter));
-                } catch (NumberFormatException e) {
-                    if (logger.isDebugEnabled())
-                        logger.debug("Cannot convert custom field to number [name={}, value={}]]", parameterName, parameter);
+                } else {
                     addFilteredJSON(parameterName, parameter);
                 }
             }
@@ -281,4 +279,28 @@ public Date getElapsedTime(boolean forBuildComparison) {
             return null;
         }
     }
+
+    private static boolean isInteger(String str) {
+        if (str == null) {
+            return false;
+        }
+        int length = str.length();
+        if (length == 0) {
+            return false;
+        }
+        int i = 0;
+        if (str.charAt(0) == '-') {
+            if (length == 1) {
+                return false;
+            }
+            i = 1;
+        }
+        for (; i < length; i++) {
+            char c = str.charAt(i);
+            if (c < '0' || c > '9') {
+                return false;
+            }
+        }
+        return true;
+    }
 }

src/main/java/io/github/delirius325/jmeter/backendlistener/elasticsearch/ElasticSearchMetricSender.java

@@ -87,13 +87,11 @@ private Request setAuthorizationHeader(Request request) {
 
     /**
      * This method creates the ElasticSearch index.
-     * 
-     * @throws IOException
      */
-    public void createIndex() throws IOException {
+    public void createIndex() {
         try {
             this.client.performRequest(setAuthorizationHeader(new Request("PUT", "/" + this.esIndex)));
-        } catch (Exception e) {
+        } catch (IOException e) {
             logger.info("Index already exists!");
         }
     }

src/test/java/io/github/delirius325/jmeter/backendlistener/elasticsearch/TestElasticSearchBackendHTTPsConnection.java

@@ -52,7 +52,7 @@ public void onFailure(Node node) {
     }
 
     @Test
-    public void createIndex() throws Exception {
+    public void createIndex() {
         sender.createIndex();
     }
 }