Skip to content

Conversation

@kdueck84
Copy link
Contributor

@kdueck84 kdueck84 commented Nov 14, 2025

fix-nfs-options

SUMMARY

Fixes #203

ISSUE TYPE
  • Bugfix Pull Request

Problem

The proxmox_storage module exposes an options parameter under nfs_options,
but the module never passes this value to the API payload.

Fix

  • Add missing options to NFS storage payload

Result

NFS mount options are now correctly applied when creating or updating NFS
storage definitions on Proxmox.

fix-nfs-options
@Thulium-Drake
Copy link
Collaborator

Thanks for this! Can you please add a changelog fragment? :-)

@codecov
Copy link

codecov bot commented Nov 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.64%. Comparing base (9a176e2) to head (4784545).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
+ Coverage   66.43%   69.64%   +3.20%     
==========================================
  Files          73       77       +4     
  Lines        7437     8882    +1445     
  Branches     1404     1812     +408     
==========================================
+ Hits         4941     6186    +1245     
- Misses       2264     2408     +144     
- Partials      232      288      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Thulium-Drake Thulium-Drake merged commit fee999c into ansible-collections:main Dec 3, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

proxmox_storage module does not update content parameter on existing storage

2 participants