From 507a51bad480abe6ae1cd2c619185a279cdaf5ad Mon Sep 17 00:00:00 2001 From: Jay <53023+jayair@users.noreply.github.com> Date: Fri, 17 Jul 2026 23:41:15 +0000 Subject: [PATCH 1/3] fix(app): restore question pager segments --- .../regression/session-request-docks.spec.ts | 35 +++++++++++++++++++ .../src/components/message-part.css | 2 +- 2 files changed, 36 insertions(+), 1 deletion(-) diff --git a/packages/app/e2e/regression/session-request-docks.spec.ts b/packages/app/e2e/regression/session-request-docks.spec.ts index 714d6ca96f15..c4e5e7c77926 100644 --- a/packages/app/e2e/regression/session-request-docks.spec.ts +++ b/packages/app/e2e/regression/session-request-docks.spec.ts @@ -70,6 +70,41 @@ test("shows a pending question dock", async ({ page }) => { expect((await reply).postDataJSON()).toEqual({ answers: [["Minimal"]] }) }) +test("shows every question in the question pager", async ({ page }) => { + await mockServer(page, { + questions: [ + { + id: "question-request", + sessionID, + questions: Array.from({ length: 4 }, (_, index) => ({ + header: `Question ${index + 1}`, + question: `Question ${index + 1}?`, + options: [{ label: "Yes", description: "Continue" }], + })), + }, + ], + }) + + await page.goto(`/${base64Encode(directory)}/session/${sessionID}`) + await expectSessionTitle(page, title) + + const question = page.locator('[data-component="dock-prompt"][data-kind="question"]') + const segments = question.locator('[data-slot="question-progress-segment"]') + await expect(segments).toHaveCount(4) + await expect + .poll(() => + segments.nth(1).evaluate((element) => ({ + segment: getComputedStyle(element, "::after").backgroundColor, + expected: getComputedStyle(element).getPropertyValue("--v2-background-bg-layer-04").trim(), + })), + ) + .toEqual({ segment: "rgb(219, 219, 219)", expected: "#dbdbdbff" }) + + await question.getByRole("button", { name: "Questions 3" }).click() + await expect(question.getByText("3 of 4 questions")).toBeVisible() + await expect(question.getByText("Question 3?", { exact: true })).toBeVisible() +}) + test("shows a pending permission dock", async ({ page }) => { await mockServer(page, { permissions: [ diff --git a/packages/session-ui/src/components/message-part.css b/packages/session-ui/src/components/message-part.css index 206350724116..a12fdacfe415 100644 --- a/packages/session-ui/src/components/message-part.css +++ b/packages/session-ui/src/components/message-part.css @@ -891,7 +891,7 @@ width: 16px; height: 2px; border-radius: 999px; - background-color: var(--icon-weak-base); + background-color: var(--v2-background-bg-layer-04); transition: background-color 0.2s ease; } From 1ee1b2f7c0f474670f41bf24e2e4d24bfb173a72 Mon Sep 17 00:00:00 2001 From: Jay <53023+jayair@users.noreply.github.com> Date: Fri, 17 Jul 2026 23:47:02 +0000 Subject: [PATCH 2/3] test(app): remove question pager coverage --- .../regression/session-request-docks.spec.ts | 35 ------------------- 1 file changed, 35 deletions(-) diff --git a/packages/app/e2e/regression/session-request-docks.spec.ts b/packages/app/e2e/regression/session-request-docks.spec.ts index c4e5e7c77926..714d6ca96f15 100644 --- a/packages/app/e2e/regression/session-request-docks.spec.ts +++ b/packages/app/e2e/regression/session-request-docks.spec.ts @@ -70,41 +70,6 @@ test("shows a pending question dock", async ({ page }) => { expect((await reply).postDataJSON()).toEqual({ answers: [["Minimal"]] }) }) -test("shows every question in the question pager", async ({ page }) => { - await mockServer(page, { - questions: [ - { - id: "question-request", - sessionID, - questions: Array.from({ length: 4 }, (_, index) => ({ - header: `Question ${index + 1}`, - question: `Question ${index + 1}?`, - options: [{ label: "Yes", description: "Continue" }], - })), - }, - ], - }) - - await page.goto(`/${base64Encode(directory)}/session/${sessionID}`) - await expectSessionTitle(page, title) - - const question = page.locator('[data-component="dock-prompt"][data-kind="question"]') - const segments = question.locator('[data-slot="question-progress-segment"]') - await expect(segments).toHaveCount(4) - await expect - .poll(() => - segments.nth(1).evaluate((element) => ({ - segment: getComputedStyle(element, "::after").backgroundColor, - expected: getComputedStyle(element).getPropertyValue("--v2-background-bg-layer-04").trim(), - })), - ) - .toEqual({ segment: "rgb(219, 219, 219)", expected: "#dbdbdbff" }) - - await question.getByRole("button", { name: "Questions 3" }).click() - await expect(question.getByText("3 of 4 questions")).toBeVisible() - await expect(question.getByText("Question 3?", { exact: true })).toBeVisible() -}) - test("shows a pending permission dock", async ({ page }) => { await mockServer(page, { permissions: [ From 3d3ebc99ce1ad5533e0cc31a0be69052afe5a487 Mon Sep 17 00:00:00 2001 From: Jay <53023+jayair@users.noreply.github.com> Date: Fri, 17 Jul 2026 23:52:38 +0000 Subject: [PATCH 3/3] fix(app): increase question pager contrast --- packages/session-ui/src/components/message-part.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/session-ui/src/components/message-part.css b/packages/session-ui/src/components/message-part.css index a12fdacfe415..f4e8f6898132 100644 --- a/packages/session-ui/src/components/message-part.css +++ b/packages/session-ui/src/components/message-part.css @@ -891,7 +891,7 @@ width: 16px; height: 2px; border-radius: 999px; - background-color: var(--v2-background-bg-layer-04); + background-color: var(--v2-icon-icon-muted); transition: background-color 0.2s ease; }